Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tech-debt/structure: remove always nil error param from expandRedshiftParameters func #13665

Merged
merged 1 commit into from
Jun 12, 2020

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Jun 8, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #13278

Release note for CHANGELOG:

tech-debt: remove always nil error param from expandRedshiftParameters func

Output from acceptance testing:

--- PASS: TestExpandStepAdjustments (0.00s)
--- PASS: TestExpandElasticacheParameters (0.00s)
--- PASS: TestFlattenRedshiftParameters (0.00s)
--- PASS: TestFlattenParameters (0.00s)
--- PASS: TestExpandParameters (0.00s)
--- PASS: TestExpandRedshiftParameters (0.00s)
--- PASS: TestExpandStringList (0.00s)
--- PASS: TestDiffStringMaps (0.00s)
--- PASS: TestFlattenHealthCheck (0.00s)
--- PASS: TestFlattenOrganizationsOrganizationalUnits (0.00s)
--- PASS: TestExpandListeners (0.00s)
--- PASS: TestExpandIPPerms_nonVPC (0.00s)
--- PASS: TestExpandIPPerms_NegOneProtocol (0.00s)
--- PASS: TestExpandStringListEmptyItems (0.00s)
--- PASS: TestExpandIPPerms (0.00s)
--- PASS: TestExpandListeners_invalid (0.00s)
--- PASS: TestFlattenElasticacheParameters (0.00s)
--- PASS: TestFlattenNetworkInterfacesPrivateIPAddresses (0.00s)
--- PASS: TestFlattenGroupIdentifiers (0.00s)
--- PASS: TestExpandInstanceString (0.00s)
--- PASS: TestFlattenAttachment (0.00s)
--- PASS: TestExpandPrivateIPAddresses (0.00s)
--- PASS: TestFlattenAttachmentWhenNoInstanceId (0.00s)
--- PASS: TestFlattenResourceRecords (0.00s)
    --- PASS: TestFlattenResourceRecords/TXT (0.00s)
    --- PASS: TestFlattenResourceRecords/SPF (0.00s)
    --- PASS: TestFlattenResourceRecords/CNAME (0.00s)
    --- PASS: TestFlattenResourceRecords/MX (0.00s)
--- PASS: TestFlattenStepAdjustments (0.00s)
--- PASS: TestFlattenAsgEnabledMetrics (0.00s)
--- PASS: TestExpandPolicyAttributes (0.00s)
--- PASS: TestFlattenKinesisShardLevelMetrics (0.00s)
--- PASS: TestFlattenSecurityGroups (0.00s)
--- PASS: TestCanonicalXML (0.00s)
    --- PASS: TestCanonicalXML/Config_sample_from_MSDN (0.00s)
    --- PASS: TestCanonicalXML/Config_sample_from_MSDN,_modified (0.00s)
    --- PASS: TestCanonicalXML/Config_sample_from_MSDN,_flaw (0.00s)
    --- PASS: TestCanonicalXML/A_note (0.00s)
--- PASS: TestExpandPolicyAttributes_invalid (0.00s)
--- PASS: TestFlattenApiGatewayThrottleSettings (0.00s)
--- PASS: TestExpandPolicyAttributes_empty (0.00s)
--- PASS: TestFlattenPolicyAttributes (0.00s)
--- PASS: TestCognitoUserPoolSchemaAttributeMatchesStandardAttribute (0.00s)
--- PASS: TestExpandRdsClusterScalingConfiguration_serverless (0.00s)
--- PASS: TestNormalizeCloudFormationTemplate (0.00s)
--- PASS: TestCheckYamlString (0.00s)
--- PASS: TestExpandRdsClusterScalingConfiguration_basic (0.00s)
--- PASS: TestAccAWSRedshiftParameterGroup_basic (9.11s)
--- PASS: TestAccAWSRedshiftParameterGroup_withParameters (9.70s)
--- PASS: TestAccAWSRedshiftParameterGroup_withoutParameters (9.44s)
--- PASS: TestAccAWSRedshiftParameterGroup_withTags (20.46s)

@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/redshift Issues and PRs that pertain to the redshift service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jun 8, 2020
@anGie44 anGie44 added the technical-debt Addresses areas of the codebase that need refactoring or redesign. label Jun 8, 2020
@anGie44 anGie44 changed the title tech-debt: remove always nil error param from expandredshiftparameters func tech-debt: remove always nil error param from expandRedshiftParameters func Jun 8, 2020
@anGie44 anGie44 changed the title tech-debt: remove always nil error param from expandRedshiftParameters func tech-debt/structure: remove always nil error param from expandRedshiftParameters func Jun 8, 2020
@anGie44 anGie44 marked this pull request as ready for review June 8, 2020 23:24
@anGie44 anGie44 requested a review from a team June 8, 2020 23:24
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🚀

@anGie44 anGie44 merged commit 684e66e into master Jun 12, 2020
@anGie44 anGie44 deleted the ap_unparam_linting_expandredshiftparameters branch June 12, 2020 15:46
@anGie44 anGie44 added this to the v2.67.0 milestone Jun 12, 2020
@ghost
Copy link

ghost commented Jun 19, 2020

This has been released in version 2.67.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Jul 12, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/redshift Issues and PRs that pertain to the redshift service. size/XS Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants