Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider: First batch of unparam linter fixes #13279

Merged
merged 2 commits into from
May 19, 2020
Merged

provider: First batch of unparam linter fixes #13279

merged 2 commits into from
May 19, 2020

Conversation

bflad
Copy link
Contributor

@bflad bflad commented May 12, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Reference: #13278

Release note for CHANGELOG:

NONE

Previously:

aws/resource_aws_api_gateway_base_path_mapping_test.go:124:56: `testAccCheckAWSAPIGatewayBasePathExists` - `name` is unused (unparam)
func testAccCheckAWSAPIGatewayBasePathExists(n string, name string, res *apigateway.BasePathMapping) resource.TestCheckFunc {
                                                       ^
aws/resource_aws_athena_database.go:67:126: expandAthenaResultConfiguration - result 1 (error) is always nil (unparam)
func expandAthenaResultConfiguration(bucket string, encryptionConfigurationList []interface{}) (*athena.ResultConfiguration, error) {
                                                                                                                             ^
aws/resource_aws_cloudtrail_test.go:552:67: `testAccCheckCloudTrailLoggingEnabled` - `trail` is unused (unparam)
func testAccCheckCloudTrailLoggingEnabled(n string, desired bool, trail *cloudtrail.Trail) resource.TestCheckFunc {
                                                                  ^
aws/resource_aws_ecs_cluster_test.go:494:58: `testAccAWSEcsClusterCapacityProvidersFargate` - `providerName` is unused (unparam)
func testAccAWSEcsClusterCapacityProvidersFargate(rName, providerName string) string {
                                                         ^
aws/resource_aws_ecs_cluster_test.go:510:62: `testAccAWSEcsClusterCapacityProvidersFargateSpot` - `providerName` is unused (unparam)
func testAccAWSEcsClusterCapacityProvidersFargateSpot(rName, providerName string) string {
                                                             ^
aws/resource_aws_ecs_cluster_test.go:526:62: `testAccAWSEcsClusterCapacityProvidersFargateBoth` - `providerName` is unused (unparam)
func testAccAWSEcsClusterCapacityProvidersFargateBoth(rName, providerName string) string {
                                                             ^
aws/resource_aws_ecs_cluster_test.go:542:68: `testAccAWSEcsClusterCapacityProvidersFargateNoStrategy` - `providerName` is unused (unparam)
func testAccAWSEcsClusterCapacityProvidersFargateNoStrategy(rName, providerName string) string {
                                                                   ^
aws/resource_aws_ecs_cluster_test.go:552:72: `testAccAWSEcsClusterCapacityProvidersFargateSpotNoStrategy` - `providerName` is unused (unparam)
func testAccAWSEcsClusterCapacityProvidersFargateSpotNoStrategy(rName, providerName string) string {
                                                                       ^
aws/resource_aws_ecs_task_definition.go:611:93: expandEcsInferenceAccelerators - result 1 (error) is always nil (unparam)
func expandEcsInferenceAccelerators(configured []interface{}) ([]*ecs.InferenceAccelerator, error) {
                                                                                            ^
aws/resource_aws_eip_association_test.go:233:61: `testAccCheckAWSEIPAssociationHasIpBasedId` - `res` is unused (unparam)
func testAccCheckAWSEIPAssociationHasIpBasedId(name string, res *ec2.Address) resource.TestCheckFunc {
                                                            ^
aws/resource_aws_inspector_resource_group_test.go:72:53: `testAccCheckAWSInspectorResourceGroupRecreated` - `t` is unused (unparam)
func testAccCheckAWSInspectorResourceGroupRecreated(t *testing.T, v1, v2 *inspector.ResourceGroup) resource.TestCheckFunc {
                                                    ^
aws/resource_aws_instance_migrate.go:79:56: writeV1BlockDevice - result 0 (error) is always nil (unparam)
	is *terraform.InstanceState, oldBd map[string]string) error {
	                                                      ^
aws/resource_aws_kinesis_analytics_application.go:1088:96: createApplicationUpdateOpts - result 1 (error) is always nil (unparam)
func createApplicationUpdateOpts(d *schema.ResourceData) (*kinesisanalytics.ApplicationUpdate, error) {
                                                                                               ^
aws/resource_aws_kinesis_video_stream_test.go:167:68: `testAccCheckKinesisVideoStreamDisappears` - `stream` is unused (unparam)
func testAccCheckKinesisVideoStreamDisappears(resourceName string, stream *kinesisvideo.StreamInfo) resource.TestCheckFunc {
                                                                   ^
aws/resource_aws_lambda_function_test.go:2375:56: `testAccAWSLambdaConfigWithDeadLetterConfigUpdated` - `funcName` is unused (unparam)
func testAccAWSLambdaConfigWithDeadLetterConfigUpdated(funcName, topic1Name, topic2Name, policyName,
                                                       ^
aws/resource_aws_lambda_permission_test.go:544:53: `testAccAWSLambdaPermissionDisappears` - `statement` is unused (unparam)
func testAccAWSLambdaPermissionDisappears(n string, statement *LambdaPolicyStatement) resource.TestCheckFunc {
                                                    ^
aws/resource_aws_lightsail_key_pair_test.go:178:63: `testAccAWSLightsailKeyPairConfig_imported` - `key` is unused (unparam)
func testAccAWSLightsailKeyPairConfig_imported(lightsailName, key string) string {
                                                              ^
aws/resource_aws_main_route_table_association_test.go:73:2: `testAccCheckMainRouteTableAssociation` - `routeTableResource` is unused (unparam)
	routeTableResource string) resource.TestCheckFunc {
	^

Output from acceptance testing:

(TestAccAWSAPIGatewayBasePathMapping_|TestAccAWSAthenaDatabase_|TestAccAWSCloudTrail/Trail/enableLogging|TestAccAWSEcsCluster_CapacityProviders|TestAccAWSEcsTaskDefinition_|TestAccAWSInspectorResourceGroup_basic|TestAccAWSKinesisAnalyticsApplication_|TestAccAWSKinesisVideoStream_disappears|TestAccAWSLambdaFunction_DeadLetterConfigUpdated|TestAccAWSLambdaPermission_disappears|TestAccAWSLightsailKeyPair_publicKey|TestAccAWSMainRouteTableAssociation_basic)

--- PASS: TestAccAWSAPIGatewayBasePathMapping_BasePath_Empty (54.58s)
--- PASS: TestAccAWSAPIGatewayBasePathMapping_basic (55.48s)

--- PASS: TestAccAWSAthenaDatabase_basic (60.51s)
--- PASS: TestAccAWSAthenaDatabase_destroyFailsIfTablesExist (73.58s)
--- PASS: TestAccAWSAthenaDatabase_encryption (71.05s)
--- PASS: TestAccAWSAthenaDatabase_forceDestroyAlwaysSucceeds (65.41s)
--- PASS: TestAccAWSAthenaDatabase_nameCantHaveUppercase (1.46s)
--- PASS: TestAccAWSAthenaDatabase_nameStartsWithUnderscore (61.23s)

--- PASS: TestAccAWSCloudTrail/Trail/enableLogging (105.77s)

--- PASS: TestAccAWSEcsCluster_CapacityProviders (48.45s)
--- PASS: TestAccAWSEcsCluster_CapacityProvidersNoStrategy (53.69s)
--- PASS: TestAccAWSEcsCluster_CapacityProvidersUpdate (81.22s)

--- PASS: TestAccAWSEcsTaskDefinition_arrays (16.36s)
--- PASS: TestAccAWSEcsTaskDefinition_basic (26.60s)
--- PASS: TestAccAWSEcsTaskDefinition_changeVolumesForcesNewResource (26.89s)
--- PASS: TestAccAWSEcsTaskDefinition_constraint (16.28s)
--- PASS: TestAccAWSEcsTaskDefinition_ExecutionRole (16.69s)
--- PASS: TestAccAWSEcsTaskDefinition_Fargate (21.81s)
--- PASS: TestAccAWSEcsTaskDefinition_Inactive (25.92s)
--- PASS: TestAccAWSEcsTaskDefinition_inferenceAccelerator (14.07s)
--- PASS: TestAccAWSEcsTaskDefinition_ProxyConfiguration (26.41s)
--- PASS: TestAccAWSEcsTaskDefinition_Tags (45.91s)
--- PASS: TestAccAWSEcsTaskDefinition_withDockerVolume (16.00s)
--- PASS: TestAccAWSEcsTaskDefinition_withDockerVolumeMinimalConfig (16.27s)
--- PASS: TestAccAWSEcsTaskDefinition_withEcsService (91.23s)
--- PASS: TestAccAWSEcsTaskDefinition_withEFSVolume (27.55s)
--- PASS: TestAccAWSEcsTaskDefinition_withEFSVolumeMinimal (27.70s)
--- PASS: TestAccAWSEcsTaskDefinition_withIPCMode (16.69s)
--- PASS: TestAccAWSEcsTaskDefinition_withNetworkMode (16.85s)
--- PASS: TestAccAWSEcsTaskDefinition_withPidMode (18.24s)
--- PASS: TestAccAWSEcsTaskDefinition_withScratchVolume (15.69s)
--- PASS: TestAccAWSEcsTaskDefinition_withTaskRoleArn (16.75s)
--- PASS: TestAccAWSEcsTaskDefinition_withTaskScopedDockerVolume (16.38s)

--- PASS: TestAccAWSInspectorResourceGroup_basic (22.88s)

--- PASS: TestAccAWSKinesisAnalyticsApplication_addCloudwatchLoggingOptions (34.01s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_basic (18.73s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_inputsAdd (75.84s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_inputsKinesisFirehose (103.79s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_inputsKinesisStream (63.12s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_inputsUpdateKinesisStream (120.00s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_Outputs_Lambda_Add (50.36s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_Outputs_Lambda_Create (39.75s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_outputsAdd (75.76s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_outputsKinesisStream (62.71s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_outputsMultiple (66.35s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_outputsUpdateKinesisStream (123.03s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_referenceDataSource (38.35s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_referenceDataSourceUpdate (69.86s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_tags (49.91s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_update (28.74s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_updateCloudwatchLoggingOptions (46.64s)
--- PASS: TestAccAWSKinesisVideoStream_disappears (95.02s)

--- PASS: TestAccAWSLambdaFunction_DeadLetterConfigUpdated (76.72s)

--- PASS: TestAccAWSLambdaPermission_disappears (100.98s)

--- PASS: TestAccAWSLightsailKeyPair_publicKey (29.88s)

--- PASS: TestAccAWSMainRouteTableAssociation_basic (69.00s)

@bflad
provider: First batch of unparam linter fixes
d9283a1 
Reference: #13278

Previously:

```
aws/resource_aws_api_gateway_base_path_mapping_test.go:124:56: `testAccCheckAWSAPIGatewayBasePathExists` - `name` is unused (unparam)
func testAccCheckAWSAPIGatewayBasePathExists(n string, name string, res *apigateway.BasePathMapping) resource.TestCheckFunc {
                                                       ^
aws/resource_aws_athena_database.go:67:126: expandAthenaResultConfiguration - result 1 (error) is always nil (unparam)
func expandAthenaResultConfiguration(bucket string, encryptionConfigurationList []interface{}) (*athena.ResultConfiguration, error) {
                                                                                                                             ^
aws/resource_aws_cloudtrail_test.go:552:67: `testAccCheckCloudTrailLoggingEnabled` - `trail` is unused (unparam)
func testAccCheckCloudTrailLoggingEnabled(n string, desired bool, trail *cloudtrail.Trail) resource.TestCheckFunc {
                                                                  ^
aws/resource_aws_ecs_cluster_test.go:494:58: `testAccAWSEcsClusterCapacityProvidersFargate` - `providerName` is unused (unparam)
func testAccAWSEcsClusterCapacityProvidersFargate(rName, providerName string) string {
                                                         ^
aws/resource_aws_ecs_cluster_test.go:510:62: `testAccAWSEcsClusterCapacityProvidersFargateSpot` - `providerName` is unused (unparam)
func testAccAWSEcsClusterCapacityProvidersFargateSpot(rName, providerName string) string {
                                                             ^
aws/resource_aws_ecs_cluster_test.go:526:62: `testAccAWSEcsClusterCapacityProvidersFargateBoth` - `providerName` is unused (unparam)
func testAccAWSEcsClusterCapacityProvidersFargateBoth(rName, providerName string) string {
                                                             ^
aws/resource_aws_ecs_cluster_test.go:542:68: `testAccAWSEcsClusterCapacityProvidersFargateNoStrategy` - `providerName` is unused (unparam)
func testAccAWSEcsClusterCapacityProvidersFargateNoStrategy(rName, providerName string) string {
                                                                   ^
aws/resource_aws_ecs_cluster_test.go:552:72: `testAccAWSEcsClusterCapacityProvidersFargateSpotNoStrategy` - `providerName` is unused (unparam)
func testAccAWSEcsClusterCapacityProvidersFargateSpotNoStrategy(rName, providerName string) string {
                                                                       ^
aws/resource_aws_ecs_task_definition.go:611:93: expandEcsInferenceAccelerators - result 1 (error) is always nil (unparam)
func expandEcsInferenceAccelerators(configured []interface{}) ([]*ecs.InferenceAccelerator, error) {
                                                                                            ^
aws/resource_aws_eip_association_test.go:233:61: `testAccCheckAWSEIPAssociationHasIpBasedId` - `res` is unused (unparam)
func testAccCheckAWSEIPAssociationHasIpBasedId(name string, res *ec2.Address) resource.TestCheckFunc {
                                                            ^
aws/resource_aws_inspector_resource_group_test.go:72:53: `testAccCheckAWSInspectorResourceGroupRecreated` - `t` is unused (unparam)
func testAccCheckAWSInspectorResourceGroupRecreated(t *testing.T, v1, v2 *inspector.ResourceGroup) resource.TestCheckFunc {
                                                    ^
aws/resource_aws_instance_migrate.go:79:56: writeV1BlockDevice - result 0 (error) is always nil (unparam)
	is *terraform.InstanceState, oldBd map[string]string) error {
	                                                      ^
aws/resource_aws_kinesis_analytics_application.go:1088:96: createApplicationUpdateOpts - result 1 (error) is always nil (unparam)
func createApplicationUpdateOpts(d *schema.ResourceData) (*kinesisanalytics.ApplicationUpdate, error) {
                                                                                               ^
aws/resource_aws_kinesis_video_stream_test.go:167:68: `testAccCheckKinesisVideoStreamDisappears` - `stream` is unused (unparam)
func testAccCheckKinesisVideoStreamDisappears(resourceName string, stream *kinesisvideo.StreamInfo) resource.TestCheckFunc {
                                                                   ^
aws/resource_aws_lambda_function_test.go:2375:56: `testAccAWSLambdaConfigWithDeadLetterConfigUpdated` - `funcName` is unused (unparam)
func testAccAWSLambdaConfigWithDeadLetterConfigUpdated(funcName, topic1Name, topic2Name, policyName,
                                                       ^
aws/resource_aws_lambda_permission_test.go:544:53: `testAccAWSLambdaPermissionDisappears` - `statement` is unused (unparam)
func testAccAWSLambdaPermissionDisappears(n string, statement *LambdaPolicyStatement) resource.TestCheckFunc {
                                                    ^
aws/resource_aws_lightsail_key_pair_test.go:178:63: `testAccAWSLightsailKeyPairConfig_imported` - `key` is unused (unparam)
func testAccAWSLightsailKeyPairConfig_imported(lightsailName, key string) string {
                                                              ^
aws/resource_aws_main_route_table_association_test.go:73:2: `testAccCheckMainRouteTableAssociation` - `routeTableResource` is unused (unparam)
	routeTableResource string) resource.TestCheckFunc {
	^
```

Output from acceptance testing:

```
(TestAccAWSAPIGatewayBasePathMapping_|TestAccAWSAthenaDatabase_|TestAccAWSCloudTrail/Trail/enableLogging|TestAccAWSEcsCluster_CapacityProviders|TestAccAWSEcsTaskDefinition_|TestAccAWSInspectorResourceGroup_basic|TestAccAWSKinesisAnalyticsApplication_|TestAccAWSKinesisVideoStream_disappears|TestAccAWSLambdaFunction_DeadLetterConfigUpdated|TestAccAWSLambdaPermission_disappears|TestAccAWSLightsailKeyPair_publicKey|TestAccAWSMainRouteTableAssociation_basic)

--- PASS: TestAccAWSAPIGatewayBasePathMapping_BasePath_Empty (54.58s)
--- PASS: TestAccAWSAPIGatewayBasePathMapping_basic (55.48s)

--- PASS: TestAccAWSAthenaDatabase_basic (60.51s)
--- PASS: TestAccAWSAthenaDatabase_destroyFailsIfTablesExist (73.58s)
--- PASS: TestAccAWSAthenaDatabase_encryption (71.05s)
--- PASS: TestAccAWSAthenaDatabase_forceDestroyAlwaysSucceeds (65.41s)
--- PASS: TestAccAWSAthenaDatabase_nameCantHaveUppercase (1.46s)
--- PASS: TestAccAWSAthenaDatabase_nameStartsWithUnderscore (61.23s)

--- PASS: TestAccAWSCloudTrail/Trail/enableLogging (105.77s)

--- PASS: TestAccAWSEcsCluster_CapacityProviders (48.45s)
--- PASS: TestAccAWSEcsCluster_CapacityProvidersNoStrategy (53.69s)
--- PASS: TestAccAWSEcsCluster_CapacityProvidersUpdate (81.22s)

--- PASS: TestAccAWSEcsTaskDefinition_arrays (16.36s)
--- PASS: TestAccAWSEcsTaskDefinition_basic (26.60s)
--- PASS: TestAccAWSEcsTaskDefinition_changeVolumesForcesNewResource (26.89s)
--- PASS: TestAccAWSEcsTaskDefinition_constraint (16.28s)
--- PASS: TestAccAWSEcsTaskDefinition_ExecutionRole (16.69s)
--- PASS: TestAccAWSEcsTaskDefinition_Fargate (21.81s)
--- PASS: TestAccAWSEcsTaskDefinition_Inactive (25.92s)
--- PASS: TestAccAWSEcsTaskDefinition_inferenceAccelerator (14.07s)
--- PASS: TestAccAWSEcsTaskDefinition_ProxyConfiguration (26.41s)
--- PASS: TestAccAWSEcsTaskDefinition_Tags (45.91s)
--- PASS: TestAccAWSEcsTaskDefinition_withDockerVolume (16.00s)
--- PASS: TestAccAWSEcsTaskDefinition_withDockerVolumeMinimalConfig (16.27s)
--- PASS: TestAccAWSEcsTaskDefinition_withEcsService (91.23s)
--- PASS: TestAccAWSEcsTaskDefinition_withEFSVolume (27.55s)
--- PASS: TestAccAWSEcsTaskDefinition_withEFSVolumeMinimal (27.70s)
--- PASS: TestAccAWSEcsTaskDefinition_withIPCMode (16.69s)
--- PASS: TestAccAWSEcsTaskDefinition_withNetworkMode (16.85s)
--- PASS: TestAccAWSEcsTaskDefinition_withPidMode (18.24s)
--- PASS: TestAccAWSEcsTaskDefinition_withScratchVolume (15.69s)
--- PASS: TestAccAWSEcsTaskDefinition_withTaskRoleArn (16.75s)
--- PASS: TestAccAWSEcsTaskDefinition_withTaskScopedDockerVolume (16.38s)

--- PASS: TestAccAWSInspectorResourceGroup_basic (22.88s)

--- PASS: TestAccAWSKinesisAnalyticsApplication_addCloudwatchLoggingOptions (34.01s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_basic (18.73s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_inputsAdd (75.84s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_inputsKinesisFirehose (103.79s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_inputsKinesisStream (63.12s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_inputsUpdateKinesisStream (120.00s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_Outputs_Lambda_Add (50.36s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_Outputs_Lambda_Create (39.75s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_outputsAdd (75.76s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_outputsKinesisStream (62.71s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_outputsMultiple (66.35s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_outputsUpdateKinesisStream (123.03s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_referenceDataSource (38.35s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_referenceDataSourceUpdate (69.86s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_tags (49.91s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_update (28.74s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_updateCloudwatchLoggingOptions (46.64s)
--- PASS: TestAccAWSKinesisVideoStream_disappears (95.02s)

--- PASS: TestAccAWSLambdaFunction_DeadLetterConfigUpdated (76.72s)

--- PASS: TestAccAWSLambdaPermission_disappears (100.98s)

--- PASS: TestAccAWSLightsailKeyPair_publicKey (29.88s)

--- PASS: TestAccAWSMainRouteTableAssociation_basic (69.00s)
```
@bflad bflad added the technical-debt Addresses areas of the codebase that need refactoring or redesign. label May 12, 2020
@bflad bflad requested a review from a team May 12, 2020 06:24
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/apigateway Issues and PRs that pertain to the apigateway service. service/athena Issues and PRs that pertain to the athena service. service/cloudtrail Issues and PRs that pertain to the cloudtrail service. service/ec2 Issues and PRs that pertain to the ec2 service. service/ecs Issues and PRs that pertain to the ecs service. service/inspector Issues and PRs that pertain to the inspector service. service/kinesisanalytics Issues and PRs that pertain to the kinesisanalytics service. service/lambda Issues and PRs that pertain to the lambda service. service/lightsail Issues and PRs that pertain to the lightsail service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels May 12, 2020
@bflad
resource/aws_instance: Remove redundant return
1a664bd 
Previously:

```
aws/resource_aws_instance_migrate.go:108:2: S1023: redundant `return` statement (gosimple)
	return
	^
```
@gdavison gdavison self-assigned this May 19, 2020
gdavison
gdavison approved these changes May 19, 2020
View reviewed changes
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

--- PASS: TestDecodeApiGatewayBasePathMappingId (0.00s)
--- PASS: TestAccAWSAthenaDatabase_nameCantHaveUppercase (3.68s)
--- PASS: TestAccAWSCloudTrailServiceAccount_basic (11.20s)
--- PASS: TestAccAWSCloudTrailServiceAccount_Region (12.17s)
--- PASS: TestAccAWSEcsTaskDefinition_withScratchVolume (8.94s)
--- PASS: TestAccAWSEcsTaskDefinition_basic (17.14s)
--- PASS: TestAccAWSEcsTaskDefinition_withDockerVolume (8.99s)
--- PASS: TestAccAWSEcsCluster_disappears (21.27s)
--- PASS: TestAccAWSEcsTaskDefinition_withDockerVolumeMinimalConfig (9.64s)
--- PASS: TestAccAWSEcsCluster_basic (22.79s)
--- PASS: TestAccAWSAPIGatewayBasePathMapping_basic (24.43s)
--- PASS: TestAccAWSEcsTaskDefinition_withTaskScopedDockerVolume (9.65s)
--- PASS: TestAccAWSEcsTaskDefinition_withEFSVolumeMinimal (17.11s)
--- PASS: TestAccAWSEcsTaskDefinition_withEFSVolume (17.21s)
--- PASS: TestAccAWSEcsCluster_Tags (34.75s)
--- PASS: TestAccAWSEcsTaskDefinition_withTaskRoleArn (13.23s)
--- PASS: TestAccAWSAthenaDatabase_basic (35.40s)
--- PASS: TestAccAWSEcsTaskDefinition_withNetworkMode (12.81s)
--- PASS: TestAccAWSAthenaDatabase_nameStartsWithUnderscore (35.76s)
--- PASS: TestAccAWSEcsTaskDefinition_withIPCMode (12.73s)
--- PASS: TestAccAWSAthenaDatabase_encryption (37.16s)
--- PASS: TestAccAWSAthenaDatabase_forceDestroyAlwaysSucceeds (39.00s)
--- PASS: TestValidateAwsEcsTaskDefinitionContainerDefinitions (0.00s)
--- PASS: TestAccAWSEcsTaskDefinition_constraint (9.53s)
--- PASS: TestAccAWSEcsCluster_CapacityProviders (40.85s)
--- PASS: TestAccAWSEcsTaskDefinition_withPidMode (13.43s)
--- PASS: TestAccAWSEcsTaskDefinition_arrays (9.51s)
--- SKIP: TestAccAWSEIPAssociation_ec2Classic (1.08s)
--- PASS: TestAccAWSAthenaDatabase_destroyFailsIfTablesExist (45.06s)
--- PASS: TestAccAWSEcsCluster_CapacityProvidersNoStrategy (45.66s)
--- PASS: TestAWSInstanceMigrateState (0.00s)
--- PASS: TestAWSInstanceMigrateState_empty (0.00s)
--- PASS: TestAccAWSEcsTaskDefinition_inferenceAccelerator (9.64s)
--- PASS: TestAccAWSEcsCluster_SingleCapacityProvider (48.85s)
--- PASS: TestAccAWSEcsTaskDefinition_ExecutionRole (15.02s)
--- PASS: TestAccAWSEcsTaskDefinition_changeVolumesForcesNewResource (15.96s)
--- PASS: TestAccAWSEcsTaskDefinition_Inactive (15.27s)
--- PASS: TestAccAWSEcsCluster_containerInsights (52.94s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_basic (9.93s)
--- PASS: TestAccAWSEcsTaskDefinition_ProxyConfiguration (20.09s)
--- PASS: TestAccAWSInspectorResourceGroup_basic (13.66s)
--- PASS: TestAccAWSEcsTaskDefinition_Fargate (23.60s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_update (14.97s)
--- PASS: TestAccAWSEIPAssociation_networkInterface (23.98s)
--- PASS: TestAccAWSEcsTaskDefinition_Tags (31.00s)
--- PASS: TestAccAWSEcsCluster_CapacityProvidersUpdate (69.04s)
--- PASS: TestAccAWSAPIGatewayBasePathMapping_BasePath_Empty (71.35s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_addCloudwatchLoggingOptions (23.27s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_referenceDataSource (13.18s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_updateCloudwatchLoggingOptions (36.05s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_Outputs_Lambda_Create (24.86s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_tags (23.01s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_inputsKinesisStream (51.97s)
--- PASS: TestAccAWSEcsTaskDefinition_withEcsService (82.32s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_referenceDataSourceUpdate (32.84s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_Outputs_Lambda_Add (42.80s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_outputsKinesisStream (51.22s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_outputsMultiple (51.88s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_outputsAdd (60.24s)
--- PASS: TestAccAWSLambdaFunction_expectFilenameAndS3Attributes (10.32s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_inputsAdd (76.50s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_inputsKinesisFirehose (82.35s)
--- PASS: TestAccAWSLambdaFunction_disappears (32.75s)
--- PASS: TestAccAWSLambdaFunction_concurrency (40.49s)
--- PASS: TestAccAWSLambdaFunction_updateRuntime (36.67s)
--- PASS: TestAccAWSLambdaFunction_basic (43.48s)
--- PASS: TestAccAWSLambdaFunction_concurrencyCycle (47.30s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_inputsUpdateKinesisStream (98.80s)
--- PASS: TestAccAWSLambdaFunction_nilDeadLetterConfig (9.85s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_outputsUpdateKinesisStream (99.50s)
--- PASS: TestAccAWSLambdaFunction_versioned (32.54s)
--- PASS: TestAccAWSLambdaFunction_encryptedEnvVariables (45.46s)
--- PASS: TestAccAWSEIPAssociation_instance (132.27s)
--- PASS: TestAccAWSEIPAssociation_spotInstance (128.18s)
--- PASS: TestAccAWSKinesisVideoStream_disappears (85.40s)
--- PASS: TestAccAWSLambdaFunction_DeadLetterConfig (44.70s)
--- PASS: TestAccAWSLambdaFunction_Layers (28.15s)
--- PASS: TestAccAWSLambdaFunction_versionedUpdate (51.41s)
--- PASS: TestAccAWSLambdaFunction_KmsKeyArn_NoEnvironmentVariables (32.74s)
--- PASS: TestAccAWSLambdaFunction_envVariables (68.70s)
--- PASS: TestAccAWSLambdaFunction_DeadLetterConfigUpdated (44.75s)
--- PASS: TestAccAWSKinesisVideoStream_options (103.54s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_noRuntime (0.95s)
--- PASS: TestAccAWSLambdaFunction_tracingConfig (45.59s)
--- PASS: TestAccAWSLambdaFunction_LayersUpdate (45.73s)
--- PASS: TestAccAWSEIPAssociation_basic (164.00s)
--- PASS: TestAccAWSKinesisVideoStream_Tags (117.28s)
--- PASS: TestAccAWSLambdaFunction_EmptyVpcConfig (32.89s)
--- PASS: TestAccAWSLambdaFunction_s3 (32.56s)
--- PASS: TestAccAWSLambdaFunction_s3Update_basic (31.54s)
--- PASS: TestAccAWSLambdaFunction_localUpdate (37.25s)
--- PASS: TestAccAWSLambdaFunction_localUpdate_nameOnly (37.20s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_NodeJs10x (33.06s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_NodeJs12x (32.75s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_python27 (33.12s)
--- PASS: TestLambdaPermissionUnmarshalling (0.00s)
--- PASS: TestLambdaPermissionGetQualifierFromLambdaAliasOrVersionArn_alias (0.00s)
--- PASS: TestLambdaPermissionGetQualifierFromLambdaAliasOrVersionArn_govcloud (0.00s)
--- PASS: TestLambdaPermissionGetQualifierFromLambdaAliasOrVersionArn_version (0.00s)
--- PASS: TestLambdaPermissionGetQualifierFromLambdaAliasOrVersionArn_invalid (0.00s)
--- PASS: TestLambdaPermissionGetFunctionNameFromLambdaArn_invalid (0.00s)
--- PASS: TestLambdaPermissionGetFunctionNameFromLambdaArn_valid (0.00s)
--- PASS: TestLambdaPermissionGetFunctionNameFromGovCloudLambdaArn (0.00s)
--- PASS: TestAccAWSLambdaFunction_s3Update_unversioned (39.61s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_java8 (32.49s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_java11 (32.30s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_provided (32.48s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_python36 (32.93s)
--- PASS: TestAccAWSLambdaFunction_tags (38.02s)
--- PASS: TestAccAWSCloudTrail (249.36s)
--- PASS: TestAccAWSCloudTrail/Trail (249.36s)
--- PASS: TestAccAWSCloudTrail/Trail/enableLogging (33.61s)
--- PASS: TestAccAWSCloudTrail/Trail/isMultiRegion (38.21s)
--- PASS: TestAccAWSCloudTrail/Trail/eventSelector (33.34s)
--- PASS: TestAccAWSCloudTrail/Trail/tags (25.85s)
--- PASS: TestAccAWSCloudTrail/Trail/basic (20.44s)
--- PASS: TestAccAWSCloudTrail/Trail/cloudwatch (54.41s)
--- PASS: TestAccAWSCloudTrail/Trail/includeGlobalServiceEvents (12.10s)
--- SKIP: TestAccAWSCloudTrail/Trail/isOrganization (1.06s)
--- PASS: TestAccAWSCloudTrail/Trail/logValidation (18.55s)
--- PASS: TestAccAWSCloudTrail/Trail/kmsKey (11.80s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_python37 (32.42s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_python38 (32.85s)
--- PASS: TestAccAWSKinesisVideoStream_basic (172.35s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_ruby25 (33.21s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_ruby27 (33.28s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_dotnetcore31 (33.60s)
--- PASS: TestAccAWSLambdaPermission_basic (31.28s)
--- PASS: TestAccAWSLambdaPermission_withRawFunctionName (30.74s)
--- PASS: TestAccAWSLambdaPermission_withStatementIdPrefix (30.98s)
--- PASS: TestAccAWSEIPAssociation_disappears (229.00s)
--- PASS: TestAccAWSLightsailKeyPair_basic (20.47s)
--- PASS: TestAccAWSLambdaPermission_withQualifier (31.03s)
--- PASS: TestAccAWSLightsailKeyPair_encrypted (20.60s)
--- PASS: TestAccAWSLightsailKeyPair_nameprefix (21.20s)
--- PASS: TestAccAWSLambdaPermission_withSNS (31.92s)
--- PASS: TestAccAWSMainRouteTableAssociation_basic (27.34s)
--- PASS: TestAccAWSLambdaPermission_withIAMRole (31.54s)
--- PASS: TestAccAWSLambdaPermission_multiplePerms (38.16s)
--- PASS: TestAccAWSLightsailKeyPair_publicKey (30.85s)
--- PASS: TestAccAWSLambdaPermission_withS3 (41.50s)
--- PASS: TestAccAWSLambdaPermission_StatementId_Duplicate (87.11s)
--- PASS: TestAccAWSLambdaPermission_disappears (90.43s)
--- PASS: TestAccAWSLambdaFunction_VPC (461.44s)
--- PASS: TestAccAWSLambdaFunction_VPCRemoval (632.53s)
--- PASS: TestAccAWSLambdaFunction_VpcConfig_ProperIamDependencies (625.51s)
--- PASS: TestAccAWSLambdaFunction_VPC_withInvocation (976.80s)
--- PASS: TestAccAWSLambdaFunction_VPCUpdate (1150.72s)

@bflad bflad added this to the v2.63.0 milestone May 19, 2020
@bflad bflad merged commit 35c57d4 into master May 19, 2020
@bflad bflad deleted the td-unparam-batch-1 branch May 19, 2020 23:50
@ghost
Copy link

ghost commented May 22, 2020

This has been released in version 2.63.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

adamdecaf pushed a commit to adamdecaf/terraform-provider-aws that referenced this pull request May 28, 2020
@bflad @adamdecaf
provider: First batch of unparam linter fixes (hashicorp#13279)
ddd5111 
* provider: First batch of unparam linter fixes

Reference: hashicorp#13278

Previously:

```
aws/resource_aws_api_gateway_base_path_mapping_test.go:124:56: `testAccCheckAWSAPIGatewayBasePathExists` - `name` is unused (unparam)
func testAccCheckAWSAPIGatewayBasePathExists(n string, name string, res *apigateway.BasePathMapping) resource.TestCheckFunc {
                                                       ^
aws/resource_aws_athena_database.go:67:126: expandAthenaResultConfiguration - result 1 (error) is always nil (unparam)
func expandAthenaResultConfiguration(bucket string, encryptionConfigurationList []interface{}) (*athena.ResultConfiguration, error) {
                                                                                                                             ^
aws/resource_aws_cloudtrail_test.go:552:67: `testAccCheckCloudTrailLoggingEnabled` - `trail` is unused (unparam)
func testAccCheckCloudTrailLoggingEnabled(n string, desired bool, trail *cloudtrail.Trail) resource.TestCheckFunc {
                                                                  ^
aws/resource_aws_ecs_cluster_test.go:494:58: `testAccAWSEcsClusterCapacityProvidersFargate` - `providerName` is unused (unparam)
func testAccAWSEcsClusterCapacityProvidersFargate(rName, providerName string) string {
                                                         ^
aws/resource_aws_ecs_cluster_test.go:510:62: `testAccAWSEcsClusterCapacityProvidersFargateSpot` - `providerName` is unused (unparam)
func testAccAWSEcsClusterCapacityProvidersFargateSpot(rName, providerName string) string {
                                                             ^
aws/resource_aws_ecs_cluster_test.go:526:62: `testAccAWSEcsClusterCapacityProvidersFargateBoth` - `providerName` is unused (unparam)
func testAccAWSEcsClusterCapacityProvidersFargateBoth(rName, providerName string) string {
                                                             ^
aws/resource_aws_ecs_cluster_test.go:542:68: `testAccAWSEcsClusterCapacityProvidersFargateNoStrategy` - `providerName` is unused (unparam)
func testAccAWSEcsClusterCapacityProvidersFargateNoStrategy(rName, providerName string) string {
                                                                   ^
aws/resource_aws_ecs_cluster_test.go:552:72: `testAccAWSEcsClusterCapacityProvidersFargateSpotNoStrategy` - `providerName` is unused (unparam)
func testAccAWSEcsClusterCapacityProvidersFargateSpotNoStrategy(rName, providerName string) string {
                                                                       ^
aws/resource_aws_ecs_task_definition.go:611:93: expandEcsInferenceAccelerators - result 1 (error) is always nil (unparam)
func expandEcsInferenceAccelerators(configured []interface{}) ([]*ecs.InferenceAccelerator, error) {
                                                                                            ^
aws/resource_aws_eip_association_test.go:233:61: `testAccCheckAWSEIPAssociationHasIpBasedId` - `res` is unused (unparam)
func testAccCheckAWSEIPAssociationHasIpBasedId(name string, res *ec2.Address) resource.TestCheckFunc {
                                                            ^
aws/resource_aws_inspector_resource_group_test.go:72:53: `testAccCheckAWSInspectorResourceGroupRecreated` - `t` is unused (unparam)
func testAccCheckAWSInspectorResourceGroupRecreated(t *testing.T, v1, v2 *inspector.ResourceGroup) resource.TestCheckFunc {
                                                    ^
aws/resource_aws_instance_migrate.go:79:56: writeV1BlockDevice - result 0 (error) is always nil (unparam)
	is *terraform.InstanceState, oldBd map[string]string) error {
	                                                      ^
aws/resource_aws_kinesis_analytics_application.go:1088:96: createApplicationUpdateOpts - result 1 (error) is always nil (unparam)
func createApplicationUpdateOpts(d *schema.ResourceData) (*kinesisanalytics.ApplicationUpdate, error) {
                                                                                               ^
aws/resource_aws_kinesis_video_stream_test.go:167:68: `testAccCheckKinesisVideoStreamDisappears` - `stream` is unused (unparam)
func testAccCheckKinesisVideoStreamDisappears(resourceName string, stream *kinesisvideo.StreamInfo) resource.TestCheckFunc {
                                                                   ^
aws/resource_aws_lambda_function_test.go:2375:56: `testAccAWSLambdaConfigWithDeadLetterConfigUpdated` - `funcName` is unused (unparam)
func testAccAWSLambdaConfigWithDeadLetterConfigUpdated(funcName, topic1Name, topic2Name, policyName,
                                                       ^
aws/resource_aws_lambda_permission_test.go:544:53: `testAccAWSLambdaPermissionDisappears` - `statement` is unused (unparam)
func testAccAWSLambdaPermissionDisappears(n string, statement *LambdaPolicyStatement) resource.TestCheckFunc {
                                                    ^
aws/resource_aws_lightsail_key_pair_test.go:178:63: `testAccAWSLightsailKeyPairConfig_imported` - `key` is unused (unparam)
func testAccAWSLightsailKeyPairConfig_imported(lightsailName, key string) string {
                                                              ^
aws/resource_aws_main_route_table_association_test.go:73:2: `testAccCheckMainRouteTableAssociation` - `routeTableResource` is unused (unparam)
	routeTableResource string) resource.TestCheckFunc {
	^
```

Output from acceptance testing:

```
(TestAccAWSAPIGatewayBasePathMapping_|TestAccAWSAthenaDatabase_|TestAccAWSCloudTrail/Trail/enableLogging|TestAccAWSEcsCluster_CapacityProviders|TestAccAWSEcsTaskDefinition_|TestAccAWSInspectorResourceGroup_basic|TestAccAWSKinesisAnalyticsApplication_|TestAccAWSKinesisVideoStream_disappears|TestAccAWSLambdaFunction_DeadLetterConfigUpdated|TestAccAWSLambdaPermission_disappears|TestAccAWSLightsailKeyPair_publicKey|TestAccAWSMainRouteTableAssociation_basic)

--- PASS: TestAccAWSAPIGatewayBasePathMapping_BasePath_Empty (54.58s)
--- PASS: TestAccAWSAPIGatewayBasePathMapping_basic (55.48s)

--- PASS: TestAccAWSAthenaDatabase_basic (60.51s)
--- PASS: TestAccAWSAthenaDatabase_destroyFailsIfTablesExist (73.58s)
--- PASS: TestAccAWSAthenaDatabase_encryption (71.05s)
--- PASS: TestAccAWSAthenaDatabase_forceDestroyAlwaysSucceeds (65.41s)
--- PASS: TestAccAWSAthenaDatabase_nameCantHaveUppercase (1.46s)
--- PASS: TestAccAWSAthenaDatabase_nameStartsWithUnderscore (61.23s)

--- PASS: TestAccAWSCloudTrail/Trail/enableLogging (105.77s)

--- PASS: TestAccAWSEcsCluster_CapacityProviders (48.45s)
--- PASS: TestAccAWSEcsCluster_CapacityProvidersNoStrategy (53.69s)
--- PASS: TestAccAWSEcsCluster_CapacityProvidersUpdate (81.22s)

--- PASS: TestAccAWSEcsTaskDefinition_arrays (16.36s)
--- PASS: TestAccAWSEcsTaskDefinition_basic (26.60s)
--- PASS: TestAccAWSEcsTaskDefinition_changeVolumesForcesNewResource (26.89s)
--- PASS: TestAccAWSEcsTaskDefinition_constraint (16.28s)
--- PASS: TestAccAWSEcsTaskDefinition_ExecutionRole (16.69s)
--- PASS: TestAccAWSEcsTaskDefinition_Fargate (21.81s)
--- PASS: TestAccAWSEcsTaskDefinition_Inactive (25.92s)
--- PASS: TestAccAWSEcsTaskDefinition_inferenceAccelerator (14.07s)
--- PASS: TestAccAWSEcsTaskDefinition_ProxyConfiguration (26.41s)
--- PASS: TestAccAWSEcsTaskDefinition_Tags (45.91s)
--- PASS: TestAccAWSEcsTaskDefinition_withDockerVolume (16.00s)
--- PASS: TestAccAWSEcsTaskDefinition_withDockerVolumeMinimalConfig (16.27s)
--- PASS: TestAccAWSEcsTaskDefinition_withEcsService (91.23s)
--- PASS: TestAccAWSEcsTaskDefinition_withEFSVolume (27.55s)
--- PASS: TestAccAWSEcsTaskDefinition_withEFSVolumeMinimal (27.70s)
--- PASS: TestAccAWSEcsTaskDefinition_withIPCMode (16.69s)
--- PASS: TestAccAWSEcsTaskDefinition_withNetworkMode (16.85s)
--- PASS: TestAccAWSEcsTaskDefinition_withPidMode (18.24s)
--- PASS: TestAccAWSEcsTaskDefinition_withScratchVolume (15.69s)
--- PASS: TestAccAWSEcsTaskDefinition_withTaskRoleArn (16.75s)
--- PASS: TestAccAWSEcsTaskDefinition_withTaskScopedDockerVolume (16.38s)

--- PASS: TestAccAWSInspectorResourceGroup_basic (22.88s)

--- PASS: TestAccAWSKinesisAnalyticsApplication_addCloudwatchLoggingOptions (34.01s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_basic (18.73s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_inputsAdd (75.84s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_inputsKinesisFirehose (103.79s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_inputsKinesisStream (63.12s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_inputsUpdateKinesisStream (120.00s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_Outputs_Lambda_Add (50.36s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_Outputs_Lambda_Create (39.75s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_outputsAdd (75.76s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_outputsKinesisStream (62.71s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_outputsMultiple (66.35s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_outputsUpdateKinesisStream (123.03s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_referenceDataSource (38.35s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_referenceDataSourceUpdate (69.86s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_tags (49.91s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_update (28.74s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_updateCloudwatchLoggingOptions (46.64s)
--- PASS: TestAccAWSKinesisVideoStream_disappears (95.02s)

--- PASS: TestAccAWSLambdaFunction_DeadLetterConfigUpdated (76.72s)

--- PASS: TestAccAWSLambdaPermission_disappears (100.98s)

--- PASS: TestAccAWSLightsailKeyPair_publicKey (29.88s)

--- PASS: TestAccAWSMainRouteTableAssociation_basic (69.00s)
```

* resource/aws_instance: Remove redundant return

Previously:

```
aws/resource_aws_instance_migrate.go:108:2: S1023: redundant `return` statement (gosimple)
	return
	^
```
@ghost
Copy link

ghost commented Jun 19, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 19, 2020
@breathingdust breathingdust added the linter Pertains to changes to or issues with the various linters. label Oct 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gdavison gdavison gdavison approved these changes

Assignees

@gdavison gdavison

Labels
linter Pertains to changes to or issues with the various linters. service/apigateway Issues and PRs that pertain to the apigateway service. service/athena Issues and PRs that pertain to the athena service. service/cloudtrail Issues and PRs that pertain to the cloudtrail service. service/ec2 Issues and PRs that pertain to the ec2 service. service/ecs Issues and PRs that pertain to the ecs service. service/inspector Issues and PRs that pertain to the inspector service. service/kinesisanalytics Issues and PRs that pertain to the kinesisanalytics service. service/lambda Issues and PRs that pertain to the lambda service. service/lightsail Issues and PRs that pertain to the lightsail service. size/M Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.63.0
Development

Successfully merging this pull request may close these issues.
3 participants
@bflad @gdavison @breathingdust