Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new grpc, http2 port protocols for app mesh virtual router #12744

Closed
wants to merge 1 commit into from
Closed

Support new grpc, http2 port protocols for app mesh virtual router #12744

wants to merge 1 commit into from

Conversation

stijndehaes
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

Adds support for the http2 and grpc protocols in aws_appmesh_virtual_router

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@stijndehaes stijndehaes requested a review from a team April 9, 2020 09:11
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. service/appmesh Issues and PRs that pertain to the appmesh service. labels Apr 9, 2020
@ewbankkit
Copy link
Contributor

Related:

@stijndehaes
Copy link
Contributor Author

Testing seems to have failed with the same error on master, will rebase when that is fixed.

@ewbankkit
Copy link
Contributor

Submitted #12746 to fix that website error.

@ewbankkit
Copy link
Contributor

@stijndehaes Are you OK with me merging your changes into #11669?

@stijndehaes
Copy link
Contributor Author

@ewbankkit yes go ahead :)

@ewbankkit
Copy link
Contributor

@stijndehaes Thanks. I cherry picked your commit over and modified the acceptance tests to validate.
Could you please close this PR?

@stijndehaes stijndehaes deleted the feature/aws_appmesh_virtual_router/grpc branch April 17, 2020 05:31
@ghost
Copy link

ghost commented May 17, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators May 17, 2020
@breathingdust breathingdust removed the needs-triage Waiting for first response or review from a maintainer. label Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/appmesh Issues and PRs that pertain to the appmesh service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants