Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_lb_listener: Remove deprecated (helper/schema.ResourceData).Partial() and (helper/schema.ResourceData).SetPartial() #12468

Merged
merged 1 commit into from
Apr 1, 2020
Merged

resource/aws_lb_listener: Remove deprecated (helper/schema.ResourceData).Partial() and (helper/schema.ResourceData).SetPartial() #12468

merged 1 commit into from
Apr 1, 2020

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Mar 19, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Reference: #12083
Reference: #12087

Release note for CHANGELOG:

NONE

Previously:

aws/resource_aws_lb_listener_rule.go:1083:3: R008: deprecated (schema.ResourceData).SetPartial
aws/resource_aws_lb_listener_rule.go:1093:3: R008: deprecated (schema.ResourceData).SetPartial
aws/resource_aws_lb_listener_rule.go:1107:2: R007: deprecated (schema.ResourceData).Partial
aws/resource_aws_lb_listener_rule.go:931:2: R007: deprecated (schema.ResourceData).Partial
aws/resource_aws_lb_listener_rule.go:948:3: R008: deprecated (schema.ResourceData).SetPartial

Output from acceptance testing:

--- PASS: TestAccAWSLBListenerRule_Action_Order (192.70s)
--- PASS: TestAccAWSLBListenerRule_Action_Order_Recreates (223.40s)
--- PASS: TestAccAWSLBListenerRule_basic (267.91s)
--- PASS: TestAccAWSLBListenerRule_changeListenerRuleArnForcesNew (216.77s)
--- PASS: TestAccAWSLBListenerRule_cognito (211.46s)
--- PASS: TestAccAWSLBListenerRule_conditionAttributesCount (29.28s)
--- PASS: TestAccAWSLBListenerRule_conditionHostHeader (191.30s)
--- PASS: TestAccAWSLBListenerRule_conditionHostHeader_deprecated (190.31s)
--- PASS: TestAccAWSLBListenerRule_conditionHttpHeader (181.36s)
--- PASS: TestAccAWSLBListenerRule_conditionHttpHeader_invalid (2.67s)
--- PASS: TestAccAWSLBListenerRule_conditionHttpRequestMethod (180.78s)
--- PASS: TestAccAWSLBListenerRule_conditionMultiple (219.93s)
--- PASS: TestAccAWSLBListenerRule_conditionPathPattern (221.77s)
--- PASS: TestAccAWSLBListenerRule_conditionPathPattern_deprecated (220.00s)
--- PASS: TestAccAWSLBListenerRule_conditionQueryString (191.65s)
--- PASS: TestAccAWSLBListenerRule_conditionSourceIp (275.03s)
--- PASS: TestAccAWSLBListenerRule_conditionUpdateMixed (284.65s)
--- PASS: TestAccAWSLBListenerRule_conditionUpdateMultiple (258.87s)
--- PASS: TestAccAWSLBListenerRule_conditionUpdatePathPattern_deprecated (355.25s)
--- PASS: TestAccAWSLBListenerRule_fixedResponse (217.28s)
--- PASS: TestAccAWSLBListenerRule_multipleConditionThrowsError (2.66s)
--- PASS: TestAccAWSLBListenerRule_oidc (188.46s)
--- PASS: TestAccAWSLBListenerRule_priority (406.08s)
--- PASS: TestAccAWSLBListenerRule_redirect (189.54s)
--- PASS: TestAccAWSLBListenerRule_updateFixedResponse (222.80s)
--- PASS: TestAccAWSLBListenerRule_updateRulePriority (225.24s)

@bflad
resource/aws_lb_listener: Remove deprecated (helper/schema.ResourceDa…
59f7a59 
…ta).Partial() and (helper/schema.ResourceData).SetPartial()

Reference: #12083
Reference: #12087

Previously:

```
aws/resource_aws_lb_listener_rule.go:1083:3: R008: deprecated (schema.ResourceData).SetPartial
aws/resource_aws_lb_listener_rule.go:1093:3: R008: deprecated (schema.ResourceData).SetPartial
aws/resource_aws_lb_listener_rule.go:1107:2: R007: deprecated (schema.ResourceData).Partial
aws/resource_aws_lb_listener_rule.go:931:2: R007: deprecated (schema.ResourceData).Partial
aws/resource_aws_lb_listener_rule.go:948:3: R008: deprecated (schema.ResourceData).SetPartial
```

Output from acceptance testing:

```
--- PASS: TestAccAWSLBListenerRule_Action_Order (192.70s)
--- PASS: TestAccAWSLBListenerRule_Action_Order_Recreates (223.40s)
--- PASS: TestAccAWSLBListenerRule_basic (267.91s)
--- PASS: TestAccAWSLBListenerRule_changeListenerRuleArnForcesNew (216.77s)
--- PASS: TestAccAWSLBListenerRule_cognito (211.46s)
--- PASS: TestAccAWSLBListenerRule_conditionAttributesCount (29.28s)
--- PASS: TestAccAWSLBListenerRule_conditionHostHeader (191.30s)
--- PASS: TestAccAWSLBListenerRule_conditionHostHeader_deprecated (190.31s)
--- PASS: TestAccAWSLBListenerRule_conditionHttpHeader (181.36s)
--- PASS: TestAccAWSLBListenerRule_conditionHttpHeader_invalid (2.67s)
--- PASS: TestAccAWSLBListenerRule_conditionHttpRequestMethod (180.78s)
--- PASS: TestAccAWSLBListenerRule_conditionMultiple (219.93s)
--- PASS: TestAccAWSLBListenerRule_conditionPathPattern (221.77s)
--- PASS: TestAccAWSLBListenerRule_conditionPathPattern_deprecated (220.00s)
--- PASS: TestAccAWSLBListenerRule_conditionQueryString (191.65s)
--- PASS: TestAccAWSLBListenerRule_conditionSourceIp (275.03s)
--- PASS: TestAccAWSLBListenerRule_conditionUpdateMixed (284.65s)
--- PASS: TestAccAWSLBListenerRule_conditionUpdateMultiple (258.87s)
--- PASS: TestAccAWSLBListenerRule_conditionUpdatePathPattern_deprecated (355.25s)
--- PASS: TestAccAWSLBListenerRule_fixedResponse (217.28s)
--- PASS: TestAccAWSLBListenerRule_multipleConditionThrowsError (2.66s)
--- PASS: TestAccAWSLBListenerRule_oidc (188.46s)
--- PASS: TestAccAWSLBListenerRule_priority (406.08s)
--- PASS: TestAccAWSLBListenerRule_redirect (189.54s)
--- PASS: TestAccAWSLBListenerRule_updateFixedResponse (222.80s)
--- PASS: TestAccAWSLBListenerRule_updateRulePriority (225.24s)
```
@bflad bflad added the technical-debt Addresses areas of the codebase that need refactoring or redesign. label Mar 19, 2020
@bflad bflad requested a review from a team March 19, 2020 08:26
@ghost ghost added needs-triage Waiting for first response or review from a maintainer. size/XS Managed by automation to categorize the size of a PR. service/elbv2 Issues and PRs that pertain to the elbv2 service. labels Mar 19, 2020
@bflad bflad removed the needs-triage Waiting for first response or review from a maintainer. label Mar 19, 2020
gdavison
gdavison approved these changes Mar 31, 2020
View reviewed changes
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

--- PASS: TestLBListenerARNFromRuleARN (0.00s)
--- PASS: TestAccAWSLBListenerRule_multipleConditionThrowsError (2.66s)
--- PASS: TestAccAWSLBListenerRule_conditionHttpHeader_invalid (3.26s)
--- PASS: TestAccAWSLBListenerRule_conditionAttributesCount (31.37s)
--- PASS: TestAccAWSLBListenerRule_conditionHttpHeader (162.21s)
--- PASS: TestAccAWSLBListenerRule_conditionHttpRequestMethod (166.90s)
--- PASS: TestAccAWSLBListenerRule_updateRulePriority (172.07s)
--- PASS: TestAccAWSLBListenerRule_basic (181.74s)
--- PASS: TestAccAWSLBListenerRule_Action_Order_Recreates (182.11s)
--- PASS: TestAccAWSLBListenerRule_Action_Order (188.15s)
--- PASS: TestAccAWSLBListenerRule_oidc (198.37s)
--- PASS: TestAccAWSLBListenerRule_cognito (201.41s)
--- PASS: TestAccAWSLBListenerRule_redirect (202.03s)
--- PASS: TestAccAWSLBListenerRule_conditionQueryString (176.56s)
--- PASS: TestAccAWSLBListenerRule_changeListenerRuleArnForcesNew (209.81s)
--- PASS: TestAccAWSLBListenerRule_fixedResponse (209.97s)
--- PASS: TestAccAWSLBListenerRule_conditionPathPattern_deprecated (213.94s)
--- PASS: TestAccAWSLBListenerRuleBackwardsCompatibility (217.36s)
--- PASS: TestAccAWSLBListenerRule_conditionUpdatePathPattern_deprecated (221.75s)
--- PASS: TestAccAWSLBListenerRule_updateFixedResponse (229.02s)
--- PASS: TestAccAWSLBListenerRule_conditionHostHeader (236.12s)
--- PASS: TestAccAWSLBListenerRule_conditionHostHeader_deprecated (251.22s)
--- PASS: TestAccAWSLBListenerRule_priority (265.94s)
--- PASS: TestAccAWSLBListenerRule_conditionPathPattern (299.79s)
--- PASS: TestAccAWSLBListenerRule_conditionSourceIp (165.77s)
--- PASS: TestAccAWSLBListenerRule_conditionMultiple (180.22s)
--- PASS: TestAccAWSLBListenerRule_conditionUpdateMixed (199.39s)
--- PASS: TestAccAWSLBListenerRule_conditionUpdateMultiple (206.61s)

@bflad bflad added this to the v2.56.0 milestone Apr 1, 2020
@bflad bflad merged commit 4094649 into master Apr 1, 2020
@bflad bflad deleted the td-remove-partial-aws_lb_listener_rule branch April 1, 2020 00:16
@ghost
Copy link

ghost commented Apr 3, 2020

This has been released in version 2.56.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented May 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators May 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gdavison gdavison gdavison approved these changes

Assignees
No one assigned
Labels
service/elbv2 Issues and PRs that pertain to the elbv2 service. size/XS Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Projects
None yet
Milestone
v2.56.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bflad @gdavison