service/docdb: Remove deprecated (helper/schema.ResourceData).Partial() and (helper/schema.ResourceData).SetPartial() #12457
Conversation
…() and (helper/schema.ResourceData).SetPartial() Reference: #12083 Reference: #12087 Previously: ``` aws/resource_aws_docdb_cluster.go:620:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_docdb_cluster.go:626:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_docdb_cluster.go:672:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_docdb_cluster_instance.go:345:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_docdb_cluster_instance.go:351:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_docdb_cluster_instance.go:357:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_docdb_cluster_instance.go:363:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_docdb_cluster_instance.go:413:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_docdb_cluster_parameter_group.go:185:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_docdb_cluster_parameter_group.go:230:4: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_docdb_cluster_parameter_group.go:241:3: R008: deprecated (schema.ResourceData).SetPartial aws/resource_aws_docdb_cluster_parameter_group.go:244:2: R007: deprecated (schema.ResourceData).Partial aws/resource_aws_docdb_subnet_group.go:179:3: R008: deprecated (schema.ResourceData).SetPartial ``` Output from acceptance testing: ``` --- PASS: TestAccAWSDocDBCluster_backupsUpdate (260.19s) --- PASS: TestAccAWSDocDBCluster_basic (130.28s) --- PASS: TestAccAWSDocDBCluster_encrypted (203.87s) --- PASS: TestAccAWSDocDBCluster_generatedName (130.17s) --- PASS: TestAccAWSDocDBCluster_kmsKey (233.75s) --- PASS: TestAccAWSDocDBCluster_missingUserNameCausesError (4.93s) --- PASS: TestAccAWSDocDBCluster_namePrefix (129.97s) --- PASS: TestAccAWSDocDBCluster_Port (369.93s) --- PASS: TestAccAWSDocDBCluster_takeFinalSnapshot (252.47s) --- PASS: TestAccAWSDocDBCluster_updateCloudwatchLogsExports (227.06s) --- PASS: TestAccAWSDocDBCluster_updateTags (235.10s) --- PASS: TestAccAWSDocDBClusterInstance_az (714.97s) --- PASS: TestAccAWSDocDBClusterInstance_basic (1416.43s) --- PASS: TestAccAWSDocDBClusterInstance_disappears (748.64s) --- PASS: TestAccAWSDocDBClusterInstance_generatedName (753.18s) --- PASS: TestAccAWSDocDBClusterInstance_kmsKey (821.87s) --- PASS: TestAccAWSDocDBClusterInstance_namePrefix (764.04s) --- PASS: TestAccAWSDocDBClusterParameterGroup_basic (43.89s) --- PASS: TestAccAWSDocDBClusterParameterGroup_Description (31.42s) --- PASS: TestAccAWSDocDBClusterParameterGroup_disappears (13.72s) --- PASS: TestAccAWSDocDBClusterParameterGroup_generatedName (27.74s) --- PASS: TestAccAWSDocDBClusterParameterGroup_namePrefix (48.18s) --- PASS: TestAccAWSDocDBClusterParameterGroup_Parameter (50.36s) --- PASS: TestAccAWSDocDBClusterParameterGroup_Tags (65.89s) --- PASS: TestAccAWSDocDBSubnetGroup_basic (57.22s) --- PASS: TestAccAWSDocDBSubnetGroup_disappears (31.33s) --- PASS: TestAccAWSDocDBSubnetGroup_generatedName (44.49s) --- PASS: TestAccAWSDocDBSubnetGroup_namePrefix (46.41s) --- PASS: TestAccAWSDocDBSubnetGroup_updateDescription (67.20s) ```
bflad
added
the
technical-debt
ghost
added
needs-triage
bflad
removed
the
needs-triage
There was a problem hiding this comment.
LGTM 🚀
--- PASS: TestAccAWSDocDBCluster_missingUserNameCausesError (6.79s)
--- PASS: TestAccAWSDocDBClusterParameterGroup_disappears (10.01s)
--- PASS: TestAccAWSDocDBClusterParameterGroup_basic (10.66s)
--- PASS: TestAccAWSDocDBClusterParameterGroup_namePrefix (10.70s)
--- PASS: TestAccAWSDocDBClusterParameterGroup_Description (11.86s)
--- PASS: TestAccAWSDocDBClusterParameterGroup_generatedName (11.88s)
--- PASS: TestAccAWSDocDBClusterParameterGroup_Parameter (21.67s)
--- PASS: TestAccAWSDocDBSubnetGroup_disappears (11.71s)
--- PASS: TestAccAWSDocDBSubnetGroup_basic (13.46s)
--- PASS: TestAccAWSDocDBClusterParameterGroup_Tags (25.91s)
--- PASS: TestAccAWSDocDBSubnetGroup_namePrefix (10.89s)
--- PASS: TestAccAWSDocDBSubnetGroup_generatedName (11.18s)
--- PASS: TestAccAWSDocDBSubnetGroup_updateDescription (17.82s)
--- PASS: TestAccAWSDocDBCluster_generatedName (133.46s)
--- PASS: TestAccAWSDocDBCluster_basic (133.58s)
--- PASS: TestAccAWSDocDBCluster_namePrefix (152.89s)
--- PASS: TestAccAWSDocDBCluster_kmsKey (148.98s)
--- PASS: TestAccAWSDocDBCluster_encrypted (149.97s)
--- PASS: TestAccAWSDocDBCluster_takeFinalSnapshot (193.73s)
--- PASS: TestAccAWSDocDBCluster_backupsUpdate (185.32s)
--- PASS: TestAccAWSDocDBCluster_updateCloudwatchLogsExports (199.17s)
--- PASS: TestAccAWSDocDBCluster_updateTags (238.93s)
--- PASS: TestAccAWSDocDBCluster_Port (270.75s)
--- PASS: TestAccAWSDocDBClusterInstance_az (639.82s)
--- PASS: TestAccAWSDocDBClusterInstance_namePrefix (702.84s)
--- PASS: TestAccAWSDocDBClusterInstance_disappears (704.13s)
--- PASS: TestAccAWSDocDBClusterInstance_generatedName (735.71s)
--- PASS: TestAccAWSDocDBClusterInstance_kmsKey (740.12s)
--- PASS: TestAccAWSDocDBClusterInstance_basic (1373.85s)
There was a problem hiding this comment.
LGTM 🚀
--- PASS: TestResourceAWSRedshiftClusterIdentifierValidation (0.00s)
--- PASS: TestResourceAWSRedshiftClusterFinalSnapshotIdentifierValidation (0.00s)
--- PASS: TestValidateRedshiftClusterDbName (0.00s)
--- PASS: TestResourceAWSRedshiftClusterMasterPasswordValidation (0.00s)
--- PASS: TestResourceAWSRedshiftClusterMasterUsernameValidation (0.00s)
--- PASS: TestAccAWSRedshiftEventSubscription_withPrefix (11.21s)
--- PASS: TestAccAWSRedshiftEventSubscription_basicUpdate (20.19s)
--- PASS: TestAccAWSRedshiftEventSubscription_withSourceIds (21.90s)
--- PASS: TestAccAWSRedshiftEventSubscription_categoryUpdate (27.42s)
--- PASS: TestAccAWSRedshiftParameterGroup_withParameters (27.73s)
--- PASS: TestResourceAWSRedshiftParameterGroupNameValidation (0.00s)
--- PASS: TestAccAWSRedshiftParameterGroup_withoutParameters (30.85s)
--- PASS: TestAccAWSRedshiftSnapshotCopyGrant_Basic (10.89s)
--- PASS: TestAccAWSRedshiftEventSubscription_tagsUpdate (69.39s)
--- PASS: TestAccAWSRedshiftSnapshotSchedule_basic (20.69s)
--- PASS: TestAccAWSRedshiftSnapshotCopyGrant_Update (33.21s)
--- PASS: TestAccAWSRedshiftSnapshotSchedule_withDescription (7.65s)
--- PASS: TestAccAWSRedshiftParameterGroup_withTags (75.77s)
--- PASS: TestAccAWSRedshiftSnapshotSchedule_withIdentifierPrefix (30.02s)
--- PASS: TestAccAWSRedshiftSnapshotSchedule_withTags (19.57s)
--- PASS: TestAccAWSRedshiftParameterGroup_basic (109.89s)
--- PASS: TestAccAWSRedshiftSubnetGroup_basic (12.61s)
--- PASS: TestAccAWSRedshiftSubnetGroup_updateDescription (20.78s)
--- PASS: TestResourceAWSRedshiftSubnetGroupNameValidation (0.00s)
--- PASS: TestAccAWSRedshiftSubnetGroup_updateSubnetIds (23.39s)
--- PASS: TestAccAWSRedshiftSubnetGroup_tags (23.83s)
--- PASS: TestAccAWSRedshiftSnapshotSchedule_withMultipleDefinition (121.06s)
--- PASS: TestAccAWSRedshiftCluster_basic (435.02s)
--- PASS: TestAccAWSRedshiftCluster_changeAvailabilityZone (753.52s)
--- PASS: TestAccAWSRedshiftCluster_snapshotCopy (775.61s)
--- PASS: TestAccAWSRedshiftCluster_kmsKey (813.20s)
--- FAIL: TestAccAWSRedshiftCluster_iamRoles (935.44s)
--- PASS: TestAccAWSRedshiftCluster_publiclyAccessible (944.28s)
--- PASS: TestAccAWSRedshiftCluster_tags (977.54s)
--- PASS: TestAccAWSRedshiftCluster_enhancedVpcRoutingEnabled (1017.02s)
--- PASS: TestAccAWSRedshiftCluster_withFinalSnapshot (1117.88s)
--- PASS: TestAccAWSRedshiftCluster_loggingEnabled (1563.38s)
--- PASS: TestAccAWSRedshiftCluster_updateNodeType (1782.64s)
--- PASS: TestAccAWSRedshiftCluster_changeEncryption1 (2084.85s)
--- FAIL: TestAccAWSRedshiftSnapshotSchedule_withForceDestroy (2098.00s)
--- PASS: TestAccAWSRedshiftCluster_forceNewUsername (2483.93s)
--- PASS: TestAccAWSRedshiftCluster_changeEncryption2 (2544.69s)
--- FAIL: TestAccAWSRedshiftCluster_updateNodeCount (3608.34s)
Test failures are not related to this change:
TestAccAWSRedshiftCluster_iamRolesTestAccAWSRedshiftSnapshotSchedule_withForceDestroyTestAccAWSRedshiftCluster_updateNodeCount
|
This has been released in version 2.56.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Community Note
Reference: #12083
Reference: #12087
Release note for CHANGELOG:
Previously:
Output from acceptance testing: