resource_aws_s3_bucket.go: retry NoSuchBucket when updating tags for s3 bucket #12418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
size/XS
…s3 bucket
The original retry was added in [1] but, in later refactor the retry was dropped [2]
the causes failures like
```
level=error msg="Error: error updating S3 Bucket (terraform-20200316104552904700000001) tags: error listing resource tags (terraform-20200316104552904700000001): NoSuchBucket: The specified bucket does not exist"
level=error msg="\tstatus code: 404, request id: <REDACTED>, host id: <REDACTED>"
level=error
level=error msg=" on ../tmp/openshift-install-019032273/bootstrap/main.tf line 7, in resource \"aws_s3_bucket\" \"ignition\":"
level=error msg=" 7: resource \"aws_s3_bucket\" \"ignition\" {"
level=error
level=error
```
debug error:
```
time="2020-03-16T10:45:53Z" level=debug msg="2020-03-16T10:45:53.413Z [DEBUG] plugin.terraform-provider-aws: [DEBUG] [aws-sdk-go] DEBUG: Validate Response s3/GetBucketTagging failed, attempt 0/25, error NoSuchBucket: The specified bucket does not exist"
time="2020-03-16T10:45:53Z" level=debug msg="2020-03-16T10:45:53.413Z [DEBUG] plugin.terraform-provider-aws: \tstatus code: 404, request id: <REDACTED>, host id: <REDACTED>"
time="2020-03-16T10:45:53Z" level=debug msg="[DEBUG] module.bootstrap.aws_s3_bucket.ignition: apply errored, but we're indicating that via the Error pointer rather than returning it: error updating S3 Bucket (terraform-20200316104552904700000001) tags: error listing resource tags (terraform-20200316104552904700000001): NoSuchBucket: The specified bucket does not exist"
```
[1]: hashicorp#10863
[2]: hashicorp#11916
abhinavdahiya
force-pushed
the
s3_no_bucket_tagging
branch
from
fb45ac2 to
b51938a
Compare
bflad
added
bug
bflad
approved these changes
Mar 17, 2020
There was a problem hiding this comment.
Thank you for fixing this, @abhinavdahiya 🚀
Output from acceptance testing (failures unrelated):
--- FAIL: TestAccAWSS3Bucket_acceleration (10.31s)
--- FAIL: TestAccAWSS3Bucket_LifecycleBasic (22.92s)
--- PASS: TestAccAWSS3Bucket_AclToGrant (24.74s)
--- PASS: TestAccAWSS3Bucket_basic (15.90s)
--- PASS: TestAccAWSS3Bucket_Bucket_EmptyString (15.78s)
--- PASS: TestAccAWSS3Bucket_Cors_Delete (13.81s)
--- PASS: TestAccAWSS3Bucket_Cors_EmptyOrigin (15.40s)
--- PASS: TestAccAWSS3Bucket_Cors_Update (25.35s)
--- PASS: TestAccAWSS3Bucket_disableDefaultEncryption_whenDefaultEncryptionIsEnabled (25.34s)
--- PASS: TestAccAWSS3Bucket_enableDefaultEncryption_whenAES256IsUsed (16.30s)
--- PASS: TestAccAWSS3Bucket_enableDefaultEncryption_whenTypical (34.44s)
--- PASS: TestAccAWSS3Bucket_forceDestroy (11.94s)
--- PASS: TestAccAWSS3Bucket_forceDestroyWithEmptyPrefixes (11.09s)
--- PASS: TestAccAWSS3Bucket_forceDestroyWithObjectLockEnabled (12.85s)
--- PASS: TestAccAWSS3Bucket_generatedName (16.61s)
--- PASS: TestAccAWSS3Bucket_GrantToAcl (25.53s)
--- PASS: TestAccAWSS3Bucket_LifecycleExpireMarkerOnly (21.66s)
--- PASS: TestAccAWSS3Bucket_Logging (18.80s)
--- PASS: TestAccAWSS3Bucket_namePrefix (15.44s)
--- PASS: TestAccAWSS3Bucket_objectLock (19.55s)
--- PASS: TestAccAWSS3Bucket_Policy (35.15s)
--- PASS: TestAccAWSS3Bucket_region (14.15s)
--- PASS: TestAccAWSS3Bucket_Replication (130.64s)
--- PASS: TestAccAWSS3Bucket_ReplicationConfiguration_Rule_Destination_AccessControlTranslation (87.14s)
--- PASS: TestAccAWSS3Bucket_ReplicationExpectVersioningValidationError (26.74s)
--- PASS: TestAccAWSS3Bucket_ReplicationSchemaV2 (108.61s)
--- PASS: TestAccAWSS3Bucket_ReplicationWithoutPrefix (40.18s)
--- PASS: TestAccAWSS3Bucket_ReplicationWithoutStorageClass (41.80s)
--- PASS: TestAccAWSS3Bucket_RequestPayer (26.72s)
--- PASS: TestAccAWSS3Bucket_shouldFailNotFound (10.49s)
--- PASS: TestAccAWSS3Bucket_tagsWithNoSystemTags (45.69s)
--- PASS: TestAccAWSS3Bucket_tagsWithSystemTags (80.96s)
--- PASS: TestAccAWSS3Bucket_UpdateAcl (23.42s)
--- PASS: TestAccAWSS3Bucket_UpdateGrant (34.79s)
--- PASS: TestAccAWSS3Bucket_Versioning (31.30s)
--- PASS: TestAccAWSS3Bucket_Website_Simple (32.40s)
--- PASS: TestAccAWSS3Bucket_WebsiteRedirect (32.73s)
--- PASS: TestAccAWSS3Bucket_WebsiteRoutingRules (25.14s)
--- PASS: TestAccAWSS3MultiBucket_withTags (17.79s)
|
This has been released in version 2.54.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Release note for CHANGELOG:
Output from acceptance testing:
The original retry was added in pr-108836 but, in later refactor the retry was dropped pr-11916
the causes failures like
debug error: