Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider: Fix and enable tfproviderlint V002, V004, V007, and V008 #12233

Merged
merged 2 commits into from
Mar 10, 2020
Merged

provider: Fix and enable tfproviderlint V002, V004, V007, and V008 #12233

merged 2 commits into from
Mar 10, 2020

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Mar 3, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Reference: #11844
Reference: #12087

Release note for CHANGELOG:

NONE

Previously:

aws/resource_aws_codepipeline_webhook.go:54:22: V002: deprecated validation.CIDRNetwork should be replaced with validation.IsCIDRNetwork
aws/resource_aws_vpc.go:37:19: V002: deprecated validation.CIDRNetwork should be replaced with validation.IsCIDRNetwork
aws/resource_aws_vpc_ipv4_cidr_block_association.go:39:19: V002: deprecated validation.CIDRNetwork should be replaced with validation.IsCIDRNetwork

aws/resource_aws_route53_resolver_endpoint.go:58:22: V004: deprecated validation.SingleIP should be replaced with validation.IsIPAddress
aws/resource_aws_route53_resolver_rule.go:79:22: V004: deprecated validation.SingleIP should be replaced with validation.IsIPAddress

aws/data_source_aws_ami.go:35:19: V007: deprecated validation.ValidateRegexp should be replaced with validation.StringIsValidRegExp
aws/data_source_aws_ami_ids.go:33:19: V007: deprecated validation.ValidateRegexp should be replaced with validation.StringIsValidRegExp
aws/data_source_aws_elastic_beanstalk_solution_stack.go:22:19: V007: deprecated validation.ValidateRegexp should be replaced with validation.StringIsValidRegExp

aws/resource_aws_appsync_api_key.go:46:19: V008: deprecated validation.ValidateRFC3339TimeString should be replaced with validation.IsRFC3339Time
aws/resource_aws_ec2_capacity_reservation.go:45:19: V008: deprecated validation.ValidateRFC3339TimeString should be replaced with validation.IsRFC3339Time
aws/resource_aws_kms_external_key.go:86:19: V008: deprecated validation.ValidateRFC3339TimeString should be replaced with validation.IsRFC3339Time
aws/resource_aws_lambda_event_source_mapping.go:62:19: V008: deprecated validation.ValidateRFC3339TimeString should be replaced with validation.IsRFC3339Time
aws/resource_aws_launch_template.go:320:25: V008: deprecated validation.ValidateRFC3339TimeString should be replaced with validation.IsRFC3339Time
aws/resource_aws_s3_bucket_object.go:193:19: V008: deprecated validation.ValidateRFC3339TimeString should be replaced with validation.IsRFC3339Time
aws/resource_aws_spot_fleet_request.go:343:19: V008: deprecated validation.ValidateRFC3339TimeString should be replaced with validation.IsRFC3339Time
aws/resource_aws_spot_fleet_request.go:349:19: V008: deprecated validation.ValidateRFC3339TimeString should be replaced with validation.IsRFC3339Time
aws/resource_aws_spot_instance_request.go:104:19: V008: deprecated validation.ValidateRFC3339TimeString should be replaced with validation.IsRFC3339Time
aws/resource_aws_spot_instance_request.go:97:19: V008: deprecated validation.ValidateRFC3339TimeString should be replaced with validation.IsRFC3339Time
aws/resource_aws_ssm_activation.go:42:19: V008: deprecated validation.ValidateRFC3339TimeString should be replaced with validation.IsRFC3339Time

Output from acceptance testing:

--- PASS: TestAccAWSAmiDataSource_instanceStore (14.77s)
--- PASS: TestAccAWSAmiDataSource_localNameFilter (18.63s)
--- PASS: TestAccAWSAmiDataSource_natInstance (15.86s)
--- PASS: TestAccAWSAmiDataSource_windowsInstance (17.85s)

--- PASS: TestAccDataSourceAwsAmiIds_basic (15.83s)
--- PASS: TestAccDataSourceAwsAmiIds_sorted (31.07s)

--- PASS: TestAccAWSElasticBeanstalkSolutionStackDataSource (13.74s)

--- PASS: TestAccAWSAppsyncApiKey_basic (19.11s)
--- PASS: TestAccAWSAppsyncApiKey_Description (26.75s)
--- PASS: TestAccAWSAppsyncApiKey_Expires (26.03s)

--- PASS: TestAccAWSCodePipelineWebhook_basic (45.87s)
--- PASS: TestAccAWSCodePipelineWebhook_ipAuth (44.09s)
--- PASS: TestAccAWSCodePipelineWebhook_tags (92.65s)
--- PASS: TestAccAWSCodePipelineWebhook_unauthenticated (45.40s)
--- PASS: TestAccAWSCodePipelineWebhook_UpdateAuthenticationConfiguration_SecretToken (63.24s)

--- PASS: TestAccAWSEc2CapacityReservation_basic (19.18s)
--- PASS: TestAccAWSEc2CapacityReservation_ebsOptimized (18.24s)
--- PASS: TestAccAWSEc2CapacityReservation_endDate (30.99s)
--- PASS: TestAccAWSEc2CapacityReservation_endDateType (44.58s)
--- PASS: TestAccAWSEc2CapacityReservation_ephemeralStorage (18.73s)
--- PASS: TestAccAWSEc2CapacityReservation_instanceCount (32.83s)
--- PASS: TestAccAWSEc2CapacityReservation_instanceMatchCriteria (18.71s)
--- PASS: TestAccAWSEc2CapacityReservation_instanceType (32.72s)
--- PASS: TestAccAWSEc2CapacityReservation_tags (45.51s)

--- PASS: TestAccAWSKmsExternalKey_basic (41.14s)
--- PASS: TestAccAWSKmsExternalKey_DeletionWindowInDays (52.45s)
--- PASS: TestAccAWSKmsExternalKey_Description (52.48s)
--- PASS: TestAccAWSKmsExternalKey_disappears (33.53s)
--- PASS: TestAccAWSKmsExternalKey_Enabled (308.60s)
--- PASS: TestAccAWSKmsExternalKey_KeyMaterialBase64 (145.65s)
--- PASS: TestAccAWSKmsExternalKey_Policy (53.09s)
--- PASS: TestAccAWSKmsExternalKey_Tags (65.26s)
--- PASS: TestAccAWSKmsExternalKey_ValidTo (191.46s)

--- PASS: TestAccAWSLambdaEventSourceMapping_BatchWindow (85.38s)
--- PASS: TestAccAWSLambdaEventSourceMapping_BisectBatch (83.25s)
--- PASS: TestAccAWSLambdaEventSourceMapping_changesInEnabledAreDetected (86.33s)
--- PASS: TestAccAWSLambdaEventSourceMapping_kinesis_basic (84.71s)
--- PASS: TestAccAWSLambdaEventSourceMapping_kinesis_disappears (70.37s)
--- PASS: TestAccAWSLambdaEventSourceMapping_kinesis_removeBatchSize (84.85s)
--- PASS: TestAccAWSLambdaEventSourceMapping_KinesisDestinationConfig (87.03s)
--- PASS: TestAccAWSLambdaEventSourceMapping_MaximumRecordAgeInSeconds (83.44s)
--- PASS: TestAccAWSLambdaEventSourceMapping_MaximumRetryAttempts (83.57s)
--- PASS: TestAccAWSLambdaEventSourceMapping_ParallelizationFactor (84.20s)
--- PASS: TestAccAWSLambdaEventSourceMapping_sqs_basic (91.05s)
--- PASS: TestAccAWSLambdaEventSourceMapping_sqs_withFunctionName (38.73s)
--- PASS: TestAccAWSLambdaEventSourceMapping_sqsDisappears (132.14s)
--- PASS: TestAccAWSLambdaEventSourceMapping_StartingPositionTimestamp (70.89s)

--- PASS: TestAccAWSLaunchTemplate_associatePublicIPAddress (81.29s)
--- PASS: TestAccAWSLaunchTemplate_basic (16.75s)
--- PASS: TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS (41.98s)
--- PASS: TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS_DeleteOnTermination (48.44s)
--- PASS: TestAccAWSLaunchTemplate_capacityReservation_preference (19.58s)
--- PASS: TestAccAWSLaunchTemplate_capacityReservation_target (20.22s)
--- PASS: TestAccAWSLaunchTemplate_cpuOptions (16.28s)
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_nonBurstable (16.50s)
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_t2 (19.34s)
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_t3 (17.09s)
--- PASS: TestAccAWSLaunchTemplate_data (17.93s)
--- PASS: TestAccAWSLaunchTemplate_description (31.55s)
--- PASS: TestAccAWSLaunchTemplate_disappears (12.52s)
--- PASS: TestAccAWSLaunchTemplate_EbsOptimized (61.86s)
--- PASS: TestAccAWSLaunchTemplate_ElasticInferenceAccelerator (30.31s)
--- PASS: TestAccAWSLaunchTemplate_IamInstanceProfile_EmptyConfigurationBlock (14.70s)
--- PASS: TestAccAWSLaunchTemplate_instanceMarketOptions (50.72s)
--- PASS: TestAccAWSLaunchTemplate_licenseSpecification (21.67s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface (36.47s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface_ipv6AddressCount (16.76s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface_ipv6Addresses (17.95s)
--- PASS: TestAccAWSLaunchTemplate_tags (34.53s)
--- PASS: TestAccAWSLaunchTemplate_update (79.77s)

--- PASS: TestAccAwsRoute53ResolverEndpoint_basicInbound (97.11s)
--- PASS: TestAccAwsRoute53ResolverEndpoint_updateOutbound (394.08s)

--- PASS: TestAccAwsRoute53ResolverRule_basic (41.82s)
--- PASS: TestAccAwsRoute53ResolverRule_forward (297.20s)
--- PASS: TestAccAwsRoute53ResolverRule_forwardEndpointRecreate (430.76s)
--- PASS: TestAccAwsRoute53ResolverRule_tags (69.62s)
--- PASS: TestAccAwsRoute53ResolverRule_updateName (67.71s)

--- PASS: TestAccAWSS3BucketObject_acl (76.63s)
--- PASS: TestAccAWSS3BucketObject_content (35.37s)
--- PASS: TestAccAWSS3BucketObject_contentBase64 (36.20s)
--- PASS: TestAccAWSS3BucketObject_empty (32.32s)
--- PASS: TestAccAWSS3BucketObject_etagEncryption (34.91s)
--- PASS: TestAccAWSS3BucketObject_kms (56.13s)
--- PASS: TestAccAWSS3BucketObject_metadata (74.02s)
--- PASS: TestAccAWSS3BucketObject_noNameNoKey (1.31s)
--- PASS: TestAccAWSS3BucketObject_ObjectLockLegalHoldStartWithNone (77.38s)
--- PASS: TestAccAWSS3BucketObject_ObjectLockLegalHoldStartWithOn (58.46s)
--- PASS: TestAccAWSS3BucketObject_ObjectLockRetentionStartWithNone (79.33s)
--- PASS: TestAccAWSS3BucketObject_ObjectLockRetentionStartWithSet (99.87s)
--- PASS: TestAccAWSS3BucketObject_source (31.86s)
--- PASS: TestAccAWSS3BucketObject_sse (34.55s)
--- PASS: TestAccAWSS3BucketObject_storageClass (116.76s)
--- PASS: TestAccAWSS3BucketObject_tags (101.60s)
--- PASS: TestAccAWSS3BucketObject_tagsLeadingSlash (99.58s)
--- PASS: TestAccAWSS3BucketObject_updates (55.60s)
--- PASS: TestAccAWSS3BucketObject_updateSameFile (57.91s)
--- PASS: TestAccAWSS3BucketObject_updatesWithVersioning (54.93s)
--- PASS: TestAccAWSS3BucketObject_updatesWithVersioningViaAccessPoint (63.40s)
--- PASS: TestAccAWSS3BucketObject_withContentCharacteristics (38.99s)

--- PASS: TestAccAWSSpotFleetRequest_associatePublicIpAddress (285.86s)
--- PASS: TestAccAWSSpotFleetRequest_basic (412.16s)
--- PASS: TestAccAWSSpotFleetRequest_changePriceForcesNewRequest (525.75s)
--- PASS: TestAccAWSSpotFleetRequest_diversifiedAllocation (266.75s)
--- PASS: TestAccAWSSpotFleetRequest_fleetType (295.24s)
--- PASS: TestAccAWSSpotFleetRequest_iamInstanceProfileArn (387.80s)
--- PASS: TestAccAWSSpotFleetRequest_instanceInterruptionBehavior (276.65s)
--- PASS: TestAccAWSSpotFleetRequest_LaunchSpecification_EbsBlockDevice_KmsKeyId (191.89s)
--- PASS: TestAccAWSSpotFleetRequest_LaunchSpecification_RootBlockDevice_KmsKeyId (182.38s)
--- PASS: TestAccAWSSpotFleetRequest_lowestPriceAzInGivenList (274.39s)
--- PASS: TestAccAWSSpotFleetRequest_lowestPriceAzOrSubnetInRegion (276.68s)
--- PASS: TestAccAWSSpotFleetRequest_lowestPriceSubnetInGivenList (218.95s)
--- PASS: TestAccAWSSpotFleetRequest_multipleInstancePools (265.21s)
--- PASS: TestAccAWSSpotFleetRequest_multipleInstanceTypesInSameAz (288.81s)
--- PASS: TestAccAWSSpotFleetRequest_multipleInstanceTypesInSameSubnet (228.79s)
--- PASS: TestAccAWSSpotFleetRequest_overriddingSpotPrice (255.04s)
--- PASS: TestAccAWSSpotFleetRequest_placementTenancyAndGroup (61.33s)
--- PASS: TestAccAWSSpotFleetRequest_updateExcessCapacityTerminationPolicy (543.75s)
--- PASS: TestAccAWSSpotFleetRequest_updateTargetCapacity (883.50s)
--- PASS: TestAccAWSSpotFleetRequest_withEBSDisk (368.32s)
--- PASS: TestAccAWSSpotFleetRequest_WithELBs (266.91s)
--- PASS: TestAccAWSSpotFleetRequest_withoutSpotPrice (262.01s)
--- PASS: TestAccAWSSpotFleetRequest_withTags (295.13s)
--- PASS: TestAccAWSSpotFleetRequest_WithTargetGroups (403.21s)
--- PASS: TestAccAWSSpotFleetRequest_withWeightedCapacity (275.44s)

--- PASS: TestAccAWSSpotInstanceRequest_basic (106.05s)
--- PASS: TestAccAWSSpotInstanceRequest_getPasswordData (261.45s)
--- PASS: TestAccAWSSpotInstanceRequest_NetworkInterfaceAttributes (100.98s)
--- PASS: TestAccAWSSpotInstanceRequest_SubnetAndSGAndPublicIpAddress (143.21s)
--- PASS: TestAccAWSSpotInstanceRequest_validUntil (116.82s)
--- PASS: TestAccAWSSpotInstanceRequest_vpc (122.18s)
--- PASS: TestAccAWSSpotInstanceRequest_withBlockDuration (95.86s)
--- PASS: TestAccAWSSpotInstanceRequest_withLaunchGroup (85.79s)
--- PASS: TestAccAWSSpotInstanceRequest_withoutSpotPrice (117.04s)

--- PASS: TestAccAWSSSMActivation_basic (34.84s)
--- PASS: TestAccAWSSSMActivation_disappears (27.99s)
--- PASS: TestAccAWSSSMActivation_update (39.53s)

--- PASS: TestAccAWSVpc_AssignGeneratedIpv6CidrBlock (75.46s)
--- PASS: TestAccAWSVpc_basic (30.07s)
--- PASS: TestAccAWSVpc_bothDnsOptionsSet (31.61s)
--- PASS: TestAccAWSVpc_classiclinkDnsSupportOptionSet (34.03s)
--- PASS: TestAccAWSVpc_classiclinkOptionSet (30.84s)
--- PASS: TestAccAWSVpc_coreMismatchedDiffs (26.30s)
--- PASS: TestAccAWSVpc_DisabledDnsSupport (31.74s)
--- PASS: TestAccAWSVpc_disappears (16.57s)
--- PASS: TestAccAWSVpc_ignoreTags (52.00s)
--- PASS: TestAccAWSVpc_tags (52.71s)
--- PASS: TestAccAWSVpc_Tenancy (76.46s)
--- PASS: TestAccAWSVpc_update (45.63s)

--- PASS: TestAccAwsVpcIpv4CidrBlockAssociation_basic (53.59s)

@bflad
provider: Fix and enable tfproviderlint V002, V004, V007, and V008
856a23d 
Reference: #11844

Previously:

```
aws/resource_aws_codepipeline_webhook.go:54:22: V002: deprecated validation.CIDRNetwork should be replaced with validation.IsCIDRNetwork
aws/resource_aws_vpc.go:37:19: V002: deprecated validation.CIDRNetwork should be replaced with validation.IsCIDRNetwork
aws/resource_aws_vpc_ipv4_cidr_block_association.go:39:19: V002: deprecated validation.CIDRNetwork should be replaced with validation.IsCIDRNetwork

aws/resource_aws_route53_resolver_endpoint.go:58:22: V004: deprecated validation.SingleIP should be replaced with validation.IsIPAddress
aws/resource_aws_route53_resolver_rule.go:79:22: V004: deprecated validation.SingleIP should be replaced with validation.IsIPAddress

aws/data_source_aws_ami.go:35:19: V007: deprecated validation.ValidateRegexp should be replaced with validation.StringIsValidRegExp
aws/data_source_aws_ami_ids.go:33:19: V007: deprecated validation.ValidateRegexp should be replaced with validation.StringIsValidRegExp
aws/data_source_aws_elastic_beanstalk_solution_stack.go:22:19: V007: deprecated validation.ValidateRegexp should be replaced with validation.StringIsValidRegExp

aws/resource_aws_appsync_api_key.go:46:19: V008: deprecated validation.ValidateRFC3339TimeString should be replaced with validation.IsRFC3339Time
aws/resource_aws_ec2_capacity_reservation.go:45:19: V008: deprecated validation.ValidateRFC3339TimeString should be replaced with validation.IsRFC3339Time
aws/resource_aws_kms_external_key.go:86:19: V008: deprecated validation.ValidateRFC3339TimeString should be replaced with validation.IsRFC3339Time
aws/resource_aws_lambda_event_source_mapping.go:62:19: V008: deprecated validation.ValidateRFC3339TimeString should be replaced with validation.IsRFC3339Time
aws/resource_aws_launch_template.go:320:25: V008: deprecated validation.ValidateRFC3339TimeString should be replaced with validation.IsRFC3339Time
aws/resource_aws_s3_bucket_object.go:193:19: V008: deprecated validation.ValidateRFC3339TimeString should be replaced with validation.IsRFC3339Time
aws/resource_aws_spot_fleet_request.go:343:19: V008: deprecated validation.ValidateRFC3339TimeString should be replaced with validation.IsRFC3339Time
aws/resource_aws_spot_fleet_request.go:349:19: V008: deprecated validation.ValidateRFC3339TimeString should be replaced with validation.IsRFC3339Time
aws/resource_aws_spot_instance_request.go:104:19: V008: deprecated validation.ValidateRFC3339TimeString should be replaced with validation.IsRFC3339Time
aws/resource_aws_spot_instance_request.go:97:19: V008: deprecated validation.ValidateRFC3339TimeString should be replaced with validation.IsRFC3339Time
aws/resource_aws_ssm_activation.go:42:19: V008: deprecated validation.ValidateRFC3339TimeString should be replaced with validation.IsRFC3339Time
```

Output from acceptance testing:

```
--- PASS: TestAccAWSAmiDataSource_instanceStore (14.77s)
--- PASS: TestAccAWSAmiDataSource_localNameFilter (18.63s)
--- PASS: TestAccAWSAmiDataSource_natInstance (15.86s)
--- PASS: TestAccAWSAmiDataSource_windowsInstance (17.85s)

--- PASS: TestAccDataSourceAwsAmiIds_basic (15.83s)
--- PASS: TestAccDataSourceAwsAmiIds_sorted (31.07s)

--- PASS: TestAccAWSElasticBeanstalkSolutionStackDataSource (13.74s)

--- PASS: TestAccAWSAppsyncApiKey_basic (19.11s)
--- PASS: TestAccAWSAppsyncApiKey_Description (26.75s)
--- PASS: TestAccAWSAppsyncApiKey_Expires (26.03s)

--- PASS: TestAccAWSCodePipelineWebhook_basic (45.87s)
--- PASS: TestAccAWSCodePipelineWebhook_ipAuth (44.09s)
--- PASS: TestAccAWSCodePipelineWebhook_tags (92.65s)
--- PASS: TestAccAWSCodePipelineWebhook_unauthenticated (45.40s)
--- PASS: TestAccAWSCodePipelineWebhook_UpdateAuthenticationConfiguration_SecretToken (63.24s)

--- PASS: TestAccAWSEc2CapacityReservation_basic (19.18s)
--- PASS: TestAccAWSEc2CapacityReservation_ebsOptimized (18.24s)
--- PASS: TestAccAWSEc2CapacityReservation_endDate (30.99s)
--- PASS: TestAccAWSEc2CapacityReservation_endDateType (44.58s)
--- PASS: TestAccAWSEc2CapacityReservation_ephemeralStorage (18.73s)
--- PASS: TestAccAWSEc2CapacityReservation_instanceCount (32.83s)
--- PASS: TestAccAWSEc2CapacityReservation_instanceMatchCriteria (18.71s)
--- PASS: TestAccAWSEc2CapacityReservation_instanceType (32.72s)
--- PASS: TestAccAWSEc2CapacityReservation_tags (45.51s)

--- PASS: TestAccAWSKmsExternalKey_basic (41.14s)
--- PASS: TestAccAWSKmsExternalKey_DeletionWindowInDays (52.45s)
--- PASS: TestAccAWSKmsExternalKey_Description (52.48s)
--- PASS: TestAccAWSKmsExternalKey_disappears (33.53s)
--- PASS: TestAccAWSKmsExternalKey_Enabled (308.60s)
--- PASS: TestAccAWSKmsExternalKey_KeyMaterialBase64 (145.65s)
--- PASS: TestAccAWSKmsExternalKey_Policy (53.09s)
--- PASS: TestAccAWSKmsExternalKey_Tags (65.26s)
--- PASS: TestAccAWSKmsExternalKey_ValidTo (191.46s)

--- PASS: TestAccAWSLambdaEventSourceMapping_BatchWindow (85.38s)
--- PASS: TestAccAWSLambdaEventSourceMapping_BisectBatch (83.25s)
--- PASS: TestAccAWSLambdaEventSourceMapping_changesInEnabledAreDetected (86.33s)
--- PASS: TestAccAWSLambdaEventSourceMapping_kinesis_basic (84.71s)
--- PASS: TestAccAWSLambdaEventSourceMapping_kinesis_disappears (70.37s)
--- PASS: TestAccAWSLambdaEventSourceMapping_kinesis_removeBatchSize (84.85s)
--- PASS: TestAccAWSLambdaEventSourceMapping_KinesisDestinationConfig (87.03s)
--- PASS: TestAccAWSLambdaEventSourceMapping_MaximumRecordAgeInSeconds (83.44s)
--- PASS: TestAccAWSLambdaEventSourceMapping_MaximumRetryAttempts (83.57s)
--- PASS: TestAccAWSLambdaEventSourceMapping_ParallelizationFactor (84.20s)
--- PASS: TestAccAWSLambdaEventSourceMapping_sqs_basic (91.05s)
--- PASS: TestAccAWSLambdaEventSourceMapping_sqs_withFunctionName (38.73s)
--- PASS: TestAccAWSLambdaEventSourceMapping_sqsDisappears (132.14s)
--- PASS: TestAccAWSLambdaEventSourceMapping_StartingPositionTimestamp (70.89s)

--- PASS: TestAccAWSLaunchTemplate_associatePublicIPAddress (81.29s)
--- PASS: TestAccAWSLaunchTemplate_basic (16.75s)
--- PASS: TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS (41.98s)
--- PASS: TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS_DeleteOnTermination (48.44s)
--- PASS: TestAccAWSLaunchTemplate_capacityReservation_preference (19.58s)
--- PASS: TestAccAWSLaunchTemplate_capacityReservation_target (20.22s)
--- PASS: TestAccAWSLaunchTemplate_cpuOptions (16.28s)
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_nonBurstable (16.50s)
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_t2 (19.34s)
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_t3 (17.09s)
--- PASS: TestAccAWSLaunchTemplate_data (17.93s)
--- PASS: TestAccAWSLaunchTemplate_description (31.55s)
--- PASS: TestAccAWSLaunchTemplate_disappears (12.52s)
--- PASS: TestAccAWSLaunchTemplate_EbsOptimized (61.86s)
--- PASS: TestAccAWSLaunchTemplate_ElasticInferenceAccelerator (30.31s)
--- PASS: TestAccAWSLaunchTemplate_IamInstanceProfile_EmptyConfigurationBlock (14.70s)
--- PASS: TestAccAWSLaunchTemplate_instanceMarketOptions (50.72s)
--- PASS: TestAccAWSLaunchTemplate_licenseSpecification (21.67s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface (36.47s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface_ipv6AddressCount (16.76s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface_ipv6Addresses (17.95s)
--- PASS: TestAccAWSLaunchTemplate_tags (34.53s)
--- PASS: TestAccAWSLaunchTemplate_update (79.77s)

--- PASS: TestAccAwsRoute53ResolverEndpoint_basicInbound (97.11s)
--- PASS: TestAccAwsRoute53ResolverEndpoint_updateOutbound (394.08s)

--- PASS: TestAccAwsRoute53ResolverRule_basic (41.82s)
--- PASS: TestAccAwsRoute53ResolverRule_forward (297.20s)
--- PASS: TestAccAwsRoute53ResolverRule_forwardEndpointRecreate (430.76s)
--- PASS: TestAccAwsRoute53ResolverRule_tags (69.62s)
--- PASS: TestAccAwsRoute53ResolverRule_updateName (67.71s)

--- PASS: TestAccAWSS3BucketObject_acl (76.63s)
--- PASS: TestAccAWSS3BucketObject_content (35.37s)
--- PASS: TestAccAWSS3BucketObject_contentBase64 (36.20s)
--- PASS: TestAccAWSS3BucketObject_empty (32.32s)
--- PASS: TestAccAWSS3BucketObject_etagEncryption (34.91s)
--- PASS: TestAccAWSS3BucketObject_kms (56.13s)
--- PASS: TestAccAWSS3BucketObject_metadata (74.02s)
--- PASS: TestAccAWSS3BucketObject_noNameNoKey (1.31s)
--- PASS: TestAccAWSS3BucketObject_ObjectLockLegalHoldStartWithNone (77.38s)
--- PASS: TestAccAWSS3BucketObject_ObjectLockLegalHoldStartWithOn (58.46s)
--- PASS: TestAccAWSS3BucketObject_ObjectLockRetentionStartWithNone (79.33s)
--- PASS: TestAccAWSS3BucketObject_ObjectLockRetentionStartWithSet (99.87s)
--- PASS: TestAccAWSS3BucketObject_source (31.86s)
--- PASS: TestAccAWSS3BucketObject_sse (34.55s)
--- PASS: TestAccAWSS3BucketObject_storageClass (116.76s)
--- PASS: TestAccAWSS3BucketObject_tags (101.60s)
--- PASS: TestAccAWSS3BucketObject_tagsLeadingSlash (99.58s)
--- PASS: TestAccAWSS3BucketObject_updates (55.60s)
--- PASS: TestAccAWSS3BucketObject_updateSameFile (57.91s)
--- PASS: TestAccAWSS3BucketObject_updatesWithVersioning (54.93s)
--- PASS: TestAccAWSS3BucketObject_updatesWithVersioningViaAccessPoint (63.40s)
--- PASS: TestAccAWSS3BucketObject_withContentCharacteristics (38.99s)

--- PASS: TestAccAWSSpotFleetRequest_associatePublicIpAddress (285.86s)
--- PASS: TestAccAWSSpotFleetRequest_basic (412.16s)
--- PASS: TestAccAWSSpotFleetRequest_changePriceForcesNewRequest (525.75s)
--- PASS: TestAccAWSSpotFleetRequest_diversifiedAllocation (266.75s)
--- PASS: TestAccAWSSpotFleetRequest_fleetType (295.24s)
--- PASS: TestAccAWSSpotFleetRequest_iamInstanceProfileArn (387.80s)
--- PASS: TestAccAWSSpotFleetRequest_instanceInterruptionBehavior (276.65s)
--- PASS: TestAccAWSSpotFleetRequest_LaunchSpecification_EbsBlockDevice_KmsKeyId (191.89s)
--- PASS: TestAccAWSSpotFleetRequest_LaunchSpecification_RootBlockDevice_KmsKeyId (182.38s)
--- PASS: TestAccAWSSpotFleetRequest_lowestPriceAzInGivenList (274.39s)
--- PASS: TestAccAWSSpotFleetRequest_lowestPriceAzOrSubnetInRegion (276.68s)
--- PASS: TestAccAWSSpotFleetRequest_lowestPriceSubnetInGivenList (218.95s)
--- PASS: TestAccAWSSpotFleetRequest_multipleInstancePools (265.21s)
--- PASS: TestAccAWSSpotFleetRequest_multipleInstanceTypesInSameAz (288.81s)
--- PASS: TestAccAWSSpotFleetRequest_multipleInstanceTypesInSameSubnet (228.79s)
--- PASS: TestAccAWSSpotFleetRequest_overriddingSpotPrice (255.04s)
--- PASS: TestAccAWSSpotFleetRequest_placementTenancyAndGroup (61.33s)
--- PASS: TestAccAWSSpotFleetRequest_updateExcessCapacityTerminationPolicy (543.75s)
--- PASS: TestAccAWSSpotFleetRequest_updateTargetCapacity (883.50s)
--- PASS: TestAccAWSSpotFleetRequest_withEBSDisk (368.32s)
--- PASS: TestAccAWSSpotFleetRequest_WithELBs (266.91s)
--- PASS: TestAccAWSSpotFleetRequest_withoutSpotPrice (262.01s)
--- PASS: TestAccAWSSpotFleetRequest_withTags (295.13s)
--- PASS: TestAccAWSSpotFleetRequest_WithTargetGroups (403.21s)
--- PASS: TestAccAWSSpotFleetRequest_withWeightedCapacity (275.44s)

--- PASS: TestAccAWSSpotInstanceRequest_basic (106.05s)
--- PASS: TestAccAWSSpotInstanceRequest_getPasswordData (261.45s)
--- PASS: TestAccAWSSpotInstanceRequest_NetworkInterfaceAttributes (100.98s)
--- PASS: TestAccAWSSpotInstanceRequest_SubnetAndSGAndPublicIpAddress (143.21s)
--- PASS: TestAccAWSSpotInstanceRequest_validUntil (116.82s)
--- PASS: TestAccAWSSpotInstanceRequest_vpc (122.18s)
--- PASS: TestAccAWSSpotInstanceRequest_withBlockDuration (95.86s)
--- PASS: TestAccAWSSpotInstanceRequest_withLaunchGroup (85.79s)
--- PASS: TestAccAWSSpotInstanceRequest_withoutSpotPrice (117.04s)

--- PASS: TestAccAWSSSMActivation_basic (34.84s)
--- PASS: TestAccAWSSSMActivation_disappears (27.99s)
--- PASS: TestAccAWSSSMActivation_update (39.53s)

--- PASS: TestAccAWSVpc_AssignGeneratedIpv6CidrBlock (75.46s)
--- PASS: TestAccAWSVpc_basic (30.07s)
--- PASS: TestAccAWSVpc_bothDnsOptionsSet (31.61s)
--- PASS: TestAccAWSVpc_classiclinkDnsSupportOptionSet (34.03s)
--- PASS: TestAccAWSVpc_classiclinkOptionSet (30.84s)
--- PASS: TestAccAWSVpc_coreMismatchedDiffs (26.30s)
--- PASS: TestAccAWSVpc_DisabledDnsSupport (31.74s)
--- PASS: TestAccAWSVpc_disappears (16.57s)
--- PASS: TestAccAWSVpc_ignoreTags (52.00s)
--- PASS: TestAccAWSVpc_tags (52.71s)
--- PASS: TestAccAWSVpc_Tenancy (76.46s)
--- PASS: TestAccAWSVpc_update (45.63s)

--- PASS: TestAccAwsVpcIpv4CidrBlockAssociation_basic (53.59s)
```
@bflad bflad added the technical-debt Addresses areas of the codebase that need refactoring or redesign. label Mar 3, 2020
@bflad bflad requested a review from a team March 3, 2020 17:31
@ghost ghost added size/S Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/appsync Issues and PRs that pertain to the appsync service. service/codepipeline Issues and PRs that pertain to the codepipeline service. service/ec2 Issues and PRs that pertain to the ec2 service. service/elasticbeanstalk Issues and PRs that pertain to the elasticbeanstalk service. service/kms Issues and PRs that pertain to the kms service. service/lambda Issues and PRs that pertain to the lambda service. service/route53resolver Issues and PRs that pertain to the route53resolver service. service/s3 Issues and PRs that pertain to the s3 service. service/ssm Issues and PRs that pertain to the ssm service. labels Mar 3, 2020
@bflad bflad removed the needs-triage Waiting for first response or review from a maintainer. label Mar 3, 2020
katbyte
katbyte approved these changes Mar 10, 2020
View reviewed changes
Copy link
Contributor

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bflad bflad added this to the v2.53.0 milestone Mar 10, 2020
@bflad bflad merged commit 12461ea into master Mar 10, 2020
@bflad bflad deleted the td-tfproviderlint-V002 branch March 10, 2020 20:20
@ghost
Copy link

ghost commented Mar 12, 2020

This has been released in version 2.53.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Apr 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
service/appsync Issues and PRs that pertain to the appsync service. service/codepipeline Issues and PRs that pertain to the codepipeline service. service/ec2 Issues and PRs that pertain to the ec2 service. service/elasticbeanstalk Issues and PRs that pertain to the elasticbeanstalk service. service/kms Issues and PRs that pertain to the kms service. service/lambda Issues and PRs that pertain to the lambda service. service/route53resolver Issues and PRs that pertain to the route53resolver service. service/s3 Issues and PRs that pertain to the s3 service. service/ssm Issues and PRs that pertain to the ssm service. size/S Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Projects
None yet
Milestone
v2.53.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bflad @katbyte