Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/asg: Fix TestAccAWSAutoScalingGroup_VpcUpdates #1218

Merged
merged 1 commit into from
Jul 24, 2017
Merged

r/asg: Fix TestAccAWSAutoScalingGroup_VpcUpdates #1218

merged 1 commit into from
Jul 24, 2017

Conversation

radeksimko
Copy link
Member

This was just overlooked when merging bugfix #1191

Before

=== RUN   TestAccAWSAutoScalingGroup_VpcUpdates
--- FAIL: TestAccAWSAutoScalingGroup_VpcUpdates (42.93s)
    testing.go:428: Step 0 error: Check failed: Check 4/4 error: aws_autoscaling_group.bar: Attribute 'vpc_zone_identifier.#' expected "1", got "0"
FAIL

After

=== RUN   TestAccAWSAutoScalingGroup_VpcUpdates
--- PASS: TestAccAWSAutoScalingGroup_VpcUpdates (122.28s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	122.312s

cc @joshuaspence

@radeksimko radeksimko added the bug Addresses a defect in current functionality. label Jul 24, 2017
joshuaspence
joshuaspence approved these changes Jul 24, 2017
View reviewed changes
Copy link
Contributor

@joshuaspence joshuaspence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah whoops, thanks for the fix

@radeksimko radeksimko merged commit 32d8662 into master Jul 24, 2017
@radeksimko radeksimko deleted the b-asg-vpc-zone-id-fix branch July 24, 2017 10:05
@ghost
Copy link

ghost commented Apr 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joshuaspence joshuaspence joshuaspence approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radeksimko @joshuaspence