Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maintenance window task cloudwatch config #12167

Conversation

0x91
Copy link
Contributor

@0x91 0x91 commented Feb 25, 2020

This branch adds the cloudwatch output configurations to the aws_ssm_maintenance_window_task for RunCommand tasks. This lets you output task execution logs to Cloudwatch instead of S3.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:

 * add support to SSM Maintenance Tasks for logging to CloudWatch Logs

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSSSMMaintenanceWindowTask'
=== RUN   TestAccAWSSSMMaintenanceWindowTask_basic
=== PAUSE TestAccAWSSSMMaintenanceWindowTask_basic
=== RUN   TestAccAWSSSMMaintenanceWindowTask_updateForcesNewResource
=== PAUSE TestAccAWSSSMMaintenanceWindowTask_updateForcesNewResource
=== RUN   TestAccAWSSSMMaintenanceWindowTask_TaskInvocationAutomationParameters
=== PAUSE TestAccAWSSSMMaintenanceWindowTask_TaskInvocationAutomationParameters
=== RUN   TestAccAWSSSMMaintenanceWindowTask_TaskInvocationLambdaParameters
=== PAUSE TestAccAWSSSMMaintenanceWindowTask_TaskInvocationLambdaParameters
=== RUN   TestAccAWSSSMMaintenanceWindowTask_TaskInvocationRunCommandParameters
=== PAUSE TestAccAWSSSMMaintenanceWindowTask_TaskInvocationRunCommandParameters
=== RUN   TestAccAWSSSMMaintenanceWindowTask_TaskInvocationStepFunctionParameters
=== PAUSE TestAccAWSSSMMaintenanceWindowTask_TaskInvocationStepFunctionParameters
=== RUN   TestAccAWSSSMMaintenanceWindowTask_TaskParameters
=== PAUSE TestAccAWSSSMMaintenanceWindowTask_TaskParameters
=== RUN   TestAccAWSSSMMaintenanceWindowTask_emptyNotificationConfig
=== PAUSE TestAccAWSSSMMaintenanceWindowTask_emptyNotificationConfig
=== CONT  TestAccAWSSSMMaintenanceWindowTask_basic
=== CONT  TestAccAWSSSMMaintenanceWindowTask_TaskInvocationStepFunctionParameters
=== CONT  TestAccAWSSSMMaintenanceWindowTask_emptyNotificationConfig
=== CONT  TestAccAWSSSMMaintenanceWindowTask_TaskParameters
=== CONT  TestAccAWSSSMMaintenanceWindowTask_TaskInvocationLambdaParameters
=== CONT  TestAccAWSSSMMaintenanceWindowTask_updateForcesNewResource
=== CONT  TestAccAWSSSMMaintenanceWindowTask_TaskInvocationRunCommandParameters
=== CONT  TestAccAWSSSMMaintenanceWindowTask_TaskInvocationAutomationParameters
--- PASS: TestAccAWSSSMMaintenanceWindowTask_emptyNotificationConfig (60.69s)
--- PASS: TestAccAWSSSMMaintenanceWindowTask_TaskInvocationStepFunctionParameters (67.25s)
--- PASS: TestAccAWSSSMMaintenanceWindowTask_TaskParameters (68.17s)
--- PASS: TestAccAWSSSMMaintenanceWindowTask_updateForcesNewResource (99.68s)
--- PASS: TestAccAWSSSMMaintenanceWindowTask_basic (104.96s)
--- PASS: TestAccAWSSSMMaintenanceWindowTask_TaskInvocationLambdaParameters (106.88s)
--- PASS: TestAccAWSSSMMaintenanceWindowTask_TaskInvocationRunCommandParameters (143.15s)
--- PASS: TestAccAWSSSMMaintenanceWindowTask_TaskInvocationAutomationParameters (148.23s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	148.295s
...

@ghost ghost added size/M Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/ssm Issues and PRs that pertain to the ssm service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Feb 25, 2020
@0x91 0x91 force-pushed the feat/aws_ssm_maintenance_window_task_cloudwatch branch from 7d8a888 to 0b26434 Compare February 26, 2020 17:12
@0x91 0x91 force-pushed the feat/aws_ssm_maintenance_window_task_cloudwatch branch from 0b26434 to 972effd Compare February 26, 2020 17:48
@ghost ghost added the documentation Introduces or discusses updates to documentation. label Feb 26, 2020
@0x91 0x91 marked this pull request as ready for review February 26, 2020 17:48
@0x91 0x91 requested a review from a team February 26, 2020 17:48
@0x91
Copy link
Contributor Author

0x91 commented Mar 16, 2020

bump?

@giuliocalzolari
Copy link

any ETA?

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels May 14, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @0x91 👋 Thank you for submitting this. Looking pretty good -- can you please just split the new functionality into its own test and configuration so we can verify that the original configuration still works fine? Thanks so much.

@bflad bflad added the waiting-response Maintainers are waiting on response from community or contributor. label May 14, 2020
@bflad bflad modified the milestone: v2.69.0 Jul 2, 2020
@mycodeself
Copy link

I want to work on this if necessary, should I open a new PR?

@ghost ghost removed the waiting-response Maintainers are waiting on response from community or contributor. label Jul 22, 2020
Base automatically changed from master to main January 23, 2021 00:57
@breathingdust breathingdust requested a review from a team as a code owner January 23, 2021 00:57
@bflad
Copy link
Contributor

bflad commented Feb 12, 2021

Hi @0x91 👋 Thank you for working on this. This functionality is being merged in from the earlier #11774 and will be available in version 3.28.0 of the Terraform AWS Provider releasing later today.

@bflad bflad closed this Feb 12, 2021
@ghost
Copy link

ghost commented Mar 14, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/ssm Issues and PRs that pertain to the ssm service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants