tests/provider: Enable tfproviderlint R004 check

[bflad]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #9954
Requires:

• resource/aws_batch_job_definition: Properly set container_properties and name into Terraform state and fix basic test #11488 ✅
• provider: Fix d.Set() calls with invalid *time.Time value input #11491 ✅
• resource/aws_appautoscaling_policy: Remove unimplemented alarms attribute #11494 ✅
• resource/aws_dms_certificate: Properly set certificate_wallet into Terraform state #11496 ✅
• resource/aws_ec2_client_vpn_endpoint: Properly set status value into Terraform state #11497 ✅
• resource/aws_waf_sql_injection_match_set: Properly set sql_injection_match_tuples into Terraform state #11498 ✅

Release note for CHANGELOG:

NONE

The additional import_aws_s3_bucket.go fix was the last remaining linter issue:

/Users/bflad/src/github.com/terraform-providers/terraform-provider-aws/aws/import_aws_s3_bucket.go:36:22: R004: ResourceData.Set() incompatible value type: *github.com/aws/aws-sdk-go/service/s3.GetBucketPolicyOutput
35		pData.Set("bucket", d.Id())
36		pData.Set("policy", pol)
37		results = append(results, pData)

The aws_s3_bucket resource implements what we refer to as a "complex" import with multiple resources, which has been discouraged for a long time now and will likely be removed (along with the handful of other resources that do the same) in a future major version of the provider. I found and marked issues related to that with the 3.0.0 milestone for now. The fix, while valid, has little real consequence in practice since import performs an immediate refresh of the relevant Terraform resources immediately after import in recent versions of Terraform unless refresh is explicitly disabled (which is strongly discouraged in the Terraform CLI documentation) so its not really worth a CHANGELOG mention.

Output from relevant acceptance testing (other tests do not perform necessary ImportStateCheck to verify the complex import):

--- PASS: TestAccAWSS3Bucket_Policy (95.74s)

[gdavison]

LGTM 🚀

--- PASS: TestAccAWSS3Bucket_Policy (61.49s)

[ghost]

This has been released in version 2.48.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!