Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ECS Service enums + eventual consistency for service-role #11423

Merged
merged 7 commits into from
Jan 3, 2020
Merged

ECS Service enums + eventual consistency for service-role #11423

merged 7 commits into from
Jan 3, 2020

Commits on Dec 25, 2019

  1. add arn validations 

    add enum validations
eventual consistency
    @DrFaust92
    DrFaust92 committed Dec 25, 2019
    Configuration menu
    Copy the full SHA
    5b2f59b View commit details
    Browse the repository at this point in the history

  2. check arn test change

    @DrFaust92
    DrFaust92 committed Dec 25, 2019
    Configuration menu
    Copy the full SHA
    25ce049 View commit details
    Browse the repository at this point in the history

  3. remove role arn validation

    @DrFaust92
    DrFaust92 committed Dec 25, 2019
    Configuration menu
    Copy the full SHA
    96cd1ea View commit details
    Browse the repository at this point in the history

  4. remove commented out code

    @DrFaust92
    DrFaust92 committed Dec 25, 2019
    Configuration menu
    Copy the full SHA
    05781ed View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2020

  1. Update aws/resource_aws_ecs_service_test.go 

    comments

Co-Authored-By: Brian Flad <[email protected]>
    @DrFaust92 @bflad
    DrFaust92 and bflad authored Jan 2, 2020
    Configuration menu
    Copy the full SHA
    e494a3c View commit details
    Browse the repository at this point in the history

  2. add name tags to test resources

    @DrFaust92
    DrFaust92 committed Jan 2, 2020
    Configuration menu
    Copy the full SHA
    124a143 View commit details
    Browse the repository at this point in the history

  3. fix rename test

    @DrFaust92
    DrFaust92 committed Jan 2, 2020
    Configuration menu
    Copy the full SHA
    b03027b View commit details
    Browse the repository at this point in the history