Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SFN State Machine Express support #11374

Closed
wants to merge 13 commits into from
Closed

SFN State Machine Express support #11374

wants to merge 13 commits into from

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Dec 19, 2019 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #11348, #7893

Release note for CHANGELOG:

- resource/resource_aws_sfn_state_machine: add `type` argument

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSSfnStateMachine_'

--- PASS: TestAccAWSSfnStateMachine_Tags (137.24s)
--- PASS: TestAccAWSSfnStateMachine_type_express (69.36s)
--- PASS: TestAccAWSLambdaFunction_disappears (78.15s)
--- FAIL: TestAccAWSSfnStateMachine_createUpdate (94.95s)
    testing.go:635: Step 2 error: Check failed: Check 6/7 error: aws_sfn_state_machine.test: Attribute 'definition' didn't match..


...

Tried to add logging config for the EXPRESS type but had issue with perceptual diffs so will open a seperate PR

@DrFaust92 DrFaust92 requested a review from a team December 19, 2019 20:29
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/sfn Issues and PRs that pertain to the sfn service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Dec 19, 2019
@DrFaust92 DrFaust92 changed the title [WIP]SFN State Machine Express support SFN State Machine Express support Dec 21, 2019
@rockycore
Copy link
Contributor

Check my PR: #11570

@rockycore rockycore mentioned this pull request Jan 12, 2020
Closed
@DrFaust92
Copy link
Collaborator Author

closed in favor of #11570

@DrFaust92 DrFaust92 closed this Feb 3, 2020
@grahamjenson grahamjenson mentioned this pull request Mar 4, 2020
Merged
@ghost
Copy link

ghost commented Mar 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 27, 2020
@DrFaust92 DrFaust92 deleted the sfn-express branch April 14, 2020 21:48
@breathingdust breathingdust removed the needs-triage Waiting for first response or review from a maintainer. label Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. service/sfn Issues and PRs that pertain to the sfn service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add type to aws_sfn_state_machine
3 participants
@DrFaust92 @rockycore @breathingdust