Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add replication time control #11337

Closed
wants to merge 5 commits into from
Closed

Add replication time control #11337

wants to merge 5 commits into from

Conversation

rebrowning
Copy link

@rebrowning rebrowning commented Dec 18, 2019 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #10974

Release note for CHANGELOG:

adds replication time control configuration

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSS3Bucket_ReplicationTimeControl'

...

EDIT: I've added logic so that you don't have to specify a filter alongside RTC in order to use the v2 api

@rebrowning rebrowning requested a review from a team December 18, 2019 00:35
@ghost ghost added size/L Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/s3 Issues and PRs that pertain to the s3 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. size/M Managed by automation to categorize the size of a PR. labels Dec 18, 2019
@ghost ghost added size/L Managed by automation to categorize the size of a PR. and removed size/XL Managed by automation to categorize the size of a PR. labels Dec 21, 2019
@rebrowning rebrowning changed the title [WIP] inital changes to implement enabling replication time control inital changes to implement enabling replication time control Dec 21, 2019
@rebrowning rebrowning changed the title inital changes to implement enabling replication time control initial changes to implement enabling replication time control Dec 21, 2019
@rebrowning rebrowning changed the title initial changes to implement enabling replication time control Add replication time control Dec 23, 2019
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Feb 20, 2020
@alexdotsh
Copy link

Any update on this? I see there is a conflict on this PR, if it's resolved, can it be looked into? Thanks!

@rebrowning
inital changes to implement enabling replication time control
79f984c 
need to put this prefix in place if it's defined

trying to fix some tests

cleanup
@rebrowning
Copy link
Author

fixed the merge conflicts that existed and updated some other linting issues that were found in the additions.

@jonjohnston
Copy link

Since this requires changes to replication configuration, should also include the new ability to replicate delete markers.
"DeleteMarkerReplication": { "Status": "Enabled" }

@JoshiiSinfield JoshiiSinfield mentioned this pull request Nov 20, 2020
Closed
@jonjohnston
Copy link

What is the holdup on this? This is a feature that has been available for over a year and yet can't use terraform to implement it. Please follow up on this.

@alexdotsh
Copy link

@bflad, Could you please have a look at this PR? It would be nice to have this feature added to terraform aws provider. Thanks!

@manherfo
Copy link

manherfo commented Dec 4, 2020

@bflad, Could you please have a look at this PR? It would be useful to have this feature added to terraform aws provider. Thanks!

@lwoerdeman
Copy link

@bflad, any updates on this? Would be great to have this merged!

@joeran-lab
Copy link

@bflad, Could you please have a look at this PR? It would be useful to have this feature added to terraform aws provider. Thanks!

Base automatically changed from master to main January 23, 2021 00:56
@breathingdust breathingdust requested a review from a team as a code owner January 23, 2021 00:56
@timoguin
Copy link
Contributor

timoguin commented Feb 3, 2021 •
edited
Loading

Hey @rebrowning, great work on this PR! I can confirm that it works. What do you think about removing the magic handling of the metrics and filter attributes? I think it may be better to stick closer to the S3 API and instead add notes to the documentation about dependencies between the various settings.

@Xercoy
Copy link

Xercoy commented Mar 2, 2021

This would be a great feature to have as part of the AWS provider. Not doing too much replication yet so manually toggling these options isn't too bad, but I can't imagine a scalable solution without this. Thanks for taking the time to work on this @rebrowning and to all reviewers @bflad.

@jonjohnston
Copy link

What is the hold up on this feature?!?

@myrabokhari
Copy link

Any updates on this? It would be great to have this feature up as soon as possible. Thanks!

@TheNomet
Copy link

Hello! Any updates on this? Would be extremely useful to have the PR merged and the functionality available?
And thank you @rebrowning for working on this!

@zhelding
Copy link
Contributor

Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding.

Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single aws directory to a large number of separate directories in internal/service, each corresponding to a particular AWS service. This separation of code has also allowed for us to simplify the names of underlying functions -- while still avoiding namespace collisions.

We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author.

For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000.

For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide.

@ewbankkit
Copy link
Contributor

This functionality has been implemented via #21176 and released in v3.64.0 of the Terraform AWS Provider.

@ewbankkit
Copy link
Contributor

@rebrowning Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit closed this Nov 4, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/s3 Issues and PRs that pertain to the s3 service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.