r/aws_network_interface: Add an update check

[nozaq]

Do not call ec2:ModifyNetworkInterfaceAttribute when arguments are not
changed.

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #11273

Release note for CHANGELOG:

resource/aws_network_interface: Do not call ec2:ModifyNetworkInterfaceAttribute when arguments are not changed.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSENI_sourceDestCheck'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -count 1 -parallel 20 -run=TestAccAWSENI_sourceDestCheck -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSENI_sourceDestCheck
=== PAUSE TestAccAWSENI_sourceDestCheck
=== CONT  TestAccAWSENI_sourceDestCheck
--- PASS: TestAccAWSENI_sourceDestCheck (65.85s)
PASS                                                             
ok      github.com/terraform-providers/terraform-provider-aws/aws       65.882s
testing: warning: no tests to run                                
PASS                                                             
ok      github.com/terraform-providers/terraform-provider-aws/aws/internal/flatmap      0.032s [no tests to run]
testing: warning: no tests to run                                                                                                 
PASS                                                             
ok      github.com/terraform-providers/terraform-provider-aws/aws/internal/keyvaluetags 0.005s [no tests to run]

[bflad]

Hi @nozaq 👋 Thank you for submitting this. This appears to be the correct fix in this case, just one small typo fix and we should be able to get this in. 👍

[nozaq]

@bflad Thanks for your review, just pushed a fix! 👍

[bflad]

Looks great, @nozaq, thanks for fixing this! 🚀

Output from acceptance testing:

--- PASS: TestAccAWSENI_computedIPs (34.67s)
--- PASS: TestAccAWSENI_sourceDestCheck (34.96s)
--- PASS: TestAccAWSENI_disappears (36.52s)
--- PASS: TestAccAWSENI_basic (39.59s)
--- PASS: TestAccAWSENI_updatedDescription (63.27s)
--- PASS: TestAccAWSENI_PrivateIpsCount (96.03s)
--- PASS: TestAccAWSENI_ignoreExternalAttachment (107.54s)
--- PASS: TestAccAWSENI_attached (242.78s)

[ghost]

This has been released in version 2.42.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!