Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

service/elasticache: Refactor to use keyvaluetags package, add arn attribute to aws_elasticache_cluster resource #11243

Merged
merged 1 commit into from
Jan 9, 2020
Merged

service/elasticache: Refactor to use keyvaluetags package, add arn attribute to aws_elasticache_cluster resource #11243

merged 1 commit into from
Jan 9, 2020

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Dec 11, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Reference: #10688

Release note for CHANGELOG:

* resource/aws_elasticache_cluster: Add `arn` attribute

Output from acceptance testing:

--- PASS: TestAccAWSDataElasticacheCluster_basic (574.70s)

--- PASS: TestAccAWSElasticacheCluster_AZMode_Memcached_Ec2Classic (500.73s)
--- PASS: TestAccAWSElasticacheCluster_AZMode_Redis_Ec2Classic (489.54s)
--- PASS: TestAccAWSElasticacheCluster_Engine_Memcached_Ec2Classic (711.45s)
--- PASS: TestAccAWSElasticacheCluster_Engine_Redis_Ec2Classic (1206.50s)
--- PASS: TestAccAWSElasticacheCluster_EngineVersion_Memcached_Ec2Classic (1265.05s)
--- PASS: TestAccAWSElasticacheCluster_EngineVersion_Redis_Ec2Classic (1262.62s)
--- PASS: TestAccAWSElasticacheCluster_multiAZInVpc (848.53s)
--- PASS: TestAccAWSElasticacheCluster_NodeTypeResize_Memcached_Ec2Classic (1031.82s)
--- PASS: TestAccAWSElasticacheCluster_NodeTypeResize_Redis_Ec2Classic (888.93s)
--- PASS: TestAccAWSElasticacheCluster_NumCacheNodes_Decrease (857.20s)
--- PASS: TestAccAWSElasticacheCluster_NumCacheNodes_Increase (1181.66s)
--- PASS: TestAccAWSElasticacheCluster_NumCacheNodes_IncreaseWithPreferredAvailabilityZones (1251.62s)
--- PASS: TestAccAWSElasticacheCluster_NumCacheNodes_Redis_Ec2Classic (3.48s)
--- PASS: TestAccAWSElasticacheCluster_ParameterGroupName_Default (705.36s)
--- PASS: TestAccAWSElasticacheCluster_Port_Ec2Classic (589.12s)
--- PASS: TestAccAWSElasticacheCluster_ReplicationGroupID_AvailabilityZone_Ec2Classic (1893.58s)
--- PASS: TestAccAWSElasticacheCluster_ReplicationGroupID_InvalidAttributes (3.53s)
--- PASS: TestAccAWSElasticacheCluster_ReplicationGroupID_MultipleReplica_Ec2Classic (1797.08s)
--- PASS: TestAccAWSElasticacheCluster_ReplicationGroupID_SingleReplica_Ec2Classic (1947.07s)
--- PASS: TestAccAWSElasticacheCluster_SecurityGroup (580.53s)
--- PASS: TestAccAWSElasticacheCluster_snapshotsWithUpdates (1914.83s)
--- PASS: TestAccAWSElasticacheCluster_vpc (703.91s)

--- PASS: TestAccAWSElasticacheReplicationGroup_basic (965.72s)
--- PASS: TestAccAWSElasticacheReplicationGroup_clusteringAndCacheNodesCausesError (16.25s)
--- PASS: TestAccAWSElasticacheReplicationGroup_ClusterMode_Basic (2135.56s)
--- PASS: TestAccAWSElasticacheReplicationGroup_ClusterMode_NumNodeGroups (3785.64s)
--- PASS: TestAccAWSElasticacheReplicationGroup_enableAtRestEncryption (2054.20s)
--- PASS: TestAccAWSElasticacheReplicationGroup_enableAuthTokenTransitEncryption (1970.34s)
--- PASS: TestAccAWSElasticacheReplicationGroup_enableSnapshotting (1015.92s)
--- PASS: TestAccAWSElasticacheReplicationGroup_multiAzInVpc (1816.32s)
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters (2343.90s)
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_Failover_AutoFailoverDisabled (2888.41s)
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_Failover_AutoFailoverEnabled (3208.83s)
--- PASS: TestAccAWSElasticacheReplicationGroup_redisClusterInVpc2 (1249.72s)
--- PASS: TestAccAWSElasticacheReplicationGroup_updateDescription (1049.47s)
--- PASS: TestAccAWSElasticacheReplicationGroup_updateMaintenanceWindow (1028.18s)
--- PASS: TestAccAWSElasticacheReplicationGroup_updateNodeSize (1620.37s)
--- PASS: TestAccAWSElasticacheReplicationGroup_updateParameterGroup (905.78s)
--- PASS: TestAccAWSElasticacheReplicationGroup_Uppercase (1012.47s)
--- PASS: TestAccAWSElasticacheReplicationGroup_useCmkKmsKeyId (1554.09s)
--- PASS: TestAccAWSElasticacheReplicationGroup_vpc (1453.72s)

@bflad
service/elasticache: Refactor to use keyvaluetags package, add arn at…
9aa852b 
…tribute to aws_elasticache_cluster resource

Reference: #10688

Output from acceptance testing:

```
--- PASS: TestAccAWSDataElasticacheCluster_basic (574.70s)

--- PASS: TestAccAWSElasticacheCluster_AZMode_Memcached_Ec2Classic (500.73s)
--- PASS: TestAccAWSElasticacheCluster_AZMode_Redis_Ec2Classic (489.54s)
--- PASS: TestAccAWSElasticacheCluster_Engine_Memcached_Ec2Classic (711.45s)
--- PASS: TestAccAWSElasticacheCluster_Engine_Redis_Ec2Classic (1206.50s)
--- PASS: TestAccAWSElasticacheCluster_EngineVersion_Memcached_Ec2Classic (1265.05s)
--- PASS: TestAccAWSElasticacheCluster_EngineVersion_Redis_Ec2Classic (1262.62s)
--- PASS: TestAccAWSElasticacheCluster_multiAZInVpc (848.53s)
--- PASS: TestAccAWSElasticacheCluster_NodeTypeResize_Memcached_Ec2Classic (1031.82s)
--- PASS: TestAccAWSElasticacheCluster_NodeTypeResize_Redis_Ec2Classic (888.93s)
--- PASS: TestAccAWSElasticacheCluster_NumCacheNodes_Decrease (857.20s)
--- PASS: TestAccAWSElasticacheCluster_NumCacheNodes_Increase (1181.66s)
--- PASS: TestAccAWSElasticacheCluster_NumCacheNodes_IncreaseWithPreferredAvailabilityZones (1251.62s)
--- PASS: TestAccAWSElasticacheCluster_NumCacheNodes_Redis_Ec2Classic (3.48s)
--- PASS: TestAccAWSElasticacheCluster_ParameterGroupName_Default (705.36s)
--- PASS: TestAccAWSElasticacheCluster_Port_Ec2Classic (589.12s)
--- PASS: TestAccAWSElasticacheCluster_ReplicationGroupID_AvailabilityZone_Ec2Classic (1893.58s)
--- PASS: TestAccAWSElasticacheCluster_ReplicationGroupID_InvalidAttributes (3.53s)
--- PASS: TestAccAWSElasticacheCluster_ReplicationGroupID_MultipleReplica_Ec2Classic (1797.08s)
--- PASS: TestAccAWSElasticacheCluster_ReplicationGroupID_SingleReplica_Ec2Classic (1947.07s)
--- PASS: TestAccAWSElasticacheCluster_SecurityGroup (580.53s)
--- PASS: TestAccAWSElasticacheCluster_snapshotsWithUpdates (1914.83s)
--- PASS: TestAccAWSElasticacheCluster_vpc (703.91s)

--- PASS: TestAccAWSElasticacheReplicationGroup_basic (965.72s)
--- PASS: TestAccAWSElasticacheReplicationGroup_clusteringAndCacheNodesCausesError (16.25s)
--- PASS: TestAccAWSElasticacheReplicationGroup_ClusterMode_Basic (2135.56s)
--- PASS: TestAccAWSElasticacheReplicationGroup_ClusterMode_NumNodeGroups (3785.64s)
--- PASS: TestAccAWSElasticacheReplicationGroup_enableAtRestEncryption (2054.20s)
--- PASS: TestAccAWSElasticacheReplicationGroup_enableAuthTokenTransitEncryption (1970.34s)
--- PASS: TestAccAWSElasticacheReplicationGroup_enableSnapshotting (1015.92s)
--- PASS: TestAccAWSElasticacheReplicationGroup_multiAzInVpc (1816.32s)
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters (2343.90s)
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_Failover_AutoFailoverDisabled (2888.41s)
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_Failover_AutoFailoverEnabled (3208.83s)
--- PASS: TestAccAWSElasticacheReplicationGroup_redisClusterInVpc2 (1249.72s)
--- PASS: TestAccAWSElasticacheReplicationGroup_updateDescription (1049.47s)
--- PASS: TestAccAWSElasticacheReplicationGroup_updateMaintenanceWindow (1028.18s)
--- PASS: TestAccAWSElasticacheReplicationGroup_updateNodeSize (1620.37s)
--- PASS: TestAccAWSElasticacheReplicationGroup_updateParameterGroup (905.78s)
--- PASS: TestAccAWSElasticacheReplicationGroup_Uppercase (1012.47s)
--- PASS: TestAccAWSElasticacheReplicationGroup_useCmkKmsKeyId (1554.09s)
--- PASS: TestAccAWSElasticacheReplicationGroup_vpc (1453.72s)
```
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Dec 11, 2019
@bflad bflad requested a review from a team December 11, 2019 14:08
@ghost ghost added size/L Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/elasticache Issues and PRs that pertain to the elasticache service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 11, 2019
@bflad bflad removed the needs-triage Waiting for first response or review from a maintainer. label Dec 11, 2019
ryndaniels
ryndaniels approved these changes Jan 9, 2020
View reviewed changes
Copy link
Contributor

@ryndaniels ryndaniels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing a bunch of this error in the tests that looks unrelated to these changes:

Use of cache security groups is not permitted in this API version for your account.

so probably worth looking into separately but 🚀 otherwise

--- FAIL: TestAccAWSDataElasticacheCluster_basic (10.14s)

--- SKIP: TestAccAWSElasticacheCluster_ReplicationGroupID_AvailabilityZone_Ec2Classic (1.61s)
--- SKIP: TestAccAWSElasticacheCluster_AZMode_Memcached_Ec2Classic (1.81s)
--- SKIP: TestAccAWSElasticacheCluster_AZMode_Redis_Ec2Classic (1.82s)
--- SKIP: TestAccAWSElasticacheCluster_EngineVersion_Memcached_Ec2Classic (1.76s)
--- SKIP: TestAccAWSElasticacheCluster_NodeTypeResize_Redis_Ec2Classic (1.70s)
--- SKIP: TestAccAWSElasticacheCluster_NodeTypeResize_Memcached_Ec2Classic (1.59s)
--- SKIP: TestAccAWSElasticacheCluster_Engine_Redis_Ec2Classic (2.00s)
--- SKIP: TestAccAWSElasticacheCluster_NumCacheNodes_Redis_Ec2Classic (1.67s)
--- SKIP: TestAccAWSElasticacheCluster_Engine_Memcached_Ec2Classic (1.92s)
--- SKIP: TestAccAWSElasticacheCluster_Port_Ec2Classic (1.90s)
--- SKIP: TestAccAWSElasticacheCluster_ReplicationGroupID_InvalidAttributes (1.44s)
--- SKIP: TestAccAWSElasticacheCluster_EngineVersion_Redis_Ec2Classic (1.84s)
--- SKIP: TestAccAWSElasticacheCluster_ReplicationGroupID_SingleReplica_Ec2Classic (1.45s)
--- SKIP: TestAccAWSElasticacheCluster_ReplicationGroupID_MultipleReplica_Ec2Classic (1.55s)
--- FAIL: TestAccAWSElasticacheCluster_snapshotsWithUpdates (11.90s)
--- FAIL: TestAccAWSElasticacheCluster_SecurityGroup (12.50s)
--- PASS: TestAccAWSElasticacheCluster_vpc (648.58s)
--- PASS: TestAccAWSElasticacheCluster_ParameterGroupName_Default (654.72s)
--- PASS: TestAccAWSElasticacheCluster_multiAZInVpc (728.65s)
--- PASS: TestAccAWSElasticacheCluster_NumCacheNodes_IncreaseWithPreferredAvailabilityZones (1104.74s)
--- PASS: TestAccAWSElasticacheCluster_NumCacheNodes_Increase (1588.01s)
--- PASS: TestAccAWSElasticacheCluster_NumCacheNodes_Decrease (2716.80s)

--- FAIL: TestAccAWSElasticacheReplicationGroup_enableSnapshotting (15.11s)
--- FAIL: TestAccAWSElasticacheReplicationGroup_updateDescription (15.76s)
--- FAIL: TestAccAWSElasticacheReplicationGroup_basic (15.91s)
--- FAIL: TestAccAWSElasticacheReplicationGroup_updateNodeSize (15.94s)
--- FAIL: TestAccAWSElasticacheReplicationGroup_updateMaintenanceWindow (16.01s)
--- PASS: TestAccAWSElasticacheReplicationGroup_clusteringAndCacheNodesCausesError (19.41s)
--- PASS: TestAccAWSElasticacheReplicationGroup_useCmkKmsKeyId (666.36s)
--- PASS: TestAccAWSElasticacheReplicationGroup_enableAuthTokenTransitEncryption (940.33s)
--- PASS: TestAccAWSElasticacheReplicationGroup_ClusterMode_Basic (945.51s)
--- PASS: TestAccAWSElasticacheReplicationGroup_updateParameterGroup (1057.67s)
--- PASS: TestAccAWSElasticacheReplicationGroup_vpc (1476.29s)
--- PASS: TestAccAWSElasticacheReplicationGroup_multiAzInVpc (1486.51s)
--- PASS: TestAccAWSElasticacheReplicationGroup_redisClusterInVpc2 (1506.63s)
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_Failover_AutoFailoverDisabled (1578.61s)
--- PASS: TestAccAWSElasticacheReplicationGroup_enableAtRestEncryption (1698.20s)
--- PASS: TestAccAWSElasticacheReplicationGroup_Uppercase (1822.86s)
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters (2381.52s)
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_Failover_AutoFailoverEnabled (2936.63s)
--- PASS: TestAccAWSElasticacheReplicationGroup_ClusterMode_NumNodeGroups (4147.65s)

@bflad bflad mentioned this pull request Jan 9, 2020
Closed
@bflad
Copy link
Contributor Author

bflad commented Jan 9, 2020

@ryndaniels those errors are related to EC2-Classic support. Created tech-debt issue for fixing this: #11543

@bflad bflad added this to the v2.44.0 milestone Jan 9, 2020
@bflad bflad merged commit 973c3d0 into master Jan 9, 2020
@bflad bflad deleted the td-elasticache-keyvaluetags branch January 9, 2020 18:57
bflad added a commit that referenced this pull request Jan 9, 2020
@bflad
Update CHANGELOG for #11243
e3cb8fa
@ghost
Copy link

ghost commented Jan 10, 2020

This has been released in version 2.44.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryndaniels ryndaniels ryndaniels approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/elasticache Issues and PRs that pertain to the elasticache service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.44.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bflad @ryndaniels