Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ca_cert_identifier field to aws_rds_cluster_instance #11194

Conversation

rune-chan
Copy link

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #11142

Release note for CHANGELOG:

resource/aws_rds_cluster_instance: Add `ca_cert_identifier` argument

Output from acceptance testing:

$  make testacc TEST=./aws TESTARGS='-run=TestAccAWSRDSClusterInstance_CACertificateIdentifier'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSRDSClusterInstance_CACertificateIdentifier -timeout 120m
=== RUN   TestAccAWSRDSClusterInstance_CACertificateIdentifier
=== PAUSE TestAccAWSRDSClusterInstance_CACertificateIdentifier
=== CONT  TestAccAWSRDSClusterInstance_CACertificateIdentifier
--- PASS: TestAccAWSRDSClusterInstance_CACertificateIdentifier (1810.16s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       1810.198s

@ghost ghost added size/M Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/rds Issues and PRs that pertain to the rds service. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 7, 2019
@rune-chan rune-chan changed the title [WIP] Add ca_cert_identifier field to aws_rds_cluster_instance Add ca_cert_identifier field to aws_rds_cluster_instance Dec 7, 2019
@rune-chan rune-chan marked this pull request as ready for review December 7, 2019 15:21
@rune-chan rune-chan requested a review from a team December 7, 2019 15:21
@awsiv
Copy link
Contributor

awsiv commented Dec 7, 2019

Duplicate : #10954

Not sure why no one has looked into this yet :(

@rune-chan
Copy link
Author

@awsiv I will close mine if it's duplicated.

@rune-chan rune-chan closed this Dec 7, 2019
@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
@breathingdust breathingdust removed the needs-triage Waiting for first response or review from a maintainer. label Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/rds Issues and PRs that pertain to the rds service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No attribute for certificate identifier in resource: aws_rds_cluster_instance
3 participants