Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import test refactor for elasticsearch domains #10695

Merged
merged 1 commit into from
Nov 1, 2019
Merged

Conversation

ryndaniels
Copy link
Contributor

@ryndaniels ryndaniels commented Oct 31, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #8944

Release note for CHANGELOG:

NONE

Output from acceptance testing:

--- PASS: TestAccAWSElasticSearchDomain_encrypt_at_rest_default_key (774.16s)
--- PASS: TestAccAWSElasticSearchDomain_tags (939.82s)
--- PASS: TestAccAWSElasticSearchDomain_encrypt_at_rest_specify_key (971.70s)
--- PASS: TestAccAWSElasticSearchDomain_complex (1004.60s)
--- PASS: TestAccAWSElasticSearchDomain_basic (1024.82s)
--- PASS: TestAccAWSElasticSearchDomain_vpc (1044.26s)
--- PASS: TestAccAWSElasticSearchDomain_policy (1099.81s)
--- PASS: TestAccAWSElasticSearchDomain_duplicate (1120.28s)
--- PASS: TestAccAWSElasticSearchDomain_NodeToNodeEncryption (1163.84s)
--- PASS: TestAccAWSElasticSearchDomain_v23 (1422.41s)
--- PASS: TestAccAWSElasticSearchDomain_CognitoOptionsUpdate (2507.83s)
--- PASS: TestAccAWSElasticSearchDomain_internetToVpcEndpoint (2521.42s)
--- PASS: TestAccAWSElasticSearchDomain_update (2958.07s)
--- PASS: TestAccAWSElasticSearchDomain_vpc_update (3145.35s)
--- PASS: TestAccAWSElasticSearchDomain_withDedicatedMaster (3350.56s)
--- PASS: TestAccAWSElasticSearchDomain_update_volume_type (3758.01s)
--- PASS: TestAccAWSElasticSearchDomain_update_version (4075.83s)
--- PASS: TestAccAWSElasticSearchDomain_ClusterConfig_ZoneAwarenessConfig (5132.64s)
--- PASS: TestAccAWSElasticSearchDomain_LogPublishingOptions (702.60s)
--- PASS: TestAccAWSElasticSearchDomain_CognitoOptionsCreateAndRemove (1569.91s)

@ryndaniels ryndaniels requested review from bflad and a team October 31, 2019 11:13
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. service/elasticsearch Issues and PRs that pertain to the elasticsearch service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 31, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

--- PASS: TestAccAWSElasticSearchDomain_basic (617.64s)
--- PASS: TestAccAWSElasticSearchDomain_policy (757.00s)
--- PASS: TestAccAWSElasticSearchDomain_encrypt_at_rest_specify_key (830.40s)
--- PASS: TestAccAWSElasticSearchDomain_complex (1010.42s)
--- PASS: TestAccAWSElasticSearchDomain_encrypt_at_rest_default_key (1030.44s)
--- PASS: TestAccAWSElasticSearchDomain_v23 (1140.38s)
--- PASS: TestAccAWSElasticSearchDomain_NodeToNodeEncryption (1303.82s)
--- PASS: TestAccAWSElasticSearchDomain_LogPublishingOptions (1378.71s)
--- PASS: TestAccAWSElasticSearchDomainPolicy_basic (1405.38s)
--- PASS: TestAccAWSElasticSearchDomain_tags (1463.05s)
--- PASS: TestAccAWSElasticSearchDomain_internetToVpcEndpoint (1640.49s)
--- PASS: TestAccAWSElasticSearchDomain_CognitoOptionsCreateAndRemove (1698.92s)
--- PASS: TestAccAWSElasticSearchDomain_duplicate (1707.51s)
--- PASS: TestAccAWSElasticSearchDomain_vpc (1725.50s)
--- PASS: TestAccAWSElasticSearchDomain_CognitoOptionsUpdate (1808.01s)
--- PASS: TestAccAWSElasticSearchDomain_update (2195.01s)
--- PASS: TestAccAWSElasticSearchDomain_vpc_update (2603.36s)
--- PASS: TestAccAWSElasticSearchDomain_withDedicatedMaster (3413.79s)
--- PASS: TestAccAWSElasticSearchDomain_update_volume_type (3538.71s)
--- PASS: TestAccAWSElasticSearchDomain_update_version (3825.77s)
--- PASS: TestAccAWSElasticSearchDomain_ClusterConfig_ZoneAwarenessConfig (5212.66s)

@bflad bflad added this to the v2.35.0 milestone Oct 31, 2019
@ryndaniels ryndaniels merged commit 28461fd into master Nov 1, 2019
@ryndaniels ryndaniels deleted the rfd-at002-esdomain branch November 1, 2019 09:04
@ghost
Copy link

ghost commented Nov 7, 2019

This has been released in version 2.35.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/elasticsearch Issues and PRs that pertain to the elasticsearch service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants