Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't ignore dualstack prefix in Route 53 alias names #10672

Merged
merged 7 commits into from
Jul 26, 2022
Merged

Don't ignore dualstack prefix in Route 53 alias names #10672

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
eed81d6
Add test for route 53 alias with dualstack prefix
ngaya-ll Oct 30, 2019
7cf2550
Don't remove dualstack prefix in Route 53 aliases
ngaya-ll Oct 30, 2019
45eb22a
route53: Fix merge with new
YakDriver Jul 25, 2022
07c97ab
route53: Minor cleanup
YakDriver Jul 26, 2022
44961e1
route53: Splinter
YakDriver Jul 26, 2022
0a5576e
route53: Update names
YakDriver Jul 26, 2022
c6c03b5
Add changelog
YakDriver Jul 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/10672.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:bug
resource/aws_route53_record: Don't ignore `dualstack` prefix in Route 53 Record alias names
```
3 changes: 1 addition & 2 deletions internal/service/route53/record.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -996,8 +996,7 @@ func nilString(s string) *string {
}

func NormalizeAliasName(alias interface{}) string {
input := strings.ToLower(alias.(string))
output := strings.TrimPrefix(input, "dualstack.")
output := strings.ToLower(alias.(string))
return strings.TrimSuffix(output, ".")
}

Expand Down
Loading