Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update spot-allocation-strategy attribute #10614

Merged
merged 1 commit into from
Nov 19, 2019
Merged

update spot-allocation-strategy attribute #10614

merged 1 commit into from
Nov 19, 2019

Conversation

mbordas09
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

update spot-allocation-strategy attribute with supported values.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@mbordas09 mbordas09 requested a review from a team October 23, 2019 18:31
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/autoscaling Issues and PRs that pertain to the autoscaling service. documentation Introduces or discusses updates to documentation. labels Oct 23, 2019
bflad
bflad approved these changes Nov 19, 2019
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM according to the AutoScaling API Reference, thanks @mbordas09 🚀

@bflad bflad added this to the v2.39.0 milestone Nov 19, 2019
@bflad bflad merged commit e82841a into hashicorp:master Nov 19, 2019
@ghost
Copy link

ghost commented Nov 21, 2019

This has been released in version 2.39.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. service/autoscaling Issues and PRs that pertain to the autoscaling service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v2.39.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mbordas09 @bflad