Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import test refactor for cloudwatch resources #10606

Merged
merged 1 commit into from
Oct 29, 2019
Merged

Conversation

ryndaniels
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #8944

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make testacc TESTARGS="-run=TestAccAWSCloudWatchDashboard_"     
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -count 1 -parallel 20 -run=TestAccAWSCloudWatchDashboard_ -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSCloudWatchDashboard_basic
=== PAUSE TestAccAWSCloudWatchDashboard_basic
=== RUN   TestAccAWSCloudWatchDashboard_update
=== PAUSE TestAccAWSCloudWatchDashboard_update
=== CONT  TestAccAWSCloudWatchDashboard_basic
=== CONT  TestAccAWSCloudWatchDashboard_update
--- PASS: TestAccAWSCloudWatchDashboard_basic (29.06s)
--- PASS: TestAccAWSCloudWatchDashboard_update (49.18s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       50.623s

make testacc TESTARGS="-run=TestAccAWSCloudWatchEventRule_"     
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -count 1 -parallel 20 -run=TestAccAWSCloudWatchEventRule_ -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSCloudWatchEventRule_basic
=== PAUSE TestAccAWSCloudWatchEventRule_basic
=== RUN   TestAccAWSCloudWatchEventRule_prefix
=== PAUSE TestAccAWSCloudWatchEventRule_prefix
=== RUN   TestAccAWSCloudWatchEventRule_tags
=== PAUSE TestAccAWSCloudWatchEventRule_tags
=== RUN   TestAccAWSCloudWatchEventRule_full
=== PAUSE TestAccAWSCloudWatchEventRule_full
=== RUN   TestAccAWSCloudWatchEventRule_enable
=== PAUSE TestAccAWSCloudWatchEventRule_enable
=== CONT  TestAccAWSCloudWatchEventRule_basic
=== CONT  TestAccAWSCloudWatchEventRule_full
=== CONT  TestAccAWSCloudWatchEventRule_tags
=== CONT  TestAccAWSCloudWatchEventRule_enable
=== CONT  TestAccAWSCloudWatchEventRule_prefix
--- PASS: TestAccAWSCloudWatchEventRule_prefix (26.61s)
--- PASS: TestAccAWSCloudWatchEventRule_full (32.70s)
--- PASS: TestAccAWSCloudWatchEventRule_basic (52.97s)
--- PASS: TestAccAWSCloudWatchEventRule_enable (74.29s)
--- PASS: TestAccAWSCloudWatchEventRule_tags (78.16s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       79.584s

make testacc TESTARGS="-run=TestAccAWSCloudwatchLogDestinationPolicy_"    
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -count 1 -parallel 20 -run=TestAccAWSCloudwatchLogDestinationPolicy_ -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSCloudwatchLogDestinationPolicy_basic
=== PAUSE TestAccAWSCloudwatchLogDestinationPolicy_basic
=== CONT  TestAccAWSCloudwatchLogDestinationPolicy_basic
--- PASS: TestAccAWSCloudwatchLogDestinationPolicy_basic (108.18s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       109.603s

make testacc TESTARGS="-run=TestAccAWSCloudwatchLogDestination_"==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -count 1 -parallel 20 -run=TestAccAWSCloudwatchLogDestination_ -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSCloudwatchLogDestination_basic
=== PAUSE TestAccAWSCloudwatchLogDestination_basic
=== CONT  TestAccAWSCloudwatchLogDestination_basic
--- PASS: TestAccAWSCloudwatchLogDestination_basic (107.40s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       108.821s

make testacc TESTARGS="-run=TestAccAWSCloudWatchLogGroup_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -count 1 -parallel 20 -run=TestAccAWSCloudWatchLogGroup_ -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSCloudWatchLogGroup_basic
=== PAUSE TestAccAWSCloudWatchLogGroup_basic
=== RUN   TestAccAWSCloudWatchLogGroup_namePrefix
=== PAUSE TestAccAWSCloudWatchLogGroup_namePrefix
=== RUN   TestAccAWSCloudWatchLogGroup_namePrefix_retention
=== PAUSE TestAccAWSCloudWatchLogGroup_namePrefix_retention
=== RUN   TestAccAWSCloudWatchLogGroup_generatedName
=== PAUSE TestAccAWSCloudWatchLogGroup_generatedName
=== RUN   TestAccAWSCloudWatchLogGroup_retentionPolicy
=== PAUSE TestAccAWSCloudWatchLogGroup_retentionPolicy
=== RUN   TestAccAWSCloudWatchLogGroup_multiple
=== PAUSE TestAccAWSCloudWatchLogGroup_multiple
=== RUN   TestAccAWSCloudWatchLogGroup_disappears
=== PAUSE TestAccAWSCloudWatchLogGroup_disappears
=== RUN   TestAccAWSCloudWatchLogGroup_tagging
=== PAUSE TestAccAWSCloudWatchLogGroup_tagging
=== RUN   TestAccAWSCloudWatchLogGroup_kmsKey
=== PAUSE TestAccAWSCloudWatchLogGroup_kmsKey
=== CONT  TestAccAWSCloudWatchLogGroup_basic
=== CONT  TestAccAWSCloudWatchLogGroup_kmsKey
=== CONT  TestAccAWSCloudWatchLogGroup_retentionPolicy
=== CONT  TestAccAWSCloudWatchLogGroup_tagging
=== CONT  TestAccAWSCloudWatchLogGroup_namePrefix_retention
=== CONT  TestAccAWSCloudWatchLogGroup_namePrefix
=== CONT  TestAccAWSCloudWatchLogGroup_disappears
=== CONT  TestAccAWSCloudWatchLogGroup_multiple
=== CONT  TestAccAWSCloudWatchLogGroup_generatedName
--- PASS: TestAccAWSCloudWatchLogGroup_disappears (21.28s)
--- PASS: TestAccAWSCloudWatchLogGroup_namePrefix (27.10s)
--- PASS: TestAccAWSCloudWatchLogGroup_basic (30.97s)
--- PASS: TestAccAWSCloudWatchLogGroup_generatedName (31.01s)
--- PASS: TestAccAWSCloudWatchLogGroup_multiple (34.61s)
--- PASS: TestAccAWSCloudWatchLogGroup_retentionPolicy (50.32s)
--- PASS: TestAccAWSCloudWatchLogGroup_namePrefix_retention (50.61s)
--- PASS: TestAccAWSCloudWatchLogGroup_tagging (91.06s)
--- PASS: TestAccAWSCloudWatchLogGroup_kmsKey (92.46s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       93.881s

 make testacc TESTARGS="-run=TestAccAWSCloudWatchLogResourcePolicy_"    
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -count 1 -parallel 20 -run=TestAccAWSCloudWatchLogResourcePolicy_ -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSCloudWatchLogResourcePolicy_basic
=== PAUSE TestAccAWSCloudWatchLogResourcePolicy_basic
=== CONT  TestAccAWSCloudWatchLogResourcePolicy_basic
--- PASS: TestAccAWSCloudWatchLogResourcePolicy_basic (49.55s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       50.982s

@ryndaniels ryndaniels requested review from bflad and a team October 23, 2019 11:55
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. service/cloudwatchlogs service/cloudwatch Issues and PRs that pertain to the cloudwatch service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 23, 2019
@bflad bflad self-assigned this Oct 25, 2019
@bflad bflad added this to the v2.34.0 milestone Oct 25, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

--- PASS: TestResourceAWSCloudWatchEventRule_validateEventPatternValue (0.00s)
--- PASS: TestAccAWSCloudWatchLogGroup_disappears (14.30s)
--- PASS: TestAccAWSCloudWatchEventRule_prefix (16.09s)
--- PASS: TestAccAWSCloudWatchDashboard_basic (17.38s)
--- PASS: TestAccAWSCloudWatchEventRule_full (18.98s)
--- PASS: TestAccAWSCloudWatchLogGroup_basic (19.13s)
--- PASS: TestAccAWSCloudWatchLogGroup_generatedName (19.21s)
--- PASS: TestAccAWSCloudWatchLogGroup_multiple (19.27s)
--- PASS: TestAccAWSCloudWatchLogGroup_namePrefix (19.57s)
--- PASS: TestAccAWSCloudWatchLogGroup_namePrefix_retention (24.25s)
--- PASS: TestAccAWSCloudWatchEventRule_basic (24.70s)
--- PASS: TestAccAWSCloudWatchLogGroup_retentionPolicy (24.65s)
--- PASS: TestAccAWSCloudWatchDashboard_update (25.63s)
--- PASS: TestAccAWSCloudWatchEventRule_enable (26.33s)
--- PASS: TestAccAWSCloudWatchLogResourcePolicy_basic (26.48s)
--- PASS: TestAccAWSCloudWatchEventRule_tags (28.43s)
--- PASS: TestAccAWSCloudWatchLogGroup_tagging (33.87s)
--- PASS: TestAccAWSCloudWatchLogGroup_kmsKey (43.95s)
--- PASS: TestAccAWSCloudwatchLogDestination_basic (82.02s)
--- PASS: TestAccAWSCloudwatchLogDestinationPolicy_basic (82.73s)

@ryndaniels ryndaniels merged commit 3fd3726 into master Oct 29, 2019
@ryndaniels ryndaniels deleted the rfd-at002-cloudwatch branch October 29, 2019 09:19
@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/cloudwatch Issues and PRs that pertain to the cloudwatch service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants