Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import test refactor for customer gateway #10597

Merged
merged 1 commit into from
Oct 29, 2019
Merged

Conversation

ryndaniels
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #8944

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make testacc TESTARGS="-run=TestAccAWSCustomerGateway_"     
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -count 1 -parallel 20 -run=TestAccAWSCustomerGateway_ -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSCustomerGateway_basic
=== PAUSE TestAccAWSCustomerGateway_basic
=== RUN   TestAccAWSCustomerGateway_similarAlreadyExists
=== PAUSE TestAccAWSCustomerGateway_similarAlreadyExists
=== RUN   TestAccAWSCustomerGateway_disappears
=== PAUSE TestAccAWSCustomerGateway_disappears
=== CONT  TestAccAWSCustomerGateway_basic
=== CONT  TestAccAWSCustomerGateway_disappears
=== CONT  TestAccAWSCustomerGateway_similarAlreadyExists
--- PASS: TestAccAWSCustomerGateway_disappears (34.17s)
--- PASS: TestAccAWSCustomerGateway_similarAlreadyExists (47.71s)
--- PASS: TestAccAWSCustomerGateway_basic (90.33s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       91.786s

@ryndaniels ryndaniels requested review from bflad and a team October 22, 2019 09:46
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 22, 2019
@bflad bflad self-assigned this Oct 25, 2019
@bflad bflad added this to the v2.34.0 milestone Oct 25, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

--- PASS: TestAccAWSCustomerGateway_disappears (16.83s)
--- PASS: TestAccAWSCustomerGatewayDataSource_ID (19.15s)
--- PASS: TestAccAWSCustomerGatewayDataSource_Filter (19.64s)
--- PASS: TestAccAWSCustomerGateway_similarAlreadyExists (21.73s)
--- PASS: TestAccAWSCustomerGateway_basic (39.31s)

@ryndaniels ryndaniels merged commit 6bf99d7 into master Oct 29, 2019
@ryndaniels ryndaniels deleted the rfd-at002-custgw branch October 29, 2019 09:17
@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/ec2 Issues and PRs that pertain to the ec2 service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants