Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource - aws_ec2_client_vpn_route #10560

Closed
wants to merge 5 commits into from

Conversation

angelabad
Copy link
Contributor

@angelabad angelabad commented Oct 19, 2019

Create new resource for EC2 Client VPN routes (https://docs.aws.amazon.com/vpn/latest/clientvpn-admin/cvpn-working-routes.html)

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #10437
Closes #7831

Release note for CHANGELOG:

New Resource: aws_ec2_client_vpn_route

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAwsEc2ClientVpnRoute'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsEc2ClientVpnRoute -timeout 120m
=== RUN   TestAccAwsEc2ClientVpnRoute_basic
=== PAUSE TestAccAwsEc2ClientVpnRoute_basic
=== RUN   TestAccAwsEc2ClientVpnRoute_disappears
=== PAUSE TestAccAwsEc2ClientVpnRoute_disappears
=== CONT  TestAccAwsEc2ClientVpnRoute_basic
=== CONT  TestAccAwsEc2ClientVpnRoute_disappears
--- PASS: TestAccAwsEc2ClientVpnRoute_basic (623.28s)
--- PASS: TestAccAwsEc2ClientVpnRoute_disappears (633.34s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       633.617s

@angelabad angelabad requested a review from a team October 19, 2019 16:49
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 19, 2019
Copy link

@Cryptophobia Cryptophobia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@angelabad
Copy link
Contributor Author

Hi, what about this pull request?

@angelabad angelabad removed the request for review from a team March 18, 2020 15:52
@angelabad angelabad changed the title New resource - aws_ec2_client_vpn_route WIP: New resource - aws_ec2_client_vpn_route Mar 22, 2020
@angelabad angelabad changed the title WIP: New resource - aws_ec2_client_vpn_route New resource - aws_ec2_client_vpn_route Mar 22, 2020
@angelabad angelabad changed the title New resource - aws_ec2_client_vpn_route [WIP] New resource - aws_ec2_client_vpn_route Mar 22, 2020
@angelabad angelabad changed the title [WIP] New resource - aws_ec2_client_vpn_route New resource - aws_ec2_client_vpn_route Mar 22, 2020
@angelabad angelabad closed this Apr 11, 2020
@ghost
Copy link

ghost commented May 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators May 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/ec2 Issues and PRs that pertain to the ec2 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Client VPN Endpoint - Create Client Route VPN Client Endpoint Route Creation
2 participants