resource/aws_subnet: Refactor to use keyvaluetags library and call Read after Create #10411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad after Create Reference: #7926 Similar in nature to: #10315 In preparation for provider-wide ignore and default tag logic, here we refactor this resource to use the consistent `keyvaluetags` handling. The previous `setTags()` logic was always performing retries only necessary for resource creation and the resource itself was not following recommended practices to call the Read function after Create. Ouput from acceptance testing: ``` --- PASS: TestAccAWSSubnet_availabilityZoneId (25.22s) --- PASS: TestAccAWSSubnet_basic (25.66s) --- PASS: TestAccAWSSubnet_enableIpv6 (41.83s) --- PASS: TestAccAWSSubnet_ipv6 (66.62s) ```
ghost
added
size/M
bflad
added
the
technical-debt
ryndaniels
approved these changes
Oct 18, 2019
bflad
added a commit
that referenced
this pull request
Oct 29, 2019
Reference: https://blog.golang.org/go1.13-errors Reference: #10411 Found via acceptance testing prior to an actual release: ``` --- FAIL: TestAccAWSEMRCluster_basic (19.03s) testing.go:615: Step 0 error: errors during apply: Error: error adding tags: error tagging resource (subnet-04c4088b2c7f3aa42): InvalidSubnetID.NotFound: The subnet ID 'subnet-04c4088b2c7f3aa42' does not exist status code: 400, request id: 2dafd3b1-ffef-49f9-98e0-1ede0726e8bb ``` Any logic attempting to check the returned AWS Go SDK error code/message from `keyvaluetags` package `UpdateTags` usage will not work since the errors are currently wrapped by value, which was the only option in Go 1.12 and earlier. Go 1.13 introduced the new `%w` verb for `fmt.Errorf()` for wrapping errors, which allows downstream logic to check wrapped error types via `errors.As()`. Updated via: ```console $ make gen ```
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Reference: #7926
Similar in nature to: #10315
Release note for CHANGELOG:
In preparation for provider-wide ignore and default tag logic, here we refactor this resource to use the consistent
keyvaluetagshandling. The previoussetTags()logic was always performing retries only necessary for resource creation and the resource itself was not following recommended practices to call the Read function after Create.Output from acceptance testing: