Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Acceptance import test refactor for lambda #10027

Merged
merged 1 commit into from
Oct 9, 2019
Merged

Acceptance import test refactor for lambda #10027

merged 1 commit into from
Oct 9, 2019

Conversation

ryndaniels
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #8944

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make testacc TESTARGS="-run=TestAccAWSLambdaEventSourceMapping"            ==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSLambdaEventSourceMapping -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
^[[A=== RUN   TestAccAWSLambdaEventSourceMapping_kinesis_basic
=== PAUSE TestAccAWSLambdaEventSourceMapping_kinesis_basic
=== RUN   TestAccAWSLambdaEventSourceMapping_kinesis_removeBatchSize
=== PAUSE TestAccAWSLambdaEventSourceMapping_kinesis_removeBatchSize
=== RUN   TestAccAWSLambdaEventSourceMapping_sqs_basic
=== PAUSE TestAccAWSLambdaEventSourceMapping_sqs_basic
=== RUN   TestAccAWSLambdaEventSourceMapping_sqs_withFunctionName
=== PAUSE TestAccAWSLambdaEventSourceMapping_sqs_withFunctionName
=== RUN   TestAccAWSLambdaEventSourceMapping_kinesis_disappears
=== PAUSE TestAccAWSLambdaEventSourceMapping_kinesis_disappears
=== RUN   TestAccAWSLambdaEventSourceMapping_sqsDisappears
=== PAUSE TestAccAWSLambdaEventSourceMapping_sqsDisappears
=== RUN   TestAccAWSLambdaEventSourceMapping_changesInEnabledAreDetected
=== PAUSE TestAccAWSLambdaEventSourceMapping_changesInEnabledAreDetected
=== RUN   TestAccAWSLambdaEventSourceMapping_StartingPositionTimestamp
=== PAUSE TestAccAWSLambdaEventSourceMapping_StartingPositionTimestamp
=== CONT  TestAccAWSLambdaEventSourceMapping_kinesis_basic
=== CONT  TestAccAWSLambdaEventSourceMapping_StartingPositionTimestamp
=== CONT  TestAccAWSLambdaEventSourceMapping_sqs_withFunctionName
=== CONT  TestAccAWSLambdaEventSourceMapping_kinesis_disappears
=== CONT  TestAccAWSLambdaEventSourceMapping_changesInEnabledAreDetected
=== CONT  TestAccAWSLambdaEventSourceMapping_sqsDisappears
=== CONT  TestAccAWSLambdaEventSourceMapping_sqs_basic
=== CONT  TestAccAWSLambdaEventSourceMapping_kinesis_removeBatchSize
--- PASS: TestAccAWSLambdaEventSourceMapping_sqs_withFunctionName (52.33s)
--- PASS: TestAccAWSLambdaEventSourceMapping_sqs_basic (85.40s)
--- PASS: TestAccAWSLambdaEventSourceMapping_kinesis_disappears (103.96s)
--- PASS: TestAccAWSLambdaEventSourceMapping_StartingPositionTimestamp (108.62s)
--- PASS: TestAccAWSLambdaEventSourceMapping_kinesis_removeBatchSize (121.78s)
--- PASS: TestAccAWSLambdaEventSourceMapping_kinesis_basic (123.17s)
--- PASS: TestAccAWSLambdaEventSourceMapping_sqsDisappears (128.20s)
--- PASS: TestAccAWSLambdaEventSourceMapping_changesInEnabledAreDetected (135.68s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       137.353s

make testacc TESTARGS="-run=TestAccAWSLambdaFunction"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSLambdaFunction -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
√=== RUN   TestAccAWSLambdaFunction_basic
=== PAUSE TestAccAWSLambdaFunction_basic
=== RUN   TestAccAWSLambdaFunction_concurrency
=== PAUSE TestAccAWSLambdaFunction_concurrency
=== RUN   TestAccAWSLambdaFunction_concurrencyCycle
=== PAUSE TestAccAWSLambdaFunction_concurrencyCycle
=== RUN   TestAccAWSLambdaFunction_updateRuntime
=== PAUSE TestAccAWSLambdaFunction_updateRuntime
=== RUN   TestAccAWSLambdaFunction_expectFilenameAndS3Attributes
=== PAUSE TestAccAWSLambdaFunction_expectFilenameAndS3Attributes
=== RUN   TestAccAWSLambdaFunction_envVariables
=== PAUSE TestAccAWSLambdaFunction_envVariables
=== RUN   TestAccAWSLambdaFunction_encryptedEnvVariables
=== PAUSE TestAccAWSLambdaFunction_encryptedEnvVariables
=== RUN   TestAccAWSLambdaFunction_versioned
=== PAUSE TestAccAWSLambdaFunction_versioned
=== RUN   TestAccAWSLambdaFunction_versionedUpdate
=== PAUSE TestAccAWSLambdaFunction_versionedUpdate
=== RUN   TestAccAWSLambdaFunction_DeadLetterConfig
=== PAUSE TestAccAWSLambdaFunction_DeadLetterConfig
=== RUN   TestAccAWSLambdaFunction_DeadLetterConfigUpdated
=== PAUSE TestAccAWSLambdaFunction_DeadLetterConfigUpdated
=== RUN   TestAccAWSLambdaFunction_nilDeadLetterConfig
=== PAUSE TestAccAWSLambdaFunction_nilDeadLetterConfig
=== RUN   TestAccAWSLambdaFunction_tracingConfig
=== PAUSE TestAccAWSLambdaFunction_tracingConfig
=== RUN   TestAccAWSLambdaFunction_Layers
=== PAUSE TestAccAWSLambdaFunction_Layers
=== RUN   TestAccAWSLambdaFunction_LayersUpdate
=== PAUSE TestAccAWSLambdaFunction_LayersUpdate
=== RUN   TestAccAWSLambdaFunction_VPC
=== PAUSE TestAccAWSLambdaFunction_VPC
=== RUN   TestAccAWSLambdaFunction_VPCRemoval
=== PAUSE TestAccAWSLambdaFunction_VPCRemoval
=== RUN   TestAccAWSLambdaFunction_VPCUpdate
=== PAUSE TestAccAWSLambdaFunction_VPCUpdate
=== RUN   TestAccAWSLambdaFunction_VPC_withInvocation
=== PAUSE TestAccAWSLambdaFunction_VPC_withInvocation
=== RUN   TestAccAWSLambdaFunction_EmptyVpcConfig
=== PAUSE TestAccAWSLambdaFunction_EmptyVpcConfig
=== RUN   TestAccAWSLambdaFunction_s3
=== PAUSE TestAccAWSLambdaFunction_s3
=== RUN   TestAccAWSLambdaFunction_localUpdate
=== PAUSE TestAccAWSLambdaFunction_localUpdate
=== RUN   TestAccAWSLambdaFunction_localUpdate_nameOnly
=== PAUSE TestAccAWSLambdaFunction_localUpdate_nameOnly
=== RUN   TestAccAWSLambdaFunction_s3Update_basic
=== PAUSE TestAccAWSLambdaFunction_s3Update_basic
=== RUN   TestAccAWSLambdaFunction_s3Update_unversioned
=== PAUSE TestAccAWSLambdaFunction_s3Update_unversioned
=== RUN   TestAccAWSLambdaFunction_runtimeValidation_noRuntime
=== PAUSE TestAccAWSLambdaFunction_runtimeValidation_noRuntime
=== RUN   TestAccAWSLambdaFunction_runtimeValidation_NodeJs810
=== PAUSE TestAccAWSLambdaFunction_runtimeValidation_NodeJs810
=== RUN   TestAccAWSLambdaFunction_runtimeValidation_NodeJs10x
=== PAUSE TestAccAWSLambdaFunction_runtimeValidation_NodeJs10x
=== RUN   TestAccAWSLambdaFunction_runtimeValidation_python27
=== PAUSE TestAccAWSLambdaFunction_runtimeValidation_python27
=== RUN   TestAccAWSLambdaFunction_runtimeValidation_java8
=== PAUSE TestAccAWSLambdaFunction_runtimeValidation_java8
=== RUN   TestAccAWSLambdaFunction_tags
=== PAUSE TestAccAWSLambdaFunction_tags
=== RUN   TestAccAWSLambdaFunction_runtimeValidation_provided
=== PAUSE TestAccAWSLambdaFunction_runtimeValidation_provided
=== RUN   TestAccAWSLambdaFunction_runtimeValidation_python36
=== PAUSE TestAccAWSLambdaFunction_runtimeValidation_python36
=== RUN   TestAccAWSLambdaFunction_runtimeValidation_python37
=== PAUSE TestAccAWSLambdaFunction_runtimeValidation_python37
=== RUN   TestAccAWSLambdaFunction_runtimeValidation_ruby25
=== PAUSE TestAccAWSLambdaFunction_runtimeValidation_ruby25
=== CONT  TestAccAWSLambdaFunction_basic
=== CONT  TestAccAWSLambdaFunction_VPCUpdate
=== CONT  TestAccAWSLambdaFunction_VPC_withInvocation
=== CONT  TestAccAWSLambdaFunction_runtimeValidation_ruby25
=== CONT  TestAccAWSLambdaFunction_runtimeValidation_python37
=== CONT  TestAccAWSLambdaFunction_runtimeValidation_python36
=== CONT  TestAccAWSLambdaFunction_runtimeValidation_provided
=== CONT  TestAccAWSLambdaFunction_s3Update_unversioned
=== CONT  TestAccAWSLambdaFunction_s3Update_basic
=== CONT  TestAccAWSLambdaFunction_localUpdate_nameOnly
=== CONT  TestAccAWSLambdaFunction_localUpdate
=== CONT  TestAccAWSLambdaFunction_s3
=== CONT  TestAccAWSLambdaFunction_runtimeValidation_noRuntime
=== CONT  TestAccAWSLambdaFunction_tags
=== CONT  TestAccAWSLambdaFunction_runtimeValidation_java8
=== CONT  TestAccAWSLambdaFunction_runtimeValidation_python27
=== CONT  TestAccAWSLambdaFunction_runtimeValidation_NodeJs10x
=== CONT  TestAccAWSLambdaFunction_EmptyVpcConfig
=== CONT  TestAccAWSLambdaFunction_DeadLetterConfig
=== CONT  TestAccAWSLambdaFunction_runtimeValidation_NodeJs810
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_noRuntime (3.17s)
=== CONT  TestAccAWSLambdaFunction_VPCRemoval
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_python27 (61.50s)
=== CONT  TestAccAWSLambdaFunction_VPC
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_ruby25 (63.91s)
=== CONT  TestAccAWSLambdaFunction_LayersUpdate
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_provided (66.82s)
=== CONT  TestAccAWSLambdaFunction_Layers
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_NodeJs10x (68.36s)
=== CONT  TestAccAWSLambdaFunction_tracingConfig
--- PASS: TestAccAWSLambdaFunction_s3 (68.79s)
=== CONT  TestAccAWSLambdaFunction_nilDeadLetterConfig
--- PASS: TestAccAWSLambdaFunction_basic (71.38s)
=== CONT  TestAccAWSLambdaFunction_DeadLetterConfigUpdated
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_java8 (74.60s)
=== CONT  TestAccAWSLambdaFunction_envVariables
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_python36 (77.76s)
=== CONT  TestAccAWSLambdaFunction_versionedUpdate
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_NodeJs810 (79.99s)
=== CONT  TestAccAWSLambdaFunction_versioned
--- PASS: TestAccAWSLambdaFunction_localUpdate_nameOnly (80.05s)
=== CONT  TestAccAWSLambdaFunction_encryptedEnvVariables
--- PASS: TestAccAWSLambdaFunction_localUpdate (82.07s)
=== CONT  TestAccAWSLambdaFunction_updateRuntime
--- PASS: TestAccAWSLambdaFunction_EmptyVpcConfig (82.09s)
=== CONT  TestAccAWSLambdaFunction_expectFilenameAndS3Attributes
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_python37 (84.26s)
=== CONT  TestAccAWSLambdaFunction_concurrencyCycle
--- PASS: TestAccAWSLambdaFunction_nilDeadLetterConfig (43.36s)
=== CONT  TestAccAWSLambdaFunction_concurrency
--- PASS: TestAccAWSLambdaFunction_VPC_withInvocation (115.13s)
--- PASS: TestAccAWSLambdaFunction_s3Update_unversioned (116.32s)
--- PASS: TestAccAWSLambdaFunction_s3Update_basic (117.86s)
--- PASS: TestAccAWSLambdaFunction_DeadLetterConfig (121.36s)
--- PASS: TestAccAWSLambdaFunction_expectFilenameAndS3Attributes (44.21s)
--- PASS: TestAccAWSLambdaFunction_VPCRemoval (126.54s)
--- PASS: TestAccAWSLambdaFunction_Layers (69.89s)
--- PASS: TestAccAWSLambdaFunction_tags (136.86s)
--- PASS: TestAccAWSLambdaFunction_VPCUpdate (141.89s)
--- PASS: TestAccAWSLambdaFunction_VPC (82.04s)
--- PASS: TestAccAWSLambdaFunction_versioned (64.47s)
--- PASS: TestAccAWSLambdaFunction_tracingConfig (93.09s)
--- PASS: TestAccAWSLambdaFunction_DeadLetterConfigUpdated (93.40s)
--- PASS: TestAccAWSLambdaFunction_LayersUpdate (106.74s)
--- PASS: TestAccAWSLambdaFunction_versionedUpdate (98.29s)
--- PASS: TestAccAWSLambdaFunction_updateRuntime (99.69s)
--- PASS: TestAccAWSLambdaFunction_concurrency (93.47s)
--- PASS: TestAccAWSLambdaFunction_encryptedEnvVariables (130.68s)
--- PASS: TestAccAWSLambdaFunction_concurrencyCycle (129.96s)
--- PASS: TestAccAWSLambdaFunction_envVariables (161.68s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       237.276s

@ryndaniels ryndaniels requested a review from a team September 6, 2019 10:24
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. service/lambda Issues and PRs that pertain to the lambda service. service/rds Issues and PRs that pertain to the rds service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Sep 6, 2019
@ryndaniels ryndaniels changed the title <!--- See what makes a good Pull Request at : https://github.com/terraform-providers/terraform-provider-aws/blob/master/.github/CONTRIBUTING.md#pull-requests ---> Acceptance import test refactor for lambda Sep 6, 2019
@bflad
Copy link
Contributor

bflad commented Sep 24, 2019

Looks like this is errantly including c77b724 and has merge conflicts. 😅

@bflad bflad added the waiting-response Maintainers are waiting on response from community or contributor. label Sep 24, 2019
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. and removed size/XXL Managed by automation to categorize the size of a PR. labels Oct 4, 2019
@ghost
Copy link

ghost commented Oct 4, 2019

Hello, and thank you for your contribution!

This project recently migrated to the standalone Terraform Plugin SDK. While this will help speed up future feature requests and bug fixes with Terraform AWS Provider's interface with Terraform itself, it also has the unfortunate consequence of requiring some minor changes to pull requests created before the migration.

This pull request appears to include the Go import path "github.com/hashicorp/terraform/helper/acctest", which was from the older SDK. The newer SDK uses import paths beginning with github.com/hashicorp/terraform-plugin-sdk/.

To resolve this situation without losing any existing work, you may be able to Git rebase your branch against the current master branch (example below), then replacing any remaining old import paths with the newer ones.

$ git fetch --all
$ git rebase origin/master

Another option is to create a new branch from the current master with the same code changes (replacing the import paths), submit a new pull request, and close this existing pull request.

We apologize for this inconvenience and appreciate your effort. Thank you for contributing and helping make the Terraform AWS Provider better for everyone.

@ghost ghost added terraform-plugin-sdk-migration and removed waiting-response Maintainers are waiting on response from community or contributor. labels Oct 4, 2019
@ryndaniels ryndaniels force-pushed the rfd-at002-lambda branch 2 times, most recently from 73df30a to 6576dfd Compare October 7, 2019 10:18
bflad
bflad approved these changes Oct 8, 2019
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

--- PASS: TestAccAWSLambdaFunction_nilDeadLetterConfig (15.98s)
--- PASS: TestAccAWSLambdaFunction_expectFilenameAndS3Attributes (18.08s)
--- PASS: TestAccAWSLambdaFunction_basic (24.99s)
--- PASS: TestAccAWSLambdaFunction_versioned (37.12s)
--- PASS: TestAccAWSLambdaEventSourceMapping_sqs_withFunctionName (37.60s)
--- PASS: TestAccAWSLambdaFunction_updateRuntime (44.92s)
--- PASS: TestAccAWSLambdaFunction_DeadLetterConfigUpdated (44.88s)
--- PASS: TestAccAWSLambdaFunction_Layers (27.41s)
--- PASS: TestAccAWSLambdaFunction_DeadLetterConfig (46.25s)
--- PASS: TestAccAWSLambdaFunction_versionedUpdate (47.74s)
--- PASS: TestAccAWSLambdaFunction_concurrency (50.44s)
--- PASS: TestAccAWSLambdaFunction_concurrencyCycle (62.03s)
--- PASS: TestAccAWSLambdaFunction_tracingConfig (46.15s)
--- PASS: TestAccAWSLambdaEventSourceMapping_StartingPositionTimestamp (67.38s)
--- PASS: TestAccAWSLambdaEventSourceMapping_kinesis_disappears (67.56s)
--- PASS: TestAccAWSLambdaFunction_VPC (30.72s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_noRuntime (1.19s)
--- PASS: TestAccAWSLambdaFunction_encryptedEnvVariables (68.83s)
--- PASS: TestAccAWSLambdaFunction_LayersUpdate (45.00s)
--- PASS: TestAccAWSLambdaFunction_envVariables (71.49s)
--- PASS: TestAccAWSLambdaFunction_VPCRemoval (34.21s)
--- PASS: TestAccAWSLambdaEventSourceMapping_kinesis_removeBatchSize (77.33s)
--- PASS: TestAccAWSLambdaEventSourceMapping_kinesis_basic (78.61s)
--- PASS: TestAccAWSLambdaFunction_s3 (36.94s)
--- PASS: TestAccAWSLambdaFunction_VPCUpdate (42.66s)
--- PASS: TestAccAWSLambdaFunction_VpcConfig_ProperIamDependencies (44.32s)
--- PASS: TestAccAWSLambdaEventSourceMapping_sqs_basic (91.68s)
--- PASS: TestAccAWSLambdaFunction_localUpdate (41.30s)
--- PASS: TestAccAWSLambdaFunction_EmptyVpcConfig (48.12s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_NodeJs810 (29.83s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_NodeJs10x (30.51s)
--- PASS: TestAccAWSLambdaEventSourceMapping_changesInEnabledAreDetected (99.49s)
--- PASS: TestAccAWSLambdaFunction_localUpdate_nameOnly (38.67s)
--- PASS: TestAccAWSLambdaFunction_s3Update_basic (39.12s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_java8 (31.43s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_python27 (32.61s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_provided (30.98s)
--- PASS: TestAccAWSLambdaEventSourceMapping_sqsDisappears (104.75s)
--- PASS: TestAccAWSLambdaFunction_s3Update_unversioned (38.81s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_python37 (29.53s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_python36 (33.58s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_ruby25 (28.52s)
--- PASS: TestAccAWSLambdaFunction_tags (43.91s)
--- PASS: TestAccAWSLambdaFunction_VPC_withInvocation (71.03s)

@bflad bflad added this to the v2.32.0 milestone Oct 8, 2019
@ryndaniels ryndaniels merged commit 0f81f1b into master Oct 9, 2019
@ryndaniels ryndaniels deleted the rfd-at002-lambda branch October 9, 2019 11:11
@ghost
Copy link

ghost commented Oct 10, 2019

This has been released in version 2.32.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 8, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

@ryndaniels ryndaniels

Labels
service/lambda Issues and PRs that pertain to the lambda service. service/rds Issues and PRs that pertain to the rds service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.32.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ryndaniels @bflad