Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor import acceptance tests for s3 buckets #10001

Merged
merged 2 commits into from
Sep 6, 2019
Merged

Refactor import acceptance tests for s3 buckets #10001

merged 2 commits into from
Sep 6, 2019

Conversation

ryndaniels
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #8944

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make testacc TESTARGS="-run=TestAccAWSS3Bucket_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSS3Bucket_basic -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSS3Bucket_basic
=== PAUSE TestAccAWSS3Bucket_basic
=== CONT  TestAccAWSS3Bucket_basic
--- PASS: TestAccAWSS3Bucket_basic (83.57s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       84.468s

make testacc TESTARGS="-run=TestAccAWSS3Bucket_Bucket_EmptyString"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSS3Bucket_Bucket_EmptyString -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSS3Bucket_Bucket_EmptyString
=== PAUSE TestAccAWSS3Bucket_Bucket_EmptyString
=== CONT  TestAccAWSS3Bucket_Bucket_EmptyString
--- PASS: TestAccAWSS3Bucket_Bucket_EmptyString (104.71s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       105.599s

make testacc TESTARGS="-run=TestAccAWSS3Bucket_tagsWithNoSystemTags"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSS3Bucket_tagsWithNoSystemTags -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSS3Bucket_tagsWithNoSystemTags
=== PAUSE TestAccAWSS3Bucket_tagsWithNoSystemTags
=== CONT  TestAccAWSS3Bucket_tagsWithNoSystemTags
--- PASS: TestAccAWSS3Bucket_tagsWithNoSystemTags (224.45s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       225.560s

make testacc TESTARGS="-run=TestAccAWSS3Bucket_tagsWithSystemTags"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSS3Bucket_tagsWithSystemTags -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSS3Bucket_tagsWithSystemTags
=== PAUSE TestAccAWSS3Bucket_tagsWithSystemTags
=== CONT  TestAccAWSS3Bucket_tagsWithSystemTags
--- PASS: TestAccAWSS3Bucket_tagsWithSystemTags (250.10s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       250.993s

make testacc TESTARGS="-run=TestAccAWSS3MultiBucket_withTags"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSS3MultiBucket_withTags -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSS3MultiBucket_withTags
=== PAUSE TestAccAWSS3MultiBucket_withTags
=== CONT  TestAccAWSS3MultiBucket_withTags
--- PASS: TestAccAWSS3MultiBucket_withTags (101.61s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       102.481s

make testacc TESTARGS="-run=TestAccAWSS3Bucket_namePrefix"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSS3Bucket_namePrefix -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSS3Bucket_namePrefix
=== PAUSE TestAccAWSS3Bucket_namePrefix
=== CONT  TestAccAWSS3Bucket_namePrefix
--- PASS: TestAccAWSS3Bucket_namePrefix (77.05s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       78.767s

make testacc TESTARGS="-run=TestAccAWSS3Bucket_generatedName"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSS3Bucket_generatedName -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSS3Bucket_generatedName
=== PAUSE TestAccAWSS3Bucket_generatedName
=== CONT  TestAccAWSS3Bucket_generatedName
--- PASS: TestAccAWSS3Bucket_generatedName (65.00s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       66.419s

make testacc TESTARGS="-run=TestAccAWSS3Bucket_region"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSS3Bucket_region -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSS3Bucket_region
=== PAUSE TestAccAWSS3Bucket_region
=== CONT  TestAccAWSS3Bucket_region
--- PASS: TestAccAWSS3Bucket_region (90.75s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       91.832s

make testacc TESTARGS="-run=TestAccAWSS3Bucket_acceleration"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSS3Bucket_acceleration -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSS3Bucket_acceleration
=== PAUSE TestAccAWSS3Bucket_acceleration
=== CONT  TestAccAWSS3Bucket_acceleration
--- PASS: TestAccAWSS3Bucket_acceleration (113.64s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       114.637s

make testacc TESTARGS="-run=TestAccAWSS3Bucket_RequestPayer"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSS3Bucket_RequestPayer -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSS3Bucket_RequestPayer
=== PAUSE TestAccAWSS3Bucket_RequestPayer
=== CONT  TestAccAWSS3Bucket_RequestPayer
--- PASS: TestAccAWSS3Bucket_RequestPayer (131.02s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       132.191s

make testacc TESTARGS="-run=TestAccAWSS3Bucket_Policy"      
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSS3Bucket_Policy -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSS3Bucket_Policy
=== PAUSE TestAccAWSS3Bucket_Policy
=== CONT  TestAccAWSS3Bucket_Policy
--- PASS: TestAccAWSS3Bucket_Policy (178.87s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       179.757s

make testacc TESTARGS="-run=TestAccAWSS3Bucket_UpdateAcl"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSS3Bucket_UpdateAcl -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSS3Bucket_UpdateAcl
=== PAUSE TestAccAWSS3Bucket_UpdateAcl
=== CONT  TestAccAWSS3Bucket_UpdateAcl
--- PASS: TestAccAWSS3Bucket_UpdateAcl (159.25s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       160.292s

make testacc TESTARGS="-run=TestAccAWSS3Bucket_Website_Simple"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSS3Bucket_Website_Simple -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSS3Bucket_Website_Simple
=== PAUSE TestAccAWSS3Bucket_Website_Simple
=== CONT  TestAccAWSS3Bucket_Website_Simple
--- PASS: TestAccAWSS3Bucket_Website_Simple (162.09s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       162.995s

make testacc TESTARGS="-run=TestAccAWSS3Bucket_WebsiteRedirect"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSS3Bucket_WebsiteRedirect -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSS3Bucket_WebsiteRedirect
=== PAUSE TestAccAWSS3Bucket_WebsiteRedirect
=== CONT  TestAccAWSS3Bucket_WebsiteRedirect
--- PASS: TestAccAWSS3Bucket_WebsiteRedirect (175.14s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       176.128s

make testacc TESTARGS="-run=TestAccAWSS3Bucket_WebsiteRoutingRules"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSS3Bucket_WebsiteRoutingRules -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSS3Bucket_WebsiteRoutingRules
=== PAUSE TestAccAWSS3Bucket_WebsiteRoutingRules
=== CONT  TestAccAWSS3Bucket_WebsiteRoutingRules
--- PASS: TestAccAWSS3Bucket_WebsiteRoutingRules (118.79s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       119.883s

make testacc TESTARGS="-run=TestAccAWSS3Bucket_enableDefaultEncryption_whenTypical"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSS3Bucket_enableDefaultEncryption_whenTypical -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSS3Bucket_enableDefaultEncryption_whenTypical
=== PAUSE TestAccAWSS3Bucket_enableDefaultEncryption_whenTypical
=== CONT  TestAccAWSS3Bucket_enableDefaultEncryption_whenTypical
--- PASS: TestAccAWSS3Bucket_enableDefaultEncryption_whenTypical (110.86s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       112.060s

make testacc TESTARGS="-run=TestAccAWSS3Bucket_enableDefaultEncryption_whenAES256IsUsed"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSS3Bucket_enableDefaultEncryption_whenAES256IsUsed -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSS3Bucket_enableDefaultEncryption_whenAES256IsUsed
=== PAUSE TestAccAWSS3Bucket_enableDefaultEncryption_whenAES256IsUsed
=== CONT  TestAccAWSS3Bucket_enableDefaultEncryption_whenAES256IsUsed
--- PASS: TestAccAWSS3Bucket_enableDefaultEncryption_whenAES256IsUsed (67.06s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       67.959s

make testacc TESTARGS="-run=TestAccAWSS3Bucket_disableDefaultEncryption_whenDefaultEncryptionIsEnabled"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSS3Bucket_disableDefaultEncryption_whenDefaultEncryptionIsEnabled -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSS3Bucket_disableDefaultEncryption_whenDefaultEncryptionIsEnabled
=== PAUSE TestAccAWSS3Bucket_disableDefaultEncryption_whenDefaultEncryptionIsEnabled
=== CONT  TestAccAWSS3Bucket_disableDefaultEncryption_whenDefaultEncryptionIsEnabled
--- PASS: TestAccAWSS3Bucket_disableDefaultEncryption_whenDefaultEncryptionIsEnabled (163.96s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       165.019s

make testacc TESTARGS="-run=TestAccAWSS3Bucket_shouldFailNotFound"              ==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSS3Bucket_shouldFailNotFound -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSS3Bucket_shouldFailNotFound
=== PAUSE TestAccAWSS3Bucket_shouldFailNotFound
=== CONT  TestAccAWSS3Bucket_shouldFailNotFound
--- PASS: TestAccAWSS3Bucket_shouldFailNotFound (30.11s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       30.973s

make testacc TESTARGS="-run=TestAccAWSS3Bucket_Cors_Delete" 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSS3Bucket_Cors_Delete -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSS3Bucket_Cors_Delete
=== PAUSE TestAccAWSS3Bucket_Cors_Delete
=== CONT  TestAccAWSS3Bucket_Cors_Delete
--- PASS: TestAccAWSS3Bucket_Cors_Delete (57.02s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       57.928s

make testacc TESTARGS="-run=TestAccAWSS3Bucket_Cors_EmptyOrigin"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSS3Bucket_Cors_EmptyOrigin -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSS3Bucket_Cors_EmptyOrigin
=== PAUSE TestAccAWSS3Bucket_Cors_EmptyOrigin
=== CONT  TestAccAWSS3Bucket_Cors_EmptyOrigin
--- PASS: TestAccAWSS3Bucket_Cors_EmptyOrigin (66.04s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       66.925s

make testacc TESTARGS="-run=TestAccAWSS3Bucket_Logging"         
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSS3Bucket_Logging -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSS3Bucket_Logging
=== PAUSE TestAccAWSS3Bucket_Logging
=== CONT  TestAccAWSS3Bucket_Logging
--- PASS: TestAccAWSS3Bucket_Logging (109.41s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       110.454s

make testacc TESTARGS="-run=TestAccAWSS3Bucket_LifecycleBasic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSS3Bucket_LifecycleBasic -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSS3Bucket_LifecycleBasic
=== PAUSE TestAccAWSS3Bucket_LifecycleBasic
=== CONT  TestAccAWSS3Bucket_LifecycleBasic
--- PASS: TestAccAWSS3Bucket_LifecycleBasic (163.09s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       164.313s

 make testacc TESTARGS="-run=TestAccAWSS3Bucket_LifecycleExpireMarkerOnly"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSS3Bucket_LifecycleExpireMarkerOnly -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSS3Bucket_LifecycleExpireMarkerOnly
=== PAUSE TestAccAWSS3Bucket_LifecycleExpireMarkerOnly
=== CONT  TestAccAWSS3Bucket_LifecycleExpireMarkerOnly
--- PASS: TestAccAWSS3Bucket_LifecycleExpireMarkerOnly (152.61s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       153.446s

make testacc TESTARGS="-run=TestAccAWSS3Bucket_objectLock"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSS3Bucket_objectLock -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSS3Bucket_objectLock
=== PAUSE TestAccAWSS3Bucket_objectLock
=== CONT  TestAccAWSS3Bucket_objectLock
--- PASS: TestAccAWSS3Bucket_objectLock (111.82s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       112.799s

--- PASS: TestAccAWSS3Bucket_Versioning (43.68s)
--- PASS: TestAccAWSS3Bucket_Cors_Update (35.67s)
--- PASS: TestAccAWSS3Bucket_ReplicationExpectVersioningValidationError (38.53s)
--- PASS: TestAccAWSS3Bucket_ReplicationWithoutPrefix (50.25s)
--- PASS: TestAccAWSS3Bucket_Replication (173.16s)
--- PASS: TestAccAWSS3Bucket_ReplicationWithoutStorageClass (53.19s)
--- PASS: TestAccAWSS3Bucket_ReplicationConfiguration_Rule_Destination_AccessControlTranslation (111.68s)
--- PASS: TestAccAWSS3Bucket_ReplicationSchemaV2 (149.57s)

@ryndaniels ryndaniels requested a review from a team September 5, 2019 08:47
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. service/s3 Issues and PRs that pertain to the s3 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Sep 5, 2019
@ryndaniels ryndaniels changed the title <!--- See what makes a good Pull Request at : https://github.com/terraform-providers/terraform-provider-aws/blob/master/.github/CONTRIBUTING.md#pull-requests ---> Refactor import acceptance tests for s3 buckets Sep 5, 2019
bflad
bflad approved these changes Sep 5, 2019
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

--- PASS: TestAccAWSS3BucketObject_noNameNoKey (5.73s)
--- PASS: TestAccAWSS3BucketObject_content (13.00s)
--- PASS: TestAccAWSS3BucketObject_empty (19.28s)
--- PASS: TestAccAWSS3BucketMetric_WithEmptyFilter (19.63s)
--- PASS: TestAccAWSS3BucketObject_source (19.69s)
--- PASS: TestAccAWSS3BucketMetric_basic (20.00s)
--- PASS: TestAccAWSS3BucketInventory_encryptWithSSES3 (22.13s)
--- PASS: TestAccAWSS3BucketInventory_basic (22.71s)
--- PASS: TestAccAWSS3BucketObject_etagEncryption (16.79s)
--- PASS: TestAccAWSS3BucketNotification_Queue (22.63s)
--- PASS: TestAccAWSS3BucketNotification_Topic (23.51s)
--- PASS: TestAccAWSS3BucketNotification_Topic_Multiple (24.79s)
--- PASS: TestAccAWSS3BucketMetric_WithFilterSingleTag (30.90s)
--- PASS: TestAccAWSS3BucketObject_contentBase64 (18.36s)
--- PASS: TestAccAWSS3BucketMetric_WithFilterPrefix (31.87s)
--- PASS: TestAccAWSS3BucketMetric_WithFilterMultipleTags (31.88s)
--- PASS: TestAccAWSS3BucketMetric_WithFilterPrefixAndSingleTag (32.21s)
--- PASS: TestAccAWSS3BucketMetric_WithFilterPrefixAndMultipleTags (33.35s)
--- PASS: TestAccAWSS3BucketNotification_update (36.45s)
--- PASS: TestAccAWSS3BucketObject_withContentCharacteristics (18.27s)
--- PASS: TestAccAWSS3BucketNotification_LambdaFunction_LambdaFunctionArn_Alias (38.26s)
--- PASS: TestAccAWSS3BucketNotification_LambdaFunction (39.11s)
--- PASS: TestAccAWSS3BucketInventory_encryptWithSSEKMS (40.90s)
--- PASS: TestAccAWSS3BucketObject_sse (18.55s)
--- PASS: TestAccAWSS3BucketObject_updates (29.20s)
--- PASS: TestAccAWSS3BucketPublicAccessBlock_disappears (18.99s)
--- PASS: TestAccAWSS3BucketObject_updateSameFile (31.75s)
--- PASS: TestAccAWSS3BucketObject_updatesWithVersioning (31.51s)
--- PASS: TestAccAWSS3BucketPolicy_basic (22.78s)
--- PASS: TestAccAWSS3BucketPublicAccessBlock_basic (23.07s)
--- PASS: TestAccAWSS3Bucket_basic (18.66s)
--- PASS: TestAccAWSS3BucketObject_kms (37.55s)
--- PASS: TestAccAWSS3BucketObject_metadata (39.95s)
--- PASS: TestAccAWSS3Bucket_Bucket_EmptyString (22.56s)
--- PASS: TestAccAWSS3BucketObject_acl (42.79s)
--- PASS: TestAccAWSS3BucketPolicy_policyUpdate (35.06s)
--- PASS: TestAccAWSS3Bucket_namePrefix (20.76s)
--- PASS: TestAccAWSS3Bucket_generatedName (21.06s)
--- PASS: TestAccAWSS3MultiBucket_withTags (25.18s)
--- PASS: TestAccAWSS3BucketObject_tags (51.66s)
--- PASS: TestAccAWSS3BucketPublicAccessBlock_BlockPublicAcls (47.84s)
--- PASS: TestAccAWSS3BucketPublicAccessBlock_IgnorePublicAcls (44.32s)
--- PASS: TestAccAWSS3BucketPublicAccessBlock_BlockPublicPolicy (45.56s)
--- PASS: TestAccAWSS3BucketPublicAccessBlock_RestrictPublicBuckets (44.80s)
--- PASS: TestAccAWSS3BucketObject_tagsLeadingSlash (52.64s)
--- PASS: TestAccAWSS3BucketObject_storageClass (62.92s)
--- PASS: TestAccAWSS3Bucket_acceleration (31.60s)
--- PASS: TestAccAWSS3Bucket_RequestPayer (33.82s)
--- PASS: TestAccAWSS3Bucket_shouldFailNotFound (16.24s)
--- PASS: TestAccAWSS3Bucket_enableDefaultEncryption_whenAES256IsUsed (20.72s)
--- PASS: TestAccAWSS3Bucket_UpdateAcl (31.92s)
--- PASS: TestAccAWSS3Bucket_tagsWithNoSystemTags (54.60s)
--- PASS: TestAccAWSS3Bucket_WebsiteRoutingRules (29.88s)
--- PASS: TestAccAWSS3Bucket_Cors_Delete (17.63s)
--- PASS: TestAccAWSS3Bucket_Policy (42.46s)
--- PASS: TestAWSS3BucketName (0.00s)
--- PASS: TestBucketRegionalDomainName (0.00s)
--- PASS: TestAccAWSS3Bucket_region (50.79s)
--- PASS: TestAccAWSS3Bucket_Cors_EmptyOrigin (22.10s)
--- PASS: TestAccAWSS3Bucket_WebsiteRedirect (41.04s)
--- PASS: TestAccAWSS3Bucket_Logging (24.06s)
--- PASS: TestAccAWSS3Bucket_disableDefaultEncryption_whenDefaultEncryptionIsEnabled (30.98s)
--- PASS: TestAccAWSS3Bucket_Website_Simple (44.42s)
--- PASS: TestAccAWSS3Bucket_Cors_Update (28.83s)
--- PASS: TestAccAWSS3Bucket_enableDefaultEncryption_whenTypical (39.28s)
--- PASS: TestAccAWSS3Bucket_Versioning (34.38s)
--- PASS: TestAccAWSS3Bucket_objectLock (20.43s)
--- PASS: TestAccAWSS3Bucket_ReplicationExpectVersioningValidationError (38.05s)
--- PASS: TestAccAWSS3Bucket_tagsWithSystemTags (86.59s)
--- PASS: TestAccAWSS3Bucket_ReplicationWithoutStorageClass (56.79s)
--- PASS: TestAccAWSS3Bucket_ReplicationWithoutPrefix (56.83s)
--- PASS: TestAccAWSS3Bucket_ReplicationConfiguration_Rule_Destination_AccessControlTranslation (120.25s)
--- PASS: TestAccAWSS3Bucket_ReplicationSchemaV2 (152.43s)

@ryndaniels ryndaniels merged commit 7a02673 into master Sep 6, 2019
@ryndaniels ryndaniels deleted the rfd-at002-s3 branch September 6, 2019 09:21
@ryndaniels ryndaniels added this to the v2.28.0 milestone Sep 6, 2019
@ghost
Copy link

ghost commented Sep 12, 2019

This has been released in version 2.28.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 1, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

Labels
service/s3 Issues and PRs that pertain to the s3 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.28.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ryndaniels @bflad