-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
intermittent route table creation that has no ID #7644
Comments
The typical route table creation steps involve making an ec2/CreateRouteTable request, an ec2/DescribeRouteTables request, some other requests to update the route table, followed by a final ec2.DescribeRouteTables request. If the response to the final ec2/DescribeRouteTables request is InvalidRouteTableID.NotFound, then the ID of the route table resource is cleared so that the route table resource is not retained. However, the creation is still considered a success. This results in either (1) failures from other resources that depend upon the route table resource or (2) a report of a successful apply even though one of the resources needed does not actually exist. These changes adjust the result of the creation in the case where the route table cannot be found on the final ec2/DescribeRouteTables request. Instead of reporting success for the creation, report failure. Fixes hashicorp#7644
The typical route table creation steps involve making an ec2/CreateRouteTable request, an ec2/DescribeRouteTables request, some other requests to update the route table, followed by a final ec2.DescribeRouteTables request. If the response to the final ec2/DescribeRouteTables request is InvalidRouteTableID.NotFound, then the ID of the route table resource is cleared so that the route table resource is not retained. However, the creation is still considered a success. This results in either (1) failures from other resources that depend upon the route table resource or (2) a report of a successful apply even though one of the resources needed does not actually exist. These changes adjust the result of the creation in the case where the route table cannot be found on the final ec2/DescribeRouteTables request. Instead of reporting success for the creation, report failure. Fixes hashicorp#7644
This has been released in version 3.35.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Community Note
Terraform Version
terraform: v0.11.10
terraform-provider-aws: v1.29.0
Affected Resource(s)
Terraform Configuration Files
Debug Output
https://gist.github.com/staebler/612476a267f426aa89bdc86c525db614
Panic Output
Expected Behavior
Either the creation of the route table is successful and the route table has an ID. Or the creation of the route table is unsuccessful.
Actual Behavior
The creation of the route table is successful but the route table has no ID. This causes subsequent resources that depend upon the route table to fail.
Steps to Reproduce
terraform apply
Important Factoids
References
The text was updated successfully, but these errors were encountered: