Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_ssm_resource_data_sync - doesn't support update #7351

Closed
egirard78 opened this issue Jan 28, 2019 · 5 comments · Fixed by #7490
Closed

aws_ssm_resource_data_sync - doesn't support update #7351

egirard78 opened this issue Jan 28, 2019 · 5 comments · Fixed by #7490
Labels
bug Addresses a defect in current functionality. service/ssm Issues and PRs that pertain to the ssm service.
Milestone

Comments

@egirard78
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform Version

Terraform version: 0.11.10
AWS provider: 1.57.0

Affected Resource(s)

  • aws_ssm_resource_data_sync

Terraform Configuration Files

provider "aws" {
  region      = "eu-west-1"
  profile     = "MyAWSProfile"
}

resource "aws_ssm_resource_data_sync" "data_sync" {
  name = "SSM-Sync-NewName"
  s3_destination = {
    bucket_name = "MySSMBucket"
    prefix      = "Inventory"
    region      = "eu-west-1"
  }
}

Debug Output

Debug output related to the issue: aws_ssm_resource_data_sync - Debug log.

Panic Output

None.

Expected Behavior

Recreate the aws_ssm_resource_data_sync when changing the S3 configuration of this resource.

Actual Behavior

The following error message:

aws_ssm_resource_data_sync.data_sync: doesn't support update

Steps to Reproduce

  1. terraform apply

Important Factoids

None.

References

None.

  • #0000
@bflad bflad added service/ssm Issues and PRs that pertain to the ssm service. bug Addresses a defect in current functionality. labels Jan 29, 2019
@bflad
Copy link
Contributor

bflad commented Jan 30, 2019

Hi @egirard78 👋 Thanks for reporting this issue and sorry for the unexpected behavior! This is certainly an implementation bug with the resource's schema definition. Each of the attributes under the s3_destination attribute should also be marked as ForceNew: true as both the SSM service and subsequently the Terraform resource do not support updating this resource.

Normally this should be caught by the Terraform schema validation that occurs when starting the provider, but it appears we have some missing validation for situations involving children attributes like these. I'll take a note of this case here so we can get that validation added and prevent this issue in the future for all Terraform resources.

As a workaround to the current situation, you can use terraform taint to manually trigger resource recreation with Terraform, e.g.

$ terraform taint aws_ssm_resource_data_sync.data_sync

@bflad
Copy link
Contributor

bflad commented Feb 12, 2019

The fix for having the resource automatically trigger resource updates when attributes inside the s3_destination configuration block are updated has been merged and will release with version 1.59.0 of the Terraform AWS Provider, likely middle of this week. 👍

@bflad
Copy link
Contributor

bflad commented Feb 14, 2019

This has been released in version 1.59.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@egirard78
Copy link
Author

I confirm the issue is fixed in the 1.59 release. Thanks a lot!!

@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/ssm Issues and PRs that pertain to the ssm service.
Projects
None yet
2 participants