data_source/aws_ecr_lifecycle_policy_document: adding new data source for ECR

[slapula]

Closes #6212

In the spirit of aws_iam_policy_document, I tried my hand at doing the same thing for ECR lifecycle policy documents.

Changes proposed in this pull request:

• Adds aws_ecr_lifecycle_policy_document data source

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSDataSourceEcrLifecyclePolicyDocument_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -run=TestAccAWSDataSourceEcrLifecyclePolicyDocument_basic -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSDataSourceEcrLifecyclePolicyDocument_basic
--- PASS: TestAccAWSDataSourceEcrLifecyclePolicyDocument_basic (10.88s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	10.904s

[bflad]

Adding reference to #6212

[bflad]

I don't have time right now to give a full review of this PR, but it definitely seems like something we will be interested in implementing. 👍

[bflad]

Hi @slapula 👋 Thanks for submitting this! Overall, I think this is off to a good start and this will make assembling these policies much easier (even if we don't support merging these day one)!

I left some initial feedback below. Please let us know if you have any questions or do not have time to implement these items. 😄

[bflad]

It would be nice to see additional testing that covers:

• Setting other attributes or omitting optional attributes
• Multiple rules

[slapula]

I just added a couple more tests: one that omits an optional attribute (descriptions) and one that generates a two rule policy.

[bflad]

Example B of Filtering All Images uses hour as a count unit: https://docs.aws.amazon.com/AmazonECR/latest/userguide/lifecycle_policy_examples.html#lp_example_allimages

        {
            "rulePriority": 2,
            "description": "Rule 2",
            "selection": {
                "tagStatus": "untagged",
                "countType": "sinceImagePushed",
                "countUnit": "hours",
                "countNumber": 1
            },
            "action": {
                "type": "expire"
            }
        },

[bflad]

Same here -- just please let us know if you don't have time to work on addressing the feedback.

[jufemaiz]

This looks great! What's the likelihood of it being merged?

[sdouche]

Hi. This data source is useful to remove a lot of lines in ECR definitions.

[jufemaiz]

Merge conflicts :sadpand:

[nomeelnoj]

Any update on this? This would also really help us.

[TechIsCool]

Would really be nice to not have to use JSON to handle these when implementing modules.

[teamterraform]

Notification of Recent and Upcoming Changes to Contributions

Thank you for this contribution! There have been a few recent development changes that affect this pull request. We apologize for the inconvenience, especially if there have been long review delays up until now. Please note that this is automated message from an unmonitored account. See the FAQ for additional information on the maintainer team and review prioritization.

If you are unable to complete these updates, please leave a comment for the community and maintainers so someone can potentially continue the work. The maintainers will encourage other contributors to use the existing contribution as the base for additional changes as appropriate. Otherwise, contributions that do not receive updated code or comments from the original contributor may be closed in the future so the maintainers can focus on active items.

For the most up to date information about Terraform AWS Provider development, see the Contributing Guide. Additional technical debt changes can be tracked with the technical-debt label on issues.

As part of updating a pull request with these changes, the most current unit testing and linting will run. These may report issues that were not previously reported.

Action Required: Terraform 0.12 Syntax

Reference: #8950
Reference: #14417

Version 3 and later of the Terraform AWS Provider, which all existing contributions would potentially be added, only supports Terraform 0.12 and later. Certain syntax elements of Terraform 0.11 and earlier show deprecation warnings during runs with Terraform 0.12. Documentation and test configurations, such as those including deprecated string interpolations (some_attribute = "${aws_service_thing.example.id}") should be updated to the newer syntax (some_attribute = aws_service_thing.example.id). Contribution testing will automatically fail on older syntax in the near future. Please see the referenced issues for additional information.

Action Required: Terraform Plugin SDK Version 2

Reference: #14551

The Terraform AWS Provider has been upgraded to the latest version of the Terraform Plugin SDK. Generally, most changes to contributions should only involve updating Go import paths in source code files. Please see the referenced issue for additional information.

Action Required: Removal of website/aws.erb File

Reference: #14712

Any changes to the website/aws.erb file are no longer necessary and should be removed from this contribution to prevent merge issues in the near future when the file is removed from the repository. Please see the referenced issue for additional information.

Upcoming Change of Git Branch Naming

Reference: #14292

Development environments will need their upstream Git branch updated from master to main in the near future. Please see the referenced issue for additional information and scheduling.

Upcoming Change of GitHub Organization

Reference: #14715

This repository will be migrating from https://github.com/terraform-providers/terraform-provider-aws to https://github.com/hashicorp/terraform-provider-aws. No practitioner or developer action is anticipated and most GitHub functionality will automatically redirect to the new location. Go import paths including terraform-providers can remain for now. Please see the referenced issue for additional information and scheduling.

[duncanwraight]

I appreciate it's a small part of Terraform but I'd imagine most organisations will want to use this with ECR... and most organisations using AWS Terraform will likely need ECR!

Could this please be merged?

[c-ameron]

Hello, any update on this? Thanks :)

[zhelding]

Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding.

Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single aws directory to a large number of separate directories in internal/service, each corresponding to a particular AWS service. This separation of code has also allowed for us to simplify the names of underlying functions -- while still avoiding namespace collisions.

We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author.

For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000.

For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide.

[Luis-3M]

This is powerful - managing it via a JSON is a mess and very error-prone.
When are we aiming to release it ?

[ewbankkit]

@slapula Thanks for the contribution 🎉 👏.
This work has been rolled into #36493.

[slapula]

wow I forgot this was still open! Thanks for bringing this across the finish line @ewbankkit

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.