Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: support tag patterns in aws_ecr_lifecycle_policy_document #36981

Closed
blowfishpro opened this issue Apr 18, 2024 · 4 comments · Fixed by #37014
Closed

[Enhancement]: support tag patterns in aws_ecr_lifecycle_policy_document #36981

blowfishpro opened this issue Apr 18, 2024 · 4 comments · Fixed by #37014
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ecr Issues and PRs that pertain to the ecr service.
Milestone

Comments

@blowfishpro
Copy link

blowfishpro commented Apr 18, 2024

Description

AWS added support for tag patterns with wildcards in addition to tag prefixes in ECR lifecycle policies in December. The data source aws_ecr_lifecycle_policy_document was added in version 5.44.0 (#6133) but does not currently support tag patterns.

This feature request is to add a tag_pattern_list parameter to the selection block alongside tag_prefix_list which takes a list of strings.

Affected Resource(s) and/or Data Source(s)

  • data-source/aws_ecr_lifecycle_policy_document

Potential Terraform Configuration

data "aws_ecr_lifecycle_policy_document" "example" {
  rule {
    priority    = 1
    description = "This is a test."

    selection {
      tag_status       = "tagged"
      tag_pattern_list = ["example_*_test"]
      count_type       = "imageCountMoreThan"
      count_number     = 100
    }
  }
}

References

Would you like to implement a fix?

None

@blowfishpro blowfishpro added the enhancement Requests to existing resources that expand the functionality or scope. label Apr 18, 2024
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/ecr Issues and PRs that pertain to the ecr service. label Apr 18, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Apr 18, 2024
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Apr 26, 2024
Copy link

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.48.0 milestone Apr 26, 2024
Copy link

github-actions bot commented May 2, 2024

This functionality has been released in v5.48.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Jun 2, 2024

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ecr Issues and PRs that pertain to the ecr service.
Projects
None yet
2 participants