Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data Source Route 53 Zone has attribute name_servers #4334

Closed
genevieve opened this issue Apr 24, 2018 · 4 comments · Fixed by #4336
Closed

Data Source Route 53 Zone has attribute name_servers #4334

genevieve opened this issue Apr 24, 2018 · 4 comments · Fixed by #4336
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/route53 Issues and PRs that pertain to the route53 service.
Milestone
v1.17.0

Comments

@genevieve
Copy link
Contributor

genevieve commented Apr 24, 2018 •
edited
Loading

Hey y'all, would you accept a PR to return the name servers from the delegation set that is returned for a found route53 hosted zone?

This request returns a delegation set for a hosted zone and that delegation set contains the name servers.

We would like to be able to get an existing hosted zone, add records to it, and continue to have the name servers as an output.
@catsby
Copy link
Contributor

catsby commented Apr 24, 2018

Seems totally reasonable 👍 , I believe we'd accept that for sure

@catsby catsby added enhancement Requests to existing resources that expand the functionality or scope. service/route53 Issues and PRs that pertain to the route53 service. labels Apr 24, 2018
cwlbraa added a commit to genevieve/terraform-provider-aws that referenced this issue Apr 24, 2018
@cwlbraa
data route53 dns zone has name_servers attribute.
7d5cde1 
Fixes hashicorp#4334.

Signed-off-by: Genevieve LEsperance <[email protected]>
@genevieve genevieve mentioned this issue Apr 24, 2018
Merged
@bflad bflad added this to the v1.17.0 milestone Apr 25, 2018
@bflad
Copy link
Contributor

bflad commented Apr 25, 2018

The additional attribute will be released in v1.17.0 of the AWS provider, likely in a week. 👍

@bflad
Copy link
Contributor

bflad commented May 2, 2018

This has been released in version 1.17.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 6, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/route53 Issues and PRs that pertain to the route53 service.
Projects
None yet
Milestone
v1.17.0
Development

Successfully merging a pull request may close this issue.

Data Source Route 53 Zone has attribute name_servers genevieve/terraform-provider-aws
3 participants
@catsby @bflad @genevieve