-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate Provider Context For Cancelling Requests #4177
Comments
Terraform Plugin SDK version 2 introduces CRUD functions (e.g. |
One potential risk to threading the resource context through to all functionality is ensuring that the default resource timeouts (20 minutes) do not interfere with the provider-level |
The risk mentioned above is now mitigated with Will add internal/keyvaluetags: Generate Context-Aware Functions to the description. |
Marking this issue as stale due to inactivity. This helps our maintainers find and focus on the active issues. If this issue receives no comments in the next 30 days it will automatically be closed. Maintainers can also remove the stale label. If this issue was automatically closed and you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thank you! |
Closed by #29005. |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
In order to properly cancel a Terraform command, we need to reference the provider context to any AWS Go SDK calls and separately any Terraform Plugin SDK retry loops. In Terraform Plugin SDK version 2, the provider context is available via new CRUD function signatures (e.g.
CreateContext
) (#15090) which will be the starting point for any implementation.Then when its available to the resources:
resource.RetryContext()
/WaitForStateContext()
should be done as part of this effort or not. Likely separately as it can have its own set of linters.context.Context
to any necessary downstream functions (if not a resource function) that call the AWS Go SDK (andresource.Retry()
/StateChangeConf
if necessary) -- this also includes generating context-awarekeyvaluetags
functionalityWithContext
variant and pass through the available resourcecontext.Context
to themThe text was updated successfully, but these errors were encountered: