Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

route 53 changes detected even though there are no changes #361

Closed
hashibot opened this issue Jun 13, 2017 · 5 comments · Fixed by #3119
Closed

route 53 changes detected even though there are no changes #361

hashibot opened this issue Jun 13, 2017 · 5 comments · Fixed by #3119
Labels
bug Addresses a defect in current functionality. service/route53 Issues and PRs that pertain to the route53 service.
Milestone
v1.8.0

Comments

@hashibot
Copy link

hashibot commented Jun 13, 2017 •
edited by radeksimko
Loading

This issue was originally opened by @tomstachura as hashicorp/terraform#10007. It was migrated here as part of the provider split. The original body of the issue is below.

I submitted a similar problem report with the previous version and I think some of it was supposed to be solved, but I am still getting the following differences with the 7.7.10 version.

The environment has just been created with apply and a plan has been run right after. It should be showing no changes, but it shows all the following:

~ module.tst1.aws_route53_record.r53_record
    alias.2190465367.evaluate_target_health: "true" => "false"
    alias.2190465367.name:                   "prod-web-1529429951.us-west-2.elb.amazonaws.com" => ""
    alias.2190465367.zone_id:                "Z1H1FL5HABSF5" => ""
    alias.2700809793.evaluate_target_health: "" => "true"
    alias.2700809793.name:                   "" => "PROD-WEB-1529429951.us-west-2.elb.amazonaws.com"
    alias.2700809793.zone_id:                "" => "Z1H1FL5HABSF5"

~ module.tst1.aws_security_group.admin
    ingress.#:                            "3" => "1"
    ingress.1938540428.cidr_blocks.#:     "1" => "0"
    ingress.1938540428.cidr_blocks.0:     "199.58.192.98/32" => ""
    ingress.1938540428.from_port:         "8091" => "0"
    ingress.1938540428.protocol:          "tcp" => ""
    ingress.1938540428.security_groups.#: "0" => "0"
    ingress.1938540428.self:              "false" => "false"
    ingress.1938540428.to_port:           "8091" => "0"
    ingress.3897505941.cidr_blocks.#:     "3" => "0"
    ingress.3897505941.cidr_blocks.0:     "199.58.192.98/32" => ""
    ingress.3897505941.cidr_blocks.1:     "35.160.166.68/32" => ""
    ingress.3897505941.cidr_blocks.2:     "35.161.227.236/32" => ""
    ingress.3897505941.from_port:         "22" => "0"
    ingress.3897505941.protocol:          "tcp" => ""
    ingress.3897505941.security_groups.#: "0" => "0"
    ingress.3897505941.self:              "false" => "false"
    ingress.3897505941.to_port:           "22" => "0"
    ingress.4282511762.cidr_blocks.#:     "1" => "1"
    ingress.4282511762.cidr_blocks.0:     "10.5.101.236/32" => "10.5.101.236/32"
    ingress.4282511762.from_port:         "22" => "22"
    ingress.4282511762.protocol:          "tcp" => "tcp"
    ingress.4282511762.security_groups.#: "0" => "0"
    ingress.4282511762.self:              "false" => "false"
    ingress.4282511762.to_port:           "22" => "22"

~ module.tst1.lb_id.aws_route53_record.r53_record
    alias.1412314257.evaluate_target_health: "true" => "false"
    alias.1412314257.name:                   "prod-id-1538439218.us-west-2.elb.amazonaws.com" => ""
    alias.1412314257.zone_id:                "Z1H1FL5HABSF5" => ""
    alias.1713183629.evaluate_target_health: "" => "true"
    alias.1713183629.name:                   "" => "PROD-ID-1538439218.us-west-2.elb.amazonaws.com"
    alias.1713183629.zone_id:                "" => "Z1H1FL5HABSF5"

~ module.tst1.lb_solr.aws_route53_record.r53_record
    alias.1351171064.evaluate_target_health: "" => "true"
    alias.1351171064.name:                   "" => "internal-PROD-SOLR-236462827.us-west-2.elb.amazonaws.com"
    alias.1351171064.zone_id:                "" => "Z1H1FL5HABSF5"
    alias.907506756.evaluate_target_health:  "true" => "false"
    alias.907506756.name:                    "internal-prod-solr-236462827.us-west-2.elb.amazonaws.com" => ""
    alias.907506756.zone_id:                 "Z1H1FL5HABSF5" => ""

~ module.tst1.lb_ui.aws_route53_record.r53_record
    alias.2037855967.evaluate_target_health: "" => "true"
    alias.2037855967.name:                   "" => "PROD-UI-85055216.us-west-2.elb.amazonaws.com"
    alias.2037855967.zone_id:                "" => "Z1H1FL5HABSF5"
    alias.884876570.evaluate_target_health:  "true" => "false"
    alias.884876570.name:                    "prod-ui-85055216.us-west-2.elb.amazonaws.com" => ""
    alias.884876570.zone_id:                 "Z1H1FL5HABSF5" => ""

~ module.tst1.lb_web.aws_route53_record.r53_record
    alias.2190465367.evaluate_target_health: "true" => "false"
    alias.2190465367.name:                   "prod-web-1529429951.us-west-2.elb.amazonaws.com" => ""
    alias.2190465367.zone_id:                "Z1H1FL5HABSF5" => ""
    alias.2700809793.evaluate_target_health: "" => "true"
    alias.2700809793.name:                   "" => "PROD-WEB-1529429951.us-west-2.elb.amazonaws.com"
    alias.2700809793.zone_id:                "" => "Z1H1FL5HABSF5"
@hashibot hashibot added the bug Addresses a defect in current functionality. label Jun 13, 2017
@Jonnymcc
Copy link
Contributor

Still happens in Terraform v0.11.2 + provider.aws v1.7.1

@bflad bflad added the service/route53 Issues and PRs that pertain to the route53 service. label Jan 23, 2018
@bflad
Copy link
Contributor

bflad commented Jan 24, 2018

I have submitted a PR to hopefully address this for uppercase named ALB/ELB DNS alias: #3119

@bflad bflad mentioned this issue Jan 24, 2018
Merged
@bflad bflad added this to the v1.8.0 milestone Jan 25, 2018
@bflad
Copy link
Contributor

bflad commented Jan 25, 2018

The fix for this has been merged into master and will be released in v1.8.0 of the provider, expected tomorrow! 🎉

@bflad
Copy link
Contributor

bflad commented Jan 29, 2018

This has been released in terraform-provider-aws version 1.8.0. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

henrytk added a commit to alphagov/paas-docker-cloudfoundry-tools that referenced this issue Aug 30, 2018
@henrytk
Upgrade Terraform AWS provider
262aaae 
This is the minimum upgrade required to fix an issue we are having with
DNS entries flapping[1].

[1] hashicorp/terraform-provider-aws#361
@henrytk henrytk mentioned this issue Aug 30, 2018
Closed
henrytk added a commit to alphagov/paas-docker-cloudfoundry-tools that referenced this issue Aug 30, 2018
@henrytk
Upgrade Terraform AWS provider
23991b9 
This is the minimum upgrade required to fix an issue we are having with
DNS entries flapping[1].

Documentation for this provider version: [2]

[1] hashicorp/terraform-provider-aws#361
[2] https://github.com/terraform-providers/terraform-provider-aws/tree/v1.8.0/website/docs/r
henrytk added a commit to alphagov/paas-bootstrap that referenced this issue Aug 30, 2018
@henrytk
[TMP] - Pin dev version of Terraform container
eb42e08 
Changed with:

```bash
find concourse/ -type f -exec sed -i sed -i '' 's/tag: 9cad30b5d5889a0b72173f39701d1620e24df82c/tag: terraform-aws-provider-upgrade/' {} +
```

Once the Docker image is built and tagged you can update this temporary commit with:

```bash
find concourse/ -type f -exec sed -i sed -i '' 's/tag: terraform-aws-provider-upgrade/tag: whatever-the-new-hash-is/' {} +
```

Commit message you can use:

Upgrade Terraform AWS provider

This is the minimum upgrade required to fix an issue we are having with
DNS entries flapping[1].

Documentation for this provider version: [2]

[1] hashicorp/terraform-provider-aws#361
[2] https://github.com/terraform-providers/terraform-provider-aws/tree/v1.8.0/website/docs/r
henrytk added a commit to alphagov/paas-cf that referenced this issue Aug 30, 2018
@henrytk
[TMP] - Pin dev version of Terraform container
1527c4a 
Changed with:

```bash
find concourse/ -type f -exec sed -i sed -i '' 's/tag: 9cad30b5d5889a0b72173f39701d1620e24df82c/tag: terraform-aws-provider-upgrade/' {} +
find concourse/ -type f -exec sed -i sed -i '' 's/tag: f810666094e6c65eeb183f9833b231aa24df6811/tag: terraform-aws-provider-upgrade/' {} +
```

Once the Docker image is built and tagged you can update this temporary commit with:

```bash
find concourse/ -type f -exec sed -i sed -i '' 's/tag: terraform-aws-provider-upgrade/tag: whatever-the-new-hash-is/' {} +
```

Commit message you can use:

Upgrade Terraform AWS provider

This is the minimum upgrade required to fix an issue we are having with
DNS entries flapping[1].

Documentation for this provider version: [2]

[1] hashicorp/terraform-provider-aws#361
[2] https://github.com/terraform-providers/terraform-provider-aws/tree/v1.8.0/website/docs/r
@ghost
Copy link

ghost commented Apr 8, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. service/route53 Issues and PRs that pertain to the route53 service.
Projects
None yet
Milestone
v1.8.0
Development

Successfully merging a pull request may close this issue.

resource/aws_route53_record: Suppress uppercase alias name diff hashicorp/terraform-provider-aws
3 participants
@bflad @Jonnymcc @hashibot