feat: Add custom_time_zone & file_extension to extended_S3_configuration block for aws_kinesis_firehose_delivery_stream

[acwwat]

Description

This PR is to add the custom_time_zone and file_extension arguments to the extended_s3_configuration configuration block for the kinesis_firehose_delivery_stream resource.

In terms of design, I opted to set a default value UTC for custom_time_zone, even though the attribute can initially be empty. The quirk with the API for this resource is that the update action requires the default value for these two attributes - not providing it does not equate to removing the attributes in the update action. But the attributes will be set permanently in the resource with UTC and empty string thereafter. It was too difficult to get the states to completely match without resorting to default values.

Relations

Closes #35957

References

Referenced ExtendedS3DestinationConfiguration, ExtendedS3DestinationDescription, and ExtendedS3DestinationUpdate for the API spec.

Output from Acceptance Testing

Note: TestAccFirehoseDeliveryStream_extendedS3CustomTimeZoneAndFileExtensionUpdates is a new test case.

$
make testacc TESTS=TestAccFirehoseDeliveryStream_basic PKG=firehose
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/firehose/... -v -count 1 -parallel 20 -run='TestAccFirehoseDeliveryStream_basic'  -timeout 360m
=== RUN   TestAccFirehoseDeliveryStream_basic
=== PAUSE TestAccFirehoseDeliveryStream_basic
=== CONT  TestAccFirehoseDeliveryStream_basic
--- PASS: TestAccFirehoseDeliveryStream_basic (257.26s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/firehose   257.433s

$

$ make testacc TESTS=TestAccFirehoseDeliveryStream_extendedS3CustomTimeZoneAndFileExtensionUpdates PKG=firehose
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/firehose/... -v -count 1 -parallel 20 -run='TestAccFirehoseDeliveryStream_extendedS3CustomTimeZoneAndFileExtensionUpdates'  -timeout 360m
=== RUN   TestAccFirehoseDeliveryStream_extendedS3CustomTimeZoneAndFileExtensionUpdates
=== PAUSE TestAccFirehoseDeliveryStream_extendedS3CustomTimeZoneAndFileExtensionUpdates
=== CONT  TestAccFirehoseDeliveryStream_extendedS3CustomTimeZoneAndFileExtensionUpdates
--- PASS: TestAccFirehoseDeliveryStream_extendedS3CustomTimeZoneAndFileExtensionUpdates (369.12s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/firehose   369.305s

$
...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccFirehoseDeliveryStream_extendedS3' PKG=firehose ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/firehose/... -v -count 1 -parallel 3  -run=TestAccFirehoseDeliveryStream_extendedS3 -timeout 360m
=== RUN   TestAccFirehoseDeliveryStream_extendedS3basic
=== PAUSE TestAccFirehoseDeliveryStream_extendedS3basic
=== RUN   TestAccFirehoseDeliveryStream_extendedS3KMSKeyARN
=== PAUSE TestAccFirehoseDeliveryStream_extendedS3KMSKeyARN
=== RUN   TestAccFirehoseDeliveryStream_extendedS3DynamicPartitioning
=== PAUSE TestAccFirehoseDeliveryStream_extendedS3DynamicPartitioning
=== RUN   TestAccFirehoseDeliveryStream_extendedS3DynamicPartitioningUpdate
=== PAUSE TestAccFirehoseDeliveryStream_extendedS3DynamicPartitioningUpdate
=== RUN   TestAccFirehoseDeliveryStream_extendedS3Updates
=== PAUSE TestAccFirehoseDeliveryStream_extendedS3Updates
=== RUN   TestAccFirehoseDeliveryStream_extendedS3CustomTimeZoneAndFileExtensionUpdates
=== PAUSE TestAccFirehoseDeliveryStream_extendedS3CustomTimeZoneAndFileExtensionUpdates
=== CONT  TestAccFirehoseDeliveryStream_extendedS3basic
=== CONT  TestAccFirehoseDeliveryStream_extendedS3DynamicPartitioningUpdate
=== CONT  TestAccFirehoseDeliveryStream_extendedS3CustomTimeZoneAndFileExtensionUpdates
--- PASS: TestAccFirehoseDeliveryStream_extendedS3basic (127.61s)
=== CONT  TestAccFirehoseDeliveryStream_extendedS3Updates
--- PASS: TestAccFirehoseDeliveryStream_extendedS3CustomTimeZoneAndFileExtensionUpdates (142.05s)
=== CONT  TestAccFirehoseDeliveryStream_extendedS3DynamicPartitioning
--- PASS: TestAccFirehoseDeliveryStream_extendedS3DynamicPartitioningUpdate (247.99s)
=== CONT  TestAccFirehoseDeliveryStream_extendedS3KMSKeyARN
--- PASS: TestAccFirehoseDeliveryStream_extendedS3DynamicPartitioning (147.80s)
--- PASS: TestAccFirehoseDeliveryStream_extendedS3Updates (187.75s)
--- PASS: TestAccFirehoseDeliveryStream_extendedS3KMSKeyARN (130.15s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/firehose	391.345s

[ewbankkit]

@acwwat Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.39.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.