Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kinesis Firehose ExtendedS3Configuration support for FileExtension #3479

Closed
dygfloyd opened this issue Feb 26, 2024 · 5 comments
Closed

Kinesis Firehose ExtendedS3Configuration support for FileExtension #3479

dygfloyd opened this issue Feb 26, 2024 · 5 comments
Assignees
Labels
kind/enhancement Improvements or new features resolution/fixed This issue was fixed

Comments

@dygfloyd
Copy link

Hello!

  • Vote on this issue by adding a 👍 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

Kinesis Firehose ExtendedS3Configuration current does not support the optional FileExtension property. This property is described in the AWS Destination Settings documentation. This causes issues when you are trying to import files in S3 into other systems that require specific file extensions. For example, Datadog log rehydration only supports files with the extension .json.gz.

@dygfloyd dygfloyd added kind/enhancement Improvements or new features needs-triage Needs attention from the triage team labels Feb 26, 2024
@iwahbe iwahbe removed the needs-triage Needs attention from the triage team label Feb 27, 2024
@iwahbe
Copy link
Member

iwahbe commented Feb 27, 2024

Hi @dygfloyd. Thanks for letting us know about this. The pulumi-aws provider is bridged from https://github.com/hashicorp/terraform-provider-aws. The best way to get this feature added is to open an issue there.

@dygfloyd
Copy link
Author

I posted a feature request in that repo as well. hashicorp/terraform-provider-aws#35989
Unfortunately, I am unfamiliar with the terraform provider so if anyone has any details they can add to the request, that would be great.

@iwahbe iwahbe added the awaiting-upstream The issue cannot be resolved without action in another repository (may be owned by Pulumi). label Feb 27, 2024
@dygfloyd
Copy link
Author

dygfloyd commented Feb 27, 2024

Looks like there was a duplicate ticket and this feature was added a couple of days ago:
hashicorp/terraform-provider-aws#35969

@iwahbe
Copy link
Member

iwahbe commented Feb 28, 2024

Great. Then pulumi-aws will pick up the feature shortly after terraform-provider-aws's next release.

@mikhailshilkov mikhailshilkov self-assigned this Sep 19, 2024
@mikhailshilkov mikhailshilkov added resolution/fixed This issue was fixed and removed awaiting-upstream The issue cannot be resolved without action in another repository (may be owned by Pulumi). labels Sep 19, 2024
@mikhailshilkov
Copy link
Member

Closing as implemented upstream in hashicorp/terraform-provider-aws#35957

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Projects
None yet
Development

No branches or pull requests

3 participants