Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make EKS access entry user_name and type configurable #35391

Conversation

AndrewChubatiuk
Copy link

@AndrewChubatiuk AndrewChubatiuk commented Jan 19, 2024

Description

currently type and user_name properties of aws_eks_access_entry, which makes it impossible to utilize this resource for nodes. fixed it

Relates #35037.

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/eks Issues and PRs that pertain to the eks service. labels Jan 19, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Jan 19, 2024
@github-actions github-actions bot added the size/XS Managed by automation to categorize the size of a PR. label Jan 19, 2024
@AndrewChubatiuk AndrewChubatiuk force-pushed the make-eks-access-entry-type-configurable branch from de0a269 to 02a8ad8 Compare January 19, 2024 13:00
@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Jan 19, 2024
@AndrewChubatiuk AndrewChubatiuk changed the title make EKS access entry type configurable make EKS access entry user_name and type configurable Jan 19, 2024
@AndrewChubatiuk AndrewChubatiuk force-pushed the make-eks-access-entry-type-configurable branch from 02a8ad8 to 7fe8e03 Compare January 19, 2024 13:27
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Jan 19, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccEKSAccessEntry_username\|TestAccEKSAccessEntry_basic\|TestAccEKSAccessEntry_type' PKG=eks
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/eks/... -v -count 1 -parallel 20  -run=TestAccEKSAccessEntry_username\|TestAccEKSAccessEntry_basic\|TestAccEKSAccessEntry_type -timeout 360m
=== RUN   TestAccEKSAccessEntry_basic
=== PAUSE TestAccEKSAccessEntry_basic
=== RUN   TestAccEKSAccessEntry_type
=== PAUSE TestAccEKSAccessEntry_type
=== RUN   TestAccEKSAccessEntry_username
=== PAUSE TestAccEKSAccessEntry_username
=== CONT  TestAccEKSAccessEntry_basic
=== CONT  TestAccEKSAccessEntry_username
=== CONT  TestAccEKSAccessEntry_type
--- PASS: TestAccEKSAccessEntry_basic (547.95s)
--- PASS: TestAccEKSAccessEntry_type (539.67s)
--- PASS: TestAccEKSAccessEntry_username (620.27s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/eks	630.416s

@ewbankkit
Copy link
Contributor

@AndrewChubatiuk Thanks for the contribution 🎉 👏.

Copy link

This functionality has been released in v5.34.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/eks Issues and PRs that pertain to the eks service. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants