Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Distribution in aws_cloudwatch_log_subscription_filter #2853

Closed
jacknagz opened this issue Jan 3, 2018 · 2 comments · Fixed by #3046
Closed

Feature Request: Distribution in aws_cloudwatch_log_subscription_filter #2853

jacknagz opened this issue Jan 3, 2018 · 2 comments · Fixed by #3046
Labels
enhancement Requests to existing resources that expand the functionality or scope.
Milestone

Comments

@jacknagz
Copy link

jacknagz commented Jan 3, 2018

Terraform Version

Latest at time of writing (0.11.1)

Affected Resource(s)

  • aws_cloudwatch_log_subscription_filter

Feature

As of the AWS-SDK-Go version 1.6.3, the CloudWatch Log Subscription filters API includes a flag to control how logs are sent to a AWS Kinesis Stream. If distribution is set to Random, it will randomize the delivery of logs to each Kinesis shard to ensure an even throughput. Else, if set to ByLogStream, will map to ENIs.

Terraform Configuration Files

resource "aws_cloudwatch_log_subscription_filter" "test_lambdafunction_logfilter" {
  name            = "test_lambdafunction_logfilter"
  role_arn        = "${aws_iam_role.iam_for_lambda.arn}"
  log_group_name  = "/aws/lambda/example_lambda_name"
  filter_pattern  = "logtype test"
  destination_arn = "${aws_kinesis_stream.test_logstream.arn}"
  distribution    = "Random"
}

References

@radeksimko radeksimko added the enhancement Requests to existing resources that expand the functionality or scope. label Jan 16, 2018
Ninir pushed a commit that referenced this issue Jan 25, 2018
…ribution (#3046)

* adding support for distribution in cw subscription filters. resolves #2853

* Update resource_aws_cloudwatch_log_subscription_filter_test.go
@bflad
Copy link
Contributor

bflad commented Jan 29, 2018

This has been released in terraform-provider-aws version 1.8.0. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@bflad bflad added this to the v1.8.0 milestone Jan 29, 2018
@ghost
Copy link

ghost commented Apr 8, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants