Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/s3_bucket_acl: backport resource #23419

Merged
merged 4 commits into from
Mar 12, 2022
Merged

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Mar 1, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #23106

Output from acceptance testing:

--- PASS: TestAccS3BucketAcl_disappears (21.49s)
--- PASS: TestAccS3BucketAcl_basic (31.13s)
--- PASS: TestAccS3BucketAcl_migrate_aclNoChange (54.67s)
--- PASS: TestAccS3BucketAcl_migrate_grantsNoChange (55.54s)
--- PASS: TestAccS3BucketAcl_grantToACL (55.84s)
--- PASS: TestAccS3BucketAcl_migrate_aclWithChange (56.05s)
--- PASS: TestAccS3BucketAcl_updateACL (56.81s)
--- PASS: TestAccS3BucketAcl_migrate_grantsWithChange (57.51s)
--- PASS: TestAccS3BucketAcl_ACLToGrant (57.65s)
--- PASS: TestAccS3BucketAcl_updateGrant (59.26s)

--- PASS: TestAccS3Bucket_Basic_forceDestroyWithEmptyPrefixes (43.15s)
--- PASS: TestAccS3Bucket_Basic_forceDestroyWithObjectLockEnabled (76.68s)
--- PASS: TestAccS3Bucket_Manage_MfaDeleteDisabled (77.12s)
--- PASS: TestAccS3Bucket_Basic_basic (78.10s)
--- PASS: TestAccS3Bucket_Replication_multipleDestinationsNonEmptyFilter (120.09s)
--- PASS: TestAccS3Bucket_Manage_lifecycleRuleExpirationEmptyBlock (127.18s)
--- PASS: TestAccS3Bucket_Manage_lifecycleRuleAbortIncompleteMultipartUploadDaysNoExpiration (169.53s)
--- PASS: TestAccS3Bucket_Replication_multipleDestinationsEmptyFilter (268.14s)
--- PASS: TestAccS3Bucket_Basic_forceDestroy (109.14s)
--- PASS: TestAccS3Bucket_Manage_lifecycleBasic (439.68s)
--- PASS: TestAccS3Bucket_Manage_lifecycleExpireMarkerOnly (279.35s)
--- PASS: TestAccS3Bucket_Replication_expectVersioningValidationError (66.77s)
--- PASS: TestAccS3Bucket_Manage_objectLock (275.19s)
--- PASS: TestAccS3Bucket_Replication_withoutStorageClass (204.40s)
--- PASS: TestAccS3Bucket_Replication_schemaV2SameRegion (204.55s)
--- PASS: TestAccS3Bucket_Replication_basic (745.08s)
--- PASS: TestAccS3Bucket_Replication_ruleDestinationAddAccessControlTranslation (395.35s)
--- PASS: TestAccS3Bucket_Replication_withoutPrefix (240.20s)
--- PASS: TestAccS3Bucket_Replication_RTC_valid (706.45s)
--- PASS: TestAccS3Bucket_Replication_ruleDestinationAccessControlTranslation (400.81s)
--- PASS: TestAccS3Bucket_Basic_generatedName (108.52s)
--- PASS: TestAccS3Bucket_Replication_twoDestination (178.90s)
--- PASS: TestAccS3Bucket_Basic_shouldFailNotFound (51.55s)
--- PASS: TestAccS3Bucket_Security_aclToGrant (183.97s)
--- PASS: TestAccS3Bucket_Manage_versioningDisabled (101.72s)
--- PASS: TestAccS3Bucket_Basic_keyEnabled (276.82s)
--- PASS: TestAccS3Bucket_Manage_versioning (573.10s)
--- PASS: TestAccS3Bucket_Replication_schemaV2 (1159.01s)
--- PASS: TestAccS3Bucket_Security_disableDefaultEncryptionWhenDefaultEncryptionIsEnabled (644.07s)
--- PASS: TestAccS3Bucket_Security_enableDefaultEncryptionWhenAES256IsUsed (420.25s)
--- PASS: TestAccS3Bucket_Security_enableDefaultEncryptionWhenTypical (146.58s)
--- PASS: TestAccS3Bucket_Security_updateGrant (790.15s)
--- PASS: TestAccS3Bucket_Security_updateACL (317.21s)
--- PASS: TestAccS3Bucket_Basic_acceleration (249.85s)
--- PASS: TestAccS3Bucket_Web_routingRules (228.92s)
--- PASS: TestAccS3Bucket_Basic_namePrefix (122.59s)
--- PASS: TestAccS3Bucket_Tags_ignoreTags (193.15s)
--- PASS: TestAccS3Bucket_Web_redirect (316.45s)
--- PASS: TestAccS3Bucket_Security_grantToACL (193.62s)
--- PASS: TestAccS3Bucket_Web_simple (314.42s)
--- PASS: TestAccS3Bucket_Basic_emptyString (140.44s)
--- PASS: TestAccS3Bucket_Tags_basic (152.97s)
--- PASS: TestAccS3Bucket_Security_corsDelete (96.70s)
--- PASS: TestAccS3Bucket_Tags_withNoSystemTags (463.52s)
--- PASS: TestAccS3Bucket_Security_logging (197.75s)
--- PASS: TestAccS3Bucket_Security_corsEmptyOrigin (162.16s)
--- PASS: TestAccS3Bucket_Tags_withSystemTags (525.98s)
--- PASS: TestAccS3Bucket_Manage_versioningAndMfaDeleteDisabled (86.48s)
--- PASS: TestAccS3Bucket_Security_policy (314.89s)
--- PASS: TestAccS3Bucket_Security_corsUpdate (229.76s)
--- PASS: TestAccS3Bucket_Basic_requestPayer (225.71s)

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/s3 Issues and PRs that pertain to the s3 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. labels Mar 1, 2022
@anGie44 anGie44 force-pushed the f-s3-bucket-acl-new-resource branch 2 times, most recently from f342ca1 to 6916327 Compare March 1, 2022 02:44
@anGie44 anGie44 added the new-resource Introduces a new resource. label Mar 1, 2022
@anGie44 anGie44 force-pushed the f-s3-bucket-acl-new-resource branch from 6916327 to f9ba8c6 Compare March 1, 2022 02:47
anGie44 added a commit that referenced this pull request Mar 1, 2022
@anGie44 anGie44 force-pushed the f-s3-bucket-acl-new-resource branch from 5239a4d to 71d35bf Compare March 1, 2022 02:53
@anGie44 anGie44 marked this pull request as ready for review March 1, 2022 17:36
@anGie44 anGie44 marked this pull request as draft March 1, 2022 17:43
@gdavison gdavison added this to the v3.75.0 milestone Mar 2, 2022
@anGie44 anGie44 force-pushed the f-s3-bucket-acl-new-resource branch from 71d35bf to c19fbdc Compare March 10, 2022 23:47
@anGie44 anGie44 force-pushed the f-s3-bucket-acl-new-resource branch from c19fbdc to c4f3116 Compare March 10, 2022 23:47
@anGie44 anGie44 force-pushed the f-s3-bucket-acl-new-resource branch from c4f3116 to 79d6f59 Compare March 10, 2022 23:50
@anGie44 anGie44 marked this pull request as ready for review March 10, 2022 23:53
anGie44 added a commit that referenced this pull request Mar 11, 2022
@anGie44 anGie44 force-pushed the f-s3-bucket-acl-new-resource branch from 79d6f59 to bc0a235 Compare March 11, 2022 00:26
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚀

A couple non-blocking comments

internal/service/s3/bucket.go Outdated Show resolved Hide resolved
internal/service/s3/bucket_acl_test.go Show resolved Hide resolved

## Usage Notes

~> **NOTE:** To avoid conflicts always add the following lifecycle object to the `aws_s3_bucket` resource of the source bucket.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good note to add

@anGie44 anGie44 force-pushed the f-s3-bucket-acl-new-resource branch from 80bd64f to b1d17ea Compare March 11, 2022 23:13
@anGie44 anGie44 merged commit 868d78a into release/3.x Mar 12, 2022
@anGie44 anGie44 deleted the f-s3-bucket-acl-new-resource branch March 12, 2022 00:03
@github-actions github-actions bot modified the milestones: v3.75.0, v3.74.4 Mar 12, 2022
github-actions bot pushed a commit that referenced this pull request Mar 12, 2022
@ewbankkit ewbankkit modified the milestones: v3.74.4, v3.75.0 Mar 14, 2022
@anGie44 anGie44 changed the title r/s3_bucket_acl: new resource r/s3_bucket_acl: backport resource Mar 15, 2022
@github-actions
Copy link

This functionality has been released in v3.75.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/s3 Issues and PRs that pertain to the s3 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants