Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for aws_vpc support new attribute Ipv6CidrBlockNetworkBorderGroup #22211

Closed
wants to merge 344 commits into from
Closed

Support for aws_vpc support new attribute Ipv6CidrBlockNetworkBorderGroup #22211

wants to merge 344 commits into from

Conversation

NetDevAutomate
Copy link
Contributor

…derGroup #15766 for review, test cases to follow

aws_vpc support new attribute Ipv6CidrBlockNetworkBorderGroup #15766 for review

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTS=TestAccXXX PKG=ec2

...

@github-actions github-actions bot added service/ec2 Issues and PRs that pertain to the ec2 service. needs-triage Waiting for first response or review from a maintainer. size/XS Managed by automation to categorize the size of a PR. size/S Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Dec 14, 2021
drewmullen
drewmullen suggested changes Dec 15, 2021
View reviewed changes
internal/service/ec2/vpc.go Outdated Show resolved Hide resolved
internal/service/ec2/vpc.go Outdated Show resolved Hide resolved
internal/service/ec2/vpc.go Outdated Show resolved Hide resolved
@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. and removed size/S Managed by automation to categorize the size of a PR. labels Dec 16, 2021
@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. and removed size/M Managed by automation to categorize the size of a PR. labels Dec 23, 2021
@NetDevAutomate
Copy link
Contributor Author

Test Results:

make testacc TESTARGS='-run=TestAccVPC_assignGeneratedIPv6CIDRBlockWithBorder' ACCTEST_PARALLELISM=5 PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 5 -run=TestAccVPC_assignGeneratedIPv6CIDRBlockWithBorder -timeout 180m
=== RUN TestAccVPC_assignGeneratedIPv6CIDRBlockWithBorder
=== PAUSE TestAccVPC_assignGeneratedIPv6CIDRBlockWithBorder
=== CONT TestAccVPC_assignGeneratedIPv6CIDRBlockWithBorder
--- PASS: TestAccVPC_assignGeneratedIPv6CIDRBlockWithBorder (106.59s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 110.301s

@NetDevAutomate NetDevAutomate changed the title [WIP] Initial fix for aws_vpc support new attribute Ipv6CidrBlockNetworkBor… Support for aws_vpc support new attribute Ipv6CidrBlockNetworkBorderGroup Dec 23, 2021
@github-actions github-actions bot added service/devicefarm Issues and PRs that pertain to the devicefarm service. service/directoryservice service/elb Issues and PRs that pertain to the elb service. service/firehose Issues and PRs that pertain to the firehose service. service/fsx Issues and PRs that pertain to the fsx service. service/glue Issues and PRs that pertain to the glue service. service/iam Issues and PRs that pertain to the iam service. service/kafkaconnect Issues and PRs that pertain to the kafkaconnect service. service/kinesis Issues and PRs that pertain to the kinesis service. service/memorydb Issues and PRs that pertain to the memorydb service. service/networkfirewall Issues and PRs that pertain to the networkfirewall service. service/organizations Issues and PRs that pertain to the organizations service. service/route53resolver Issues and PRs that pertain to the route53resolver service. service/s3 Issues and PRs that pertain to the s3 service. service/sagemaker Issues and PRs that pertain to the sagemaker service. service/ses Issues and PRs that pertain to the ses service. service/ssm Issues and PRs that pertain to the ssm service. service/synthetics Issues and PRs that pertain to the synthetics service. service/timestreamwrite Issues and PRs that pertain to the timestreamwrite service. sweeper Pertains to changes to or issues with the sweeper. labels Jan 6, 2022
@github-actions
Copy link

github-actions bot commented Jan 6, 2022

Thank you for your contribution! 🚀

Please note that the CHANGELOG.md file contents are handled by the maintainers during merge. This is to prevent pull request merge conflicts, especially for contributions which may not be merged immediately. Please see the Contributing Guide for additional pull request review items.

Remove any changes to the CHANGELOG.md file and commit them in this pull request to prevent delays with reviewing and potentially merging this pull request.

drewmullen
drewmullen suggested changes Jan 6, 2022
View reviewed changes
Copy link
Collaborator

@drewmullen drewmullen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please mention the new parameter ipv6_cidr_block_network_border_group & that assign_generated_ipv6_cidr_block is required to set it

.changelog/22211.txt Outdated
@@ -0,0 +1,3 @@
```release-note:enhancement
resource/ec2/vpc: Add `ipv6_cidr_block_network_border_group` argument
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style should be resource/aws_vpc: for all changelog files

@NetDevAutomate NetDevAutomate deleted the Ipv6CidrBlockNetworkBorderGroup branch January 6, 2022 19:42
@github-actions github-actions bot removed the needs-triage Waiting for first response or review from a maintainer. label Jan 6, 2022
@NetDevAutomate NetDevAutomate restored the Ipv6CidrBlockNetworkBorderGroup branch January 6, 2022 20:56
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2022
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@drewmullen drewmullen drewmullen requested changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. linter Pertains to changes to or issues with the various linters. partner Contribution from a partner. provider Pertains to the provider itself, rather than any interaction with AWS. service/appstream Issues and PRs that pertain to the appstream service. service/batch Issues and PRs that pertain to the batch service. service/cloud9 Issues and PRs that pertain to the cloud9 service. service/cloudfront Issues and PRs that pertain to the cloudfront service. service/cloudtrail Issues and PRs that pertain to the cloudtrail service. service/codebuild Issues and PRs that pertain to the codebuild service. service/codepipeline Issues and PRs that pertain to the codepipeline service. service/datasync Issues and PRs that pertain to the datasync service. service/dax Issues and PRs that pertain to the dax service. service/devicefarm Issues and PRs that pertain to the devicefarm service. service/directconnect Issues and PRs that pertain to the directconnect service. service/ec2 Issues and PRs that pertain to the ec2 service. service/elb Issues and PRs that pertain to the elb service. service/firehose Issues and PRs that pertain to the firehose service. service/fsx Issues and PRs that pertain to the fsx service. service/glue Issues and PRs that pertain to the glue service. service/iam Issues and PRs that pertain to the iam service. service/kafkaconnect Issues and PRs that pertain to the kafkaconnect service. service/kinesis Issues and PRs that pertain to the kinesis service. service/memorydb Issues and PRs that pertain to the memorydb service. service/networkfirewall Issues and PRs that pertain to the networkfirewall service. service/organizations Issues and PRs that pertain to the organizations service. service/route53resolver Issues and PRs that pertain to the route53resolver service. service/s3 Issues and PRs that pertain to the s3 service. service/sagemaker Issues and PRs that pertain to the sagemaker service. service/ses Issues and PRs that pertain to the ses service. service/ssm Issues and PRs that pertain to the ssm service. service/synthetics Issues and PRs that pertain to the synthetics service. service/timestreamwrite Issues and PRs that pertain to the timestreamwrite service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.