Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_vpc support new attribute Ipv6CidrBlockNetworkBorderGroup #15766

Closed
pingwin opened this issue Oct 21, 2020 · 5 comments · Fixed by #22450
Closed

aws_vpc support new attribute Ipv6CidrBlockNetworkBorderGroup #15766

pingwin opened this issue Oct 21, 2020 · 5 comments · Fixed by #22450
Labels
enhancement Requests to existing resources that expand the functionality or scope. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. service/ec2 Issues and PRs that pertain to the ec2 service.
Milestone

Comments

@pingwin
Copy link

pingwin commented Oct 21, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

  1. Support the Ipv6CidrBlockNetworkBorderGroup attribute to provide IPv6 addresses to LocalZones and Wavelength Zones.

New or Affected Resource(s)

  • aws_vpc

Potential Terraform Configuration

ipv6_cidr_block_network_border_group = The name of the location from which we advertise the IPV6 CIDR block. Use this parameter to limit the address to this location. 

References

@pingwin pingwin added the enhancement Requests to existing resources that expand the functionality or scope. label Oct 21, 2020
@ghost ghost added the service/ec2 Issues and PRs that pertain to the ec2 service. label Oct 21, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Oct 21, 2020
@anGie44 anGie44 added good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 22, 2020
@efog
Copy link

efog commented Dec 4, 2020

Hi,

I would be interested in working on this as I could need this. Is it necessary for the AWS SDK to be updated with the new properties (ec2/api.go) to start working on this?

ÉB

@ewbankkit
Copy link
Contributor

ewbankkit commented Jan 5, 2021

For full functionality we will also need to add an aws_vpc_ipv6_cidr_block_association resource (and update the aws_vpc data source) as a VPC that includes Local (or Wavelength, if IPv6 is supported) Zone subnets can have multiple IPv6 CIDR blocks (one per network border group).

Relates: #14518.

Will also have to deal with assumptions that a VPC has only a single associated IPv6 CIDR block:

for _, a := range vpc.Ipv6CidrBlockAssociationSet {
if aws.StringValue(a.Ipv6CidrBlockState.State) == ec2.VpcCidrBlockStateCodeAssociated { //we can only ever have 1 IPv6 block associated at once
d.Set("assign_generated_ipv6_cidr_block", true)
d.Set("ipv6_association_id", a.AssociationId)
d.Set("ipv6_cidr_block", a.Ipv6CidrBlock)
}
}

if vpc.Ipv6CidrBlockAssociationSet != nil {
d.Set("ipv6_association_id", vpc.Ipv6CidrBlockAssociationSet[0].AssociationId)
d.Set("ipv6_cidr_block", vpc.Ipv6CidrBlockAssociationSet[0].Ipv6CidrBlock)
}

For backwards compatibility it seems to make sense to keep the aws_vpc resource as managing the "region" (i.e. non-Local or Wavelength Zone) network border group's IPv6 CIDR and limit the aws_vpc_ipv6_cidr_block_association to the Local and Wavelength Zone network border groups.

@FireballDWF
Copy link

Hi,

I would be interested in working on this as I could need this. Is it necessary for the AWS SDK to be updated with the new properties (ec2/api.go) to start working on this?

The SDK has been updated, so their should be no blockers to working on this.

@github-actions
Copy link

This functionality has been released in v3.72.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. service/ec2 Issues and PRs that pertain to the ec2 service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants