Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tech_debt: functions for detaching and deleting network interfaces #21542

Merged
merged 20 commits into from
Nov 8, 2021
Merged

tech_debt: functions for detaching and deleting network interfaces #21542

merged 20 commits into from
Nov 8, 2021

Conversation

kamilturek
Copy link
Collaborator

@kamilturek kamilturek commented Oct 28, 2021 •
edited by ewbankkit
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #21406.
Closes #21647.
Closes #21621.

Output from acceptance testing:

$ make testacc TESTARGS="-run=TestAccELBLoadBalancer_basic" PKG_NAME="internal/service/elb"                 х INT
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elb/... -v -count 1 -parallel 20 -run=TestAccELBLoadBalancer_basic -timeout 180m
=== RUN   TestAccELBLoadBalancer_basic
=== PAUSE TestAccELBLoadBalancer_basic
=== CONT  TestAccELBLoadBalancer_basic
--- PASS: TestAccELBLoadBalancer_basic (48.49s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elb	54.305s

$ make testacc TESTARGS="-run=TestAccELBV2LoadBalancer_ALB_basic" PKG_NAME="internal/service/elbv2"         1m 9s
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elbv2/... -v -count 1 -parallel 20 -run=TestAccELBV2LoadBalancer_ALB_basic -timeout 180m
=== RUN   TestAccELBV2LoadBalancer_ALB_basic
=== PAUSE TestAccELBV2LoadBalancer_ALB_basic
=== CONT  TestAccELBV2LoadBalancer_ALB_basic
--- PASS: TestAccELBV2LoadBalancer_ALB_basic (275.12s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elbv2	280.868s

$ make testacc TESTARGS="-run=TestAccEC2NetworkInterface_ENI_basic" PKG_NAME="internal/service/ec2"        4m 55s
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccEC2NetworkInterface_ENI_basic -timeout 180m
=== RUN   TestAccEC2NetworkInterface_ENI_basic
=== PAUSE TestAccEC2NetworkInterface_ENI_basic
=== CONT  TestAccEC2NetworkInterface_ENI_basic
--- PASS: TestAccEC2NetworkInterface_ENI_basic (104.55s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	110.448s

@github-actions github-actions bot added service/ec2 Issues and PRs that pertain to the ec2 service. service/elb Issues and PRs that pertain to the elb service. service/elbv2 Issues and PRs that pertain to the elbv2 service. needs-triage Waiting for first response or review from a maintainer. size/L Managed by automation to categorize the size of a PR. size/XL Managed by automation to categorize the size of a PR. and removed needs-triage Waiting for first response or review from a maintainer. size/L Managed by automation to categorize the size of a PR. labels Oct 28, 2021
@kamilturek kamilturek marked this pull request as ready for review November 1, 2021 20:40
kamilturek and others added 12 commits November 5, 2021 09:00
@kamilturek @ewbankkit
Use common functions in elbv2
2233588
@kamilturek @ewbankkit
Use common functions in elb
ebc46a0
@kamilturek @ewbankkit
Fix magic number
ef41bac
@kamilturek @ewbankkit
Remove deadcode
bf66452
@ewbankkit
Revert ELB changes.
bbb7c62
@ewbankkit
d/aws_network_interface: 'attachment' configuration block structure d…
7409022 
…iffers from r/aws_network_interface.

Before:

% make testacc PKG_NAME=internal/service/ec2 TESTARGS='-run=TestAccEC2NetworkInterfaceDataSource_attachment'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccEC2NetworkInterfaceDataSource_attachment -timeout 180m
=== RUN   TestAccEC2NetworkInterfaceDataSource_attachment
=== PAUSE TestAccEC2NetworkInterfaceDataSource_attachment
=== CONT  TestAccEC2NetworkInterfaceDataSource_attachment
panic: Invalid address to set: []string{"attachment", "0", "instance"}

goroutine 853 [running]:
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*ResourceData).Set(0xc0014d9500, 0x9ee5bb3, 0xa, 0x7f3d000, 0xc001d6af78, 0x0, 0x0)
	/Users/ewbankkit/go/pkg/mod/github.com/gdavison/terraform-plugin-sdk/[email protected]/helper/schema/resource_data.go:230 +0x371
github.com/hashicorp/terraform-provider-aws/internal/service/ec2.dataSourceNetworkInterfaceRead(0xc0014d9500, 0x8c673e0, 0xc0000c6400, 0xf889790, 0xc000680000)
	/Users/ewbankkit/src/github.com/terraform-providers/terraform-provider-aws/internal/service/ec2/network_interface_data_source.go:190 +0x7a9
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*Resource).read(0xc00015c7e0, 0xae70ee8, 0xc001d57f80, 0xc0014d9500, 0x8c673e0, 0xc0000c6400, 0x0, 0x0, 0x0)
	/Users/ewbankkit/go/pkg/mod/github.com/gdavison/terraform-plugin-sdk/[email protected]/helper/schema/resource.go:335 +0x1ee
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*Resource).ReadDataApply(0xc00015c7e0, 0xae70ee8, 0xc001d57f80, 0xc000fd4be0, 0x8c673e0, 0xc0000c6400, 0xc0000c6400, 0xc000fd4be0, 0x0, 0x0)
	/Users/ewbankkit/go/pkg/mod/github.com/gdavison/terraform-plugin-sdk/[email protected]/helper/schema/resource.go:558 +0xfd
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*GRPCProviderServer).ReadDataSource(0xc0025c4228, 0xae70ee8, 0xc001d57f80, 0xc000fd4000, 0xc001d57f80, 0x100d725, 0x9881e20)
	/Users/ewbankkit/go/pkg/mod/github.com/gdavison/terraform-plugin-sdk/[email protected]/helper/schema/grpc_provider.go:1105 +0x4d6
github.com/hashicorp/terraform-plugin-go/tfprotov5/server.(*server).ReadDataSource(0xc0029724a0, 0xae70f90, 0xc001d57f80, 0xc0004454a0, 0xc0029724a0, 0xc001d70540, 0xc0014f4ba0)
	/Users/ewbankkit/go/pkg/mod/github.com/hashicorp/[email protected]/tfprotov5/server/server.go:247 +0xe5
github.com/hashicorp/terraform-plugin-go/tfprotov5/internal/tfplugin5._Provider_ReadDataSource_Handler(0x9c44540, 0xc0029724a0, 0xae70f90, 0xc001d70540, 0xc001d6c300, 0x0, 0xae70f90, 0xc001d70540, 0xc001b6da40, 0x12b)
	/Users/ewbankkit/go/pkg/mod/github.com/hashicorp/[email protected]/tfprotov5/internal/tfplugin5/tfplugin5_grpc.pb.go:416 +0x214
google.golang.org/grpc.(*Server).processUnaryRPC(0xc0005ea8c0, 0xae9ce38, 0xc002071200, 0xc001c74800, 0xc001cecc90, 0xf841870, 0x0, 0x0, 0x0)
	/Users/ewbankkit/go/pkg/mod/google.golang.org/[email protected]/server.go:1194 +0x52b
google.golang.org/grpc.(*Server).handleStream(0xc0005ea8c0, 0xae9ce38, 0xc002071200, 0xc001c74800, 0x0)
	/Users/ewbankkit/go/pkg/mod/google.golang.org/[email protected]/server.go:1517 +0xd0c
google.golang.org/grpc.(*Server).serveStreams.func1.2(0xc001689760, 0xc0005ea8c0, 0xae9ce38, 0xc002071200, 0xc001c74800)
	/Users/ewbankkit/go/pkg/mod/google.golang.org/[email protected]/server.go:859 +0xab
created by google.golang.org/grpc.(*Server).serveStreams.func1
	/Users/ewbankkit/go/pkg/mod/google.golang.org/[email protected]/server.go:857 +0x1fd
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	47.881s
FAIL
make: *** [testacc] Error 1

After:

% make testacc PKG_NAME=internal/service/ec2 TESTARGS='-run=TestAccEC2NetworkInterfaceDataSource_attachment'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccEC2NetworkInterfaceDataSource_attachment -timeout 180m
=== RUN   TestAccEC2NetworkInterfaceDataSource_attachment
=== PAUSE TestAccEC2NetworkInterfaceDataSource_attachment
=== CONT  TestAccEC2NetworkInterfaceDataSource_attachment
--- PASS: TestAccEC2NetworkInterfaceDataSource_attachment (324.17s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	328.908s
@ewbankkit
Add CHANGELOG entry.
e8bd69d
@ewbankkit
d/aws_network_interfaces: Use 'FindeNetworkInterfaces'.
90e32a2 
Acceptance test output:

% make testacc PKG_NAME=internal/service/ec2 TESTARGS='-run=TestAccEC2NetworkInterfacesDataSource_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccEC2NetworkInterfacesDataSource_ -timeout 180m
=== RUN   TestAccEC2NetworkInterfacesDataSource_filter
=== PAUSE TestAccEC2NetworkInterfacesDataSource_filter
=== RUN   TestAccEC2NetworkInterfacesDataSource_tags
=== PAUSE TestAccEC2NetworkInterfacesDataSource_tags
=== CONT  TestAccEC2NetworkInterfacesDataSource_filter
=== CONT  TestAccEC2NetworkInterfacesDataSource_tags
--- PASS: TestAccEC2NetworkInterfacesDataSource_filter (30.36s)
--- PASS: TestAccEC2NetworkInterfacesDataSource_tags (30.42s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	34.394s
@ewbankkit
'detachNetworkInterface' -> 'DetachNetworkInterface' and 'deleteNetwo…
f7c5071 
…rkInterface' -> 'DeleteNetworkInterface'.
@ewbankkit
r/aws_network_interface: Use 'PropagationTimeout'.
c7777cc
@ewbankkit
'networkInterfaceDetachedTimeout' -> 'NetworkInterfaceDetachedTimeout'.
84e0cd7
@ewbankkit
r/aws_elb: Use ENI detach and delete functionality from 'internal/ser…
bac504e 
…vice/ec2'.

r/aws_lb: Use ENI detach and delete functionality from 'internal/service/ec2'.

Acceptance test output:

% make testacc PKG_NAME=internal/service/elbv2 TESTARGS='-run=TestAccELBV2LoadBalancer_ALB_basic\|TestAccELBV2LoadBalancer_NLB_basic\|TestAccELBV2LoadBalancer_networkLoadBalancerEIP'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elbv2/... -v -count 1 -parallel 20 -run=TestAccELBV2LoadBalancer_ALB_basic\|TestAccELBV2LoadBalancer_NLB_basic\|TestAccELBV2LoadBalancer_networkLoadBalancerEIP -timeout 180m
=== RUN   TestAccELBV2LoadBalancer_ALB_basic
=== PAUSE TestAccELBV2LoadBalancer_ALB_basic
=== RUN   TestAccELBV2LoadBalancer_NLB_basic
=== PAUSE TestAccELBV2LoadBalancer_NLB_basic
=== RUN   TestAccELBV2LoadBalancer_networkLoadBalancerEIP
=== PAUSE TestAccELBV2LoadBalancer_networkLoadBalancerEIP
=== CONT  TestAccELBV2LoadBalancer_ALB_basic
=== CONT  TestAccELBV2LoadBalancer_networkLoadBalancerEIP
=== CONT  TestAccELBV2LoadBalancer_NLB_basic
--- PASS: TestAccELBV2LoadBalancer_ALB_basic (248.26s)
--- PASS: TestAccELBV2LoadBalancer_networkLoadBalancerEIP (286.27s)
--- PASS: TestAccELBV2LoadBalancer_NLB_basic (401.09s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elbv2	404.737s
@ewbankkit ewbankkit force-pushed the td-network_interface_functions branch from e6c5ef1 to bac504e Compare November 5, 2021 18:13
@github-actions github-actions bot added the tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. label Nov 5, 2021
@ewbankkit
r/aws_internet_gateway: Start to use Find/Status/Wait pattern.
d13b6c1 
Acceptance test output:

% make testacc PKG_NAME=internal/service/ec2 TESTARGS='-run=TestAccEC2InternetGateway_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccEC2InternetGateway_basic -timeout 180m
=== RUN   TestAccEC2InternetGateway_basic
=== PAUSE TestAccEC2InternetGateway_basic
=== CONT  TestAccEC2InternetGateway_basic
--- PASS: TestAccEC2InternetGateway_basic (68.36s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	72.002s
@ewbankkit
r/aws_internet_gateway: Tidy up attach/detach.
a1ddfba 
d/aws_internet_gateway: Use 'FindInternetGateway'.

Acceptance test output:

% make testacc PKG_NAME=internal/service/ec2 TESTARGS='-run=TestAccEC2InternetGatewayDataSource_\|TestAccEC2InternetGateway_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccEC2InternetGatewayDataSource_\|TestAccEC2InternetGateway_ -timeout 180m
=== RUN   TestAccEC2InternetGatewayDataSource_basic
=== PAUSE TestAccEC2InternetGatewayDataSource_basic
=== RUN   TestAccEC2InternetGateway_basic
=== PAUSE TestAccEC2InternetGateway_basic
=== RUN   TestAccEC2InternetGateway_Tags
=== PAUSE TestAccEC2InternetGateway_Tags
=== RUN   TestAccEC2InternetGateway_disappears
=== PAUSE TestAccEC2InternetGateway_disappears
=== CONT  TestAccEC2InternetGatewayDataSource_basic
=== CONT  TestAccEC2InternetGateway_disappears
=== CONT  TestAccEC2InternetGateway_Tags
=== CONT  TestAccEC2InternetGateway_basic
--- PASS: TestAccEC2InternetGateway_disappears (12.46s)
--- PASS: TestAccEC2InternetGateway_basic (16.59s)
--- PASS: TestAccEC2InternetGatewayDataSource_basic (25.05s)
--- PASS: TestAccEC2InternetGateway_Tags (33.58s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	37.188s
@ewbankkit
r/aws_internet_gateway: Add 'TestAccEC2InternetGateway_Attachment'.
437bfc4 
Acceptance test output:

% make testacc PKG_NAME=internal/service/ec2 TESTARGS='-run=TestAccEC2InternetGateway_Attachment'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccEC2InternetGateway_Attachment -timeout 180m
=== RUN   TestAccEC2InternetGateway_Attachment
=== PAUSE TestAccEC2InternetGateway_Attachment
=== CONT  TestAccEC2InternetGateway_Attachment
--- PASS: TestAccEC2InternetGateway_Attachment (43.51s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	47.120s
@ewbankkit
'cleanupNetworkInterfaces' -> 'CleanupNetworkInterfaces' as it's used…
d811f53 
… by sweepers.
@ewbankkit
r/aws_internet_gateway: Retry detach on DependencyViolation error.
e9d2206
@ewbankkit
Tidy up EC2 Internet Gateway sweeper.
cef5fba
@github-actions github-actions bot added the sweeper Pertains to changes to or issues with the sweeper. label Nov 7, 2021
ewbankkit
ewbankkit approved these changes Nov 8, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc PKG_NAME=internal/service/ec2 TESTARGS='-run=TestAccEC2NetworkInterfaceDataSource_'          
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccEC2NetworkInterfaceDataSource_ -timeout 180m
=== RUN   TestAccEC2NetworkInterfaceDataSource_basic
=== PAUSE TestAccEC2NetworkInterfaceDataSource_basic
=== RUN   TestAccEC2NetworkInterfaceDataSource_filters
=== PAUSE TestAccEC2NetworkInterfaceDataSource_filters
=== RUN   TestAccEC2NetworkInterfaceDataSource_carrierIPAssociation
=== PAUSE TestAccEC2NetworkInterfaceDataSource_carrierIPAssociation
=== RUN   TestAccEC2NetworkInterfaceDataSource_publicIPAssociation
=== PAUSE TestAccEC2NetworkInterfaceDataSource_publicIPAssociation
=== RUN   TestAccEC2NetworkInterfaceDataSource_attachment
=== PAUSE TestAccEC2NetworkInterfaceDataSource_attachment
=== CONT  TestAccEC2NetworkInterfaceDataSource_basic
=== CONT  TestAccEC2NetworkInterfaceDataSource_publicIPAssociation
=== CONT  TestAccEC2NetworkInterfaceDataSource_attachment
=== CONT  TestAccEC2NetworkInterfaceDataSource_carrierIPAssociation
=== CONT  TestAccEC2NetworkInterfaceDataSource_filters
--- PASS: TestAccEC2NetworkInterfaceDataSource_filters (32.19s)
--- PASS: TestAccEC2NetworkInterfaceDataSource_basic (32.30s)
--- PASS: TestAccEC2NetworkInterfaceDataSource_carrierIPAssociation (37.14s)
--- PASS: TestAccEC2NetworkInterfaceDataSource_publicIPAssociation (43.72s)
--- PASS: TestAccEC2NetworkInterfaceDataSource_attachment (336.28s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	340.329s
% make testacc PKG_NAME=internal/service/ec2 TESTARGS='-run=TestAccEC2NetworkInterfacesDataSource_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccEC2NetworkInterfacesDataSource_ -timeout 180m
=== RUN   TestAccEC2NetworkInterfacesDataSource_filter
=== PAUSE TestAccEC2NetworkInterfacesDataSource_filter
=== RUN   TestAccEC2NetworkInterfacesDataSource_tags
=== PAUSE TestAccEC2NetworkInterfacesDataSource_tags
=== CONT  TestAccEC2NetworkInterfacesDataSource_filter
=== CONT  TestAccEC2NetworkInterfacesDataSource_tags
--- PASS: TestAccEC2NetworkInterfacesDataSource_filter (30.36s)
--- PASS: TestAccEC2NetworkInterfacesDataSource_tags (30.42s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	34.394s
% make testacc PKG_NAME=internal/service/elb TESTARGS='-run=TestAccELBLoadBalancer_basic\|TestAccELBLoadBalancer_availabilityZones'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elb/... -v -count 1 -parallel 20 -run=TestAccELBLoadBalancer_basic\|TestAccELBLoadBalancer_availabilityZones -timeout 180m
=== RUN   TestAccELBLoadBalancer_basic
=== PAUSE TestAccELBLoadBalancer_basic
=== RUN   TestAccELBLoadBalancer_availabilityZones
=== PAUSE TestAccELBLoadBalancer_availabilityZones
=== CONT  TestAccELBLoadBalancer_basic
=== CONT  TestAccELBLoadBalancer_availabilityZones
--- PASS: TestAccELBLoadBalancer_basic (26.58s)
--- PASS: TestAccELBLoadBalancer_availabilityZones (37.87s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elb	41.902s
% make testacc PKG_NAME=internal/service/elbv2 TESTARGS='-run=TestAccELBV2LoadBalancer_ALB_basic\|TestAccELBV2LoadBalancer_NLB_basic\|TestAccELBV2LoadBalancer_networkLoadBalancerEIP'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elbv2/... -v -count 1 -parallel 20 -run=TestAccELBV2LoadBalancer_ALB_basic\|TestAccELBV2LoadBalancer_NLB_basic\|TestAccELBV2LoadBalancer_networkLoadBalancerEIP -timeout 180m
=== RUN   TestAccELBV2LoadBalancer_ALB_basic
=== PAUSE TestAccELBV2LoadBalancer_ALB_basic
=== RUN   TestAccELBV2LoadBalancer_NLB_basic
=== PAUSE TestAccELBV2LoadBalancer_NLB_basic
=== RUN   TestAccELBV2LoadBalancer_networkLoadBalancerEIP
=== PAUSE TestAccELBV2LoadBalancer_networkLoadBalancerEIP
=== CONT  TestAccELBV2LoadBalancer_ALB_basic
=== CONT  TestAccELBV2LoadBalancer_networkLoadBalancerEIP
=== CONT  TestAccELBV2LoadBalancer_NLB_basic
--- PASS: TestAccELBV2LoadBalancer_ALB_basic (248.26s)
--- PASS: TestAccELBV2LoadBalancer_networkLoadBalancerEIP (286.27s)
--- PASS: TestAccELBV2LoadBalancer_NLB_basic (401.09s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elbv2	404.737s
% make testacc PKG_NAME=internal/service/ec2 TESTARGS='-run=TestAccEC2InternetGatewayDataSource_\|TestAccEC2InternetGateway_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccEC2InternetGatewayDataSource_\|TestAccEC2InternetGateway_ -timeout 180m
=== RUN   TestAccEC2InternetGatewayDataSource_basic
=== PAUSE TestAccEC2InternetGatewayDataSource_basic
=== RUN   TestAccEC2InternetGateway_basic
=== PAUSE TestAccEC2InternetGateway_basic
=== RUN   TestAccEC2InternetGateway_disappears
=== PAUSE TestAccEC2InternetGateway_disappears
=== RUN   TestAccEC2InternetGateway_Attachment
=== PAUSE TestAccEC2InternetGateway_Attachment
=== RUN   TestAccEC2InternetGateway_Tags
=== PAUSE TestAccEC2InternetGateway_Tags
=== CONT  TestAccEC2InternetGatewayDataSource_basic
=== CONT  TestAccEC2InternetGateway_Attachment
=== CONT  TestAccEC2InternetGateway_disappears
=== CONT  TestAccEC2InternetGateway_Tags
=== CONT  TestAccEC2InternetGateway_basic
--- PASS: TestAccEC2InternetGateway_disappears (11.91s)
--- PASS: TestAccEC2InternetGateway_basic (15.61s)
--- PASS: TestAccEC2InternetGatewayDataSource_basic (25.05s)
--- PASS: TestAccEC2InternetGateway_Tags (33.96s)
--- PASS: TestAccEC2InternetGateway_Attachment (44.59s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	48.016s
% make testacc PKG_NAME=internal/service/ec2 TESTARGS='-run=TestAccEC2EIPAssociation_'    
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccEC2EIPAssociation_ -timeout 180m
=== RUN   TestAccEC2EIPAssociation_instance
=== PAUSE TestAccEC2EIPAssociation_instance
=== RUN   TestAccEC2EIPAssociation_networkInterface
=== PAUSE TestAccEC2EIPAssociation_networkInterface
=== RUN   TestAccEC2EIPAssociation_basic
=== PAUSE TestAccEC2EIPAssociation_basic
=== RUN   TestAccEC2EIPAssociation_ec2Classic
=== PAUSE TestAccEC2EIPAssociation_ec2Classic
=== RUN   TestAccEC2EIPAssociation_spotInstance
=== PAUSE TestAccEC2EIPAssociation_spotInstance
=== RUN   TestAccEC2EIPAssociation_disappears
=== PAUSE TestAccEC2EIPAssociation_disappears
=== CONT  TestAccEC2EIPAssociation_instance
=== CONT  TestAccEC2EIPAssociation_spotInstance
=== CONT  TestAccEC2EIPAssociation_disappears
=== CONT  TestAccEC2EIPAssociation_ec2Classic
=== CONT  TestAccEC2EIPAssociation_networkInterface
=== CONT  TestAccEC2EIPAssociation_basic
--- PASS: TestAccEC2EIPAssociation_networkInterface (33.41s)
--- PASS: TestAccEC2EIPAssociation_ec2Classic (106.02s)
--- PASS: TestAccEC2EIPAssociation_disappears (117.47s)
--- PASS: TestAccEC2EIPAssociation_instance (132.99s)
--- PASS: TestAccEC2EIPAssociation_spotInstance (137.40s)
--- PASS: TestAccEC2EIPAssociation_basic (465.99s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	469.579s
GovCloud
% make testacc PKG_NAME=internal/service/ec2 TESTARGS='-run=TestAccEC2NetworkInterfaceDataSource_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccEC2NetworkInterfaceDataSource_ -timeout 180m
=== RUN   TestAccEC2NetworkInterfaceDataSource_basic
=== PAUSE TestAccEC2NetworkInterfaceDataSource_basic
=== RUN   TestAccEC2NetworkInterfaceDataSource_filters
=== PAUSE TestAccEC2NetworkInterfaceDataSource_filters
=== RUN   TestAccEC2NetworkInterfaceDataSource_carrierIPAssociation
=== PAUSE TestAccEC2NetworkInterfaceDataSource_carrierIPAssociation
=== RUN   TestAccEC2NetworkInterfaceDataSource_publicIPAssociation
=== PAUSE TestAccEC2NetworkInterfaceDataSource_publicIPAssociation
=== RUN   TestAccEC2NetworkInterfaceDataSource_attachment
=== PAUSE TestAccEC2NetworkInterfaceDataSource_attachment
=== CONT  TestAccEC2NetworkInterfaceDataSource_basic
=== CONT  TestAccEC2NetworkInterfaceDataSource_publicIPAssociation
=== CONT  TestAccEC2NetworkInterfaceDataSource_attachment
=== CONT  TestAccEC2NetworkInterfaceDataSource_carrierIPAssociation
=== CONT  TestAccEC2NetworkInterfaceDataSource_filters
=== CONT  TestAccEC2NetworkInterfaceDataSource_carrierIPAssociation
    carrier_gateway_test.go:196: skipping since no Wavelength Zones are available
--- SKIP: TestAccEC2NetworkInterfaceDataSource_carrierIPAssociation (1.78s)
--- PASS: TestAccEC2NetworkInterfaceDataSource_basic (34.57s)
--- PASS: TestAccEC2NetworkInterfaceDataSource_filters (34.71s)
--- PASS: TestAccEC2NetworkInterfaceDataSource_publicIPAssociation (36.59s)
--- PASS: TestAccEC2NetworkInterfaceDataSource_attachment (320.17s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	323.636s
% make testacc PKG_NAME=internal/service/ec2 TESTARGS='-run=TestAccEC2NetworkInterfacesDataSource_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccEC2NetworkInterfacesDataSource_ -timeout 180m
=== RUN   TestAccEC2NetworkInterfacesDataSource_filter
=== PAUSE TestAccEC2NetworkInterfacesDataSource_filter
=== RUN   TestAccEC2NetworkInterfacesDataSource_tags
=== PAUSE TestAccEC2NetworkInterfacesDataSource_tags
=== CONT  TestAccEC2NetworkInterfacesDataSource_filter
=== CONT  TestAccEC2NetworkInterfacesDataSource_tags
--- PASS: TestAccEC2NetworkInterfacesDataSource_filter (32.22s)
--- PASS: TestAccEC2NetworkInterfacesDataSource_tags (32.68s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	37.211s
% make testacc PKG_NAME=internal/service/elb TESTARGS='-run=TestAccELBLoadBalancer_basic\|TestAccELBLoadBalancer_availabilityZones'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elb/... -v -count 1 -parallel 20 -run=TestAccELBLoadBalancer_basic\|TestAccELBLoadBalancer_availabilityZones -timeout 180m
=== RUN   TestAccELBLoadBalancer_basic
=== PAUSE TestAccELBLoadBalancer_basic
=== RUN   TestAccELBLoadBalancer_availabilityZones
=== PAUSE TestAccELBLoadBalancer_availabilityZones
=== CONT  TestAccELBLoadBalancer_basic
=== CONT  TestAccELBLoadBalancer_availabilityZones
--- PASS: TestAccELBLoadBalancer_basic (29.05s)
--- PASS: TestAccELBLoadBalancer_availabilityZones (45.90s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elb	49.373s
% make testacc PKG_NAME=internal/service/elbv2 TESTARGS='-run=TestAccELBV2LoadBalancer_ALB_basic\|TestAccELBV2LoadBalancer_NLB_basic\|TestAccELBV2LoadBalancer_networkLoadBalancerEIP'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elbv2/... -v -count 1 -parallel 20 -run=TestAccELBV2LoadBalancer_ALB_basic\|TestAccELBV2LoadBalancer_NLB_basic\|TestAccELBV2LoadBalancer_networkLoadBalancerEIP -timeout 180m
=== RUN   TestAccELBV2LoadBalancer_ALB_basic
=== PAUSE TestAccELBV2LoadBalancer_ALB_basic
=== RUN   TestAccELBV2LoadBalancer_NLB_basic
=== PAUSE TestAccELBV2LoadBalancer_NLB_basic
=== RUN   TestAccELBV2LoadBalancer_networkLoadBalancerEIP
=== PAUSE TestAccELBV2LoadBalancer_networkLoadBalancerEIP
=== CONT  TestAccELBV2LoadBalancer_ALB_basic
=== CONT  TestAccELBV2LoadBalancer_networkLoadBalancerEIP
=== CONT  TestAccELBV2LoadBalancer_NLB_basic
--- PASS: TestAccELBV2LoadBalancer_ALB_basic (209.12s)
--- PASS: TestAccELBV2LoadBalancer_networkLoadBalancerEIP (232.04s)
--- PASS: TestAccELBV2LoadBalancer_NLB_basic (250.96s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elbv2	254.783s
% make testacc PKG_NAME=internal/service/ec2 TESTARGS='-run=TestAccEC2InternetGatewayDataSource_\|TestAccEC2InternetGateway_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccEC2InternetGatewayDataSource_\|TestAccEC2InternetGateway_ -timeout 180m
=== RUN   TestAccEC2InternetGatewayDataSource_basic
=== PAUSE TestAccEC2InternetGatewayDataSource_basic
=== RUN   TestAccEC2InternetGateway_basic
=== PAUSE TestAccEC2InternetGateway_basic
=== RUN   TestAccEC2InternetGateway_disappears
=== PAUSE TestAccEC2InternetGateway_disappears
=== RUN   TestAccEC2InternetGateway_Attachment
=== PAUSE TestAccEC2InternetGateway_Attachment
=== RUN   TestAccEC2InternetGateway_Tags
=== PAUSE TestAccEC2InternetGateway_Tags
=== CONT  TestAccEC2InternetGatewayDataSource_basic
=== CONT  TestAccEC2InternetGateway_Attachment
=== CONT  TestAccEC2InternetGateway_disappears
=== CONT  TestAccEC2InternetGateway_basic
=== CONT  TestAccEC2InternetGateway_Tags
--- PASS: TestAccEC2InternetGateway_disappears (16.80s)
--- PASS: TestAccEC2InternetGateway_basic (21.46s)
--- PASS: TestAccEC2InternetGatewayDataSource_basic (30.49s)
--- PASS: TestAccEC2InternetGateway_Tags (45.97s)
--- PASS: TestAccEC2InternetGateway_Attachment (52.06s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	55.458s
% make testacc PKG_NAME=internal/service/ec2 TESTARGS='-run=TestAccEC2EIPAssociation_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccEC2EIPAssociation_ -timeout 180m
=== RUN   TestAccEC2EIPAssociation_instance
=== PAUSE TestAccEC2EIPAssociation_instance
=== RUN   TestAccEC2EIPAssociation_networkInterface
=== PAUSE TestAccEC2EIPAssociation_networkInterface
=== RUN   TestAccEC2EIPAssociation_basic
=== PAUSE TestAccEC2EIPAssociation_basic
=== RUN   TestAccEC2EIPAssociation_ec2Classic
=== PAUSE TestAccEC2EIPAssociation_ec2Classic
=== RUN   TestAccEC2EIPAssociation_spotInstance
=== PAUSE TestAccEC2EIPAssociation_spotInstance
=== RUN   TestAccEC2EIPAssociation_disappears
=== PAUSE TestAccEC2EIPAssociation_disappears
=== CONT  TestAccEC2EIPAssociation_instance
=== CONT  TestAccEC2EIPAssociation_spotInstance
=== CONT  TestAccEC2EIPAssociation_basic
=== CONT  TestAccEC2EIPAssociation_disappears
=== CONT  TestAccEC2EIPAssociation_ec2Classic
=== CONT  TestAccEC2EIPAssociation_networkInterface
=== CONT  TestAccEC2EIPAssociation_ec2Classic
    ec2_classic.go:56: this test can only run in EC2-Classic, platforms available in us-gov-west-1: ["VPC"]
--- SKIP: TestAccEC2EIPAssociation_ec2Classic (2.42s)
--- PASS: TestAccEC2EIPAssociation_networkInterface (36.56s)
--- PASS: TestAccEC2EIPAssociation_instance (78.28s)
--- PASS: TestAccEC2EIPAssociation_spotInstance (95.84s)
--- PASS: TestAccEC2EIPAssociation_disappears (136.69s)
--- PASS: TestAccEC2EIPAssociation_basic (398.12s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	401.534s

@ewbankkit
Copy link
Contributor

@kamilturek Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 8a6de9d into hashicorp:main Nov 8, 2021
@github-actions github-actions bot added this to the v3.65.0 milestone Nov 8, 2021
@github-actions
Copy link

This functionality has been released in v3.65.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@kamilturek kamilturek deleted the td-network_interface_functions branch February 11, 2022 16:56
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
service/ec2 Issues and PRs that pertain to the ec2 service. service/elb Issues and PRs that pertain to the elb service. service/elbv2 Issues and PRs that pertain to the elbv2 service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.65.0
2 participants
@kamilturek @ewbankkit