tech debt: three identical implementations of detaching and deleting ENIs in EC2, ELB, and ELBv2 packages

[gdavison]

The same implementations of detaching and deleting ENIs have been used across the EC2, ELB, and ELBv2 packages. These should be consolidated into one function that can be used across multiple packages.

Since ENIs are part of EC2, the functions should be located in that package.

Affected Resources

• aws_elb
• aws_lb
• aws_network_interface
• aws_network_interface_attachment

[ewbankkit]

There's also findPublicNetworkInterfacesForVpcID in ec2/internet_gateway.go 😄.

[ewbankkit]

aws_network_interface and aws_network_interface_attachment addressed in #21265.

[github-actions]

This functionality has been released in v3.65.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.