-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/sagemaker_endpoint_config - add support for async_inference_config
#20809
r/sagemaker_endpoint_config - add support for async_inference_config
#20809
Conversation
async_inference_config
async_inference_config
+ production_variants.code_dump_config
async_inference_config
+ production_variants.code_dump_config
async_inference_config
a6d247d
to
817e881
Compare
async_inference_config
async_inference_config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
Commercial
% make testacc TESTARGS='-run=TestAccAWSSagemakerEndpointConfiguration_'
TestAccAWSSagemakerEndpointConfiguration_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSagemakerEndpointConfiguration_ -timeout 180m
=== RUN TestAccAWSSagemakerEndpointConfiguration_basic
=== PAUSE TestAccAWSSagemakerEndpointConfiguration_basic
=== RUN TestAccAWSSagemakerEndpointConfiguration_productionVariants_InitialVariantWeight
=== PAUSE TestAccAWSSagemakerEndpointConfiguration_productionVariants_InitialVariantWeight
=== RUN TestAccAWSSagemakerEndpointConfiguration_productionVariants_AcceleratorType
=== PAUSE TestAccAWSSagemakerEndpointConfiguration_productionVariants_AcceleratorType
=== RUN TestAccAWSSagemakerEndpointConfiguration_kmsKeyId
=== PAUSE TestAccAWSSagemakerEndpointConfiguration_kmsKeyId
=== RUN TestAccAWSSagemakerEndpointConfiguration_tags
=== PAUSE TestAccAWSSagemakerEndpointConfiguration_tags
=== RUN TestAccAWSSagemakerEndpointConfiguration_dataCaptureConfig
=== PAUSE TestAccAWSSagemakerEndpointConfiguration_dataCaptureConfig
=== RUN TestAccAWSSagemakerEndpointConfiguration_disappears
=== PAUSE TestAccAWSSagemakerEndpointConfiguration_disappears
=== RUN TestAccAWSSagemakerEndpointConfiguration_async
=== PAUSE TestAccAWSSagemakerEndpointConfiguration_async
=== RUN TestAccAWSSagemakerEndpointConfiguration_async_notifConfig
=== PAUSE TestAccAWSSagemakerEndpointConfiguration_async_notifConfig
=== RUN TestAccAWSSagemakerEndpointConfiguration_async_client
=== PAUSE TestAccAWSSagemakerEndpointConfiguration_async_client
=== CONT TestAccAWSSagemakerEndpointConfiguration_basic
=== CONT TestAccAWSSagemakerEndpointConfiguration_disappears
=== CONT TestAccAWSSagemakerEndpointConfiguration_tags
=== CONT TestAccAWSSagemakerEndpointConfiguration_kmsKeyId
=== CONT TestAccAWSSagemakerEndpointConfiguration_dataCaptureConfig
=== CONT TestAccAWSSagemakerEndpointConfiguration_productionVariants_AcceleratorType
=== CONT TestAccAWSSagemakerEndpointConfiguration_async
=== CONT TestAccAWSSagemakerEndpointConfiguration_productionVariants_InitialVariantWeight
=== CONT TestAccAWSSagemakerEndpointConfiguration_async_client
=== CONT TestAccAWSSagemakerEndpointConfiguration_async_notifConfig
--- PASS: TestAccAWSSagemakerEndpointConfiguration_async (49.91s)
--- PASS: TestAccAWSSagemakerEndpointConfiguration_async_notifConfig (52.53s)
--- PASS: TestAccAWSSagemakerEndpointConfiguration_productionVariants_InitialVariantWeight (54.57s)
--- PASS: TestAccAWSSagemakerEndpointConfiguration_kmsKeyId (62.21s)
--- PASS: TestAccAWSSagemakerEndpointConfiguration_dataCaptureConfig (62.73s)
--- PASS: TestAccAWSSagemakerEndpointConfiguration_disappears (65.15s)
--- PASS: TestAccAWSSagemakerEndpointConfiguration_basic (67.16s)
--- PASS: TestAccAWSSagemakerEndpointConfiguration_async_client (68.05s)
--- PASS: TestAccAWSSagemakerEndpointConfiguration_productionVariants_AcceleratorType (71.16s)
--- PASS: TestAccAWSSagemakerEndpointConfiguration_tags (101.83s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 105.477s
GovCloud
% make testacc TESTARGS='-run=TestAccAWSSagemakerEndpointConfiguration_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSagemakerEndpointConfiguration_ -timeout 180m
=== RUN TestAccAWSSagemakerEndpointConfiguration_basic
=== PAUSE TestAccAWSSagemakerEndpointConfiguration_basic
=== RUN TestAccAWSSagemakerEndpointConfiguration_productionVariants_InitialVariantWeight
=== PAUSE TestAccAWSSagemakerEndpointConfiguration_productionVariants_InitialVariantWeight
=== RUN TestAccAWSSagemakerEndpointConfiguration_productionVariants_AcceleratorType
=== PAUSE TestAccAWSSagemakerEndpointConfiguration_productionVariants_AcceleratorType
=== RUN TestAccAWSSagemakerEndpointConfiguration_kmsKeyId
=== PAUSE TestAccAWSSagemakerEndpointConfiguration_kmsKeyId
=== RUN TestAccAWSSagemakerEndpointConfiguration_tags
=== PAUSE TestAccAWSSagemakerEndpointConfiguration_tags
=== RUN TestAccAWSSagemakerEndpointConfiguration_dataCaptureConfig
=== PAUSE TestAccAWSSagemakerEndpointConfiguration_dataCaptureConfig
=== RUN TestAccAWSSagemakerEndpointConfiguration_disappears
=== PAUSE TestAccAWSSagemakerEndpointConfiguration_disappears
=== RUN TestAccAWSSagemakerEndpointConfiguration_async
=== PAUSE TestAccAWSSagemakerEndpointConfiguration_async
=== RUN TestAccAWSSagemakerEndpointConfiguration_async_notifConfig
=== PAUSE TestAccAWSSagemakerEndpointConfiguration_async_notifConfig
=== RUN TestAccAWSSagemakerEndpointConfiguration_async_client
=== PAUSE TestAccAWSSagemakerEndpointConfiguration_async_client
=== CONT TestAccAWSSagemakerEndpointConfiguration_basic
=== CONT TestAccAWSSagemakerEndpointConfiguration_async_notifConfig
=== CONT TestAccAWSSagemakerEndpointConfiguration_async_client
=== CONT TestAccAWSSagemakerEndpointConfiguration_tags
=== CONT TestAccAWSSagemakerEndpointConfiguration_productionVariants_AcceleratorType
=== CONT TestAccAWSSagemakerEndpointConfiguration_dataCaptureConfig
=== CONT TestAccAWSSagemakerEndpointConfiguration_kmsKeyId
=== CONT TestAccAWSSagemakerEndpointConfiguration_async
=== CONT TestAccAWSSagemakerEndpointConfiguration_productionVariants_InitialVariantWeight
=== CONT TestAccAWSSagemakerEndpointConfiguration_disappears
=== CONT TestAccAWSSagemakerEndpointConfiguration_async
provider_test.go:1123: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
Error: error creating SageMaker Endpoint Configuration: ValidationException: AsyncInferenceConfig parameter is not supported in region us-gov-west-1.
status code: 400, request id: 757686ee-4d15-44a1-937a-37b6dc77d731
with aws_sagemaker_endpoint_configuration.test,
on terraform_plugin_test.tf line 43, in resource "aws_sagemaker_endpoint_configuration" "test":
43: resource "aws_sagemaker_endpoint_configuration" "test" {
=== CONT TestAccAWSSagemakerEndpointConfiguration_async_client
provider_test.go:1123: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
Error: error creating SageMaker Endpoint Configuration: ValidationException: AsyncInferenceConfig parameter is not supported in region us-gov-west-1.
status code: 400, request id: 900eb623-ab1e-411d-a1b3-27b83b2b7c53
with aws_sagemaker_endpoint_configuration.test,
on terraform_plugin_test.tf line 43, in resource "aws_sagemaker_endpoint_configuration" "test":
43: resource "aws_sagemaker_endpoint_configuration" "test" {
--- SKIP: TestAccAWSSagemakerEndpointConfiguration_async (42.88s)
=== CONT TestAccAWSSagemakerEndpointConfiguration_productionVariants_AcceleratorType
provider_test.go:1123: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
Error: error creating SageMaker Endpoint Configuration: ValidationException: Accelerator type ml.eia1.medium is not supported for the chosen region.
status code: 400, request id: ac0371ec-3c85-43c5-9565-3753e7d87740
with aws_sagemaker_endpoint_configuration.test,
on terraform_plugin_test.tf line 32, in resource "aws_sagemaker_endpoint_configuration" "test":
32: resource "aws_sagemaker_endpoint_configuration" "test" {
--- SKIP: TestAccAWSSagemakerEndpointConfiguration_async_client (46.94s)
--- PASS: TestAccAWSSagemakerEndpointConfiguration_disappears (47.33s)
--- SKIP: TestAccAWSSagemakerEndpointConfiguration_productionVariants_AcceleratorType (49.42s)
--- PASS: TestAccAWSSagemakerEndpointConfiguration_basic (58.56s)
--- PASS: TestAccAWSSagemakerEndpointConfiguration_productionVariants_InitialVariantWeight (60.55s)
--- PASS: TestAccAWSSagemakerEndpointConfiguration_kmsKeyId (62.98s)
--- PASS: TestAccAWSSagemakerEndpointConfiguration_dataCaptureConfig (63.58s)
=== CONT TestAccAWSSagemakerEndpointConfiguration_async_notifConfig
provider_test.go:1123: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
Error: error creating SageMaker Endpoint Configuration: ValidationException: AsyncInferenceConfig parameter is not supported in region us-gov-west-1.
status code: 400, request id: 7f3a8d2a-eace-46b0-8676-224a32764583
with aws_sagemaker_endpoint_configuration.test,
on terraform_plugin_test.tf line 47, in resource "aws_sagemaker_endpoint_configuration" "test":
47: resource "aws_sagemaker_endpoint_configuration" "test" {
--- SKIP: TestAccAWSSagemakerEndpointConfiguration_async_notifConfig (70.72s)
--- PASS: TestAccAWSSagemakerEndpointConfiguration_tags (83.16s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 86.526s
@DrFaust92 Thanks for the contribution 🎉 👏. |
This functionality has been released in v3.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #20699
Output from acceptance testing: