Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AsyncInferenceConfig block to aws_sagemaker_endpoint_configuration #20699

Closed
zachchurchill opened this issue Aug 26, 2021 · 3 comments · Fixed by #20809
Closed

Add AsyncInferenceConfig block to aws_sagemaker_endpoint_configuration #20699

zachchurchill opened this issue Aug 26, 2021 · 3 comments · Fixed by #20809
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/sagemaker Issues and PRs that pertain to the sagemaker service.
Milestone

Comments

@zachchurchill
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

AWS announced on Aug. 20, 2021 that SageMaker Endpoints can now be called asynchronously via a new parameter block when creating Endpoint Configurations, namely the AsyncInferenceConfig block. This additional block will signal to the AWS infrastructure that the Endpoint will only take asynchronous invocations, so no other changes are needed from the user's standpoint besides including the AsyncInferenceConfig block when creating the Endpoint Configuration.

New or Affected Resource(s)

  • aws_sagemaker_endpoint_configuration

Potential Terraform Configuration

resource "aws_sagemaker_endpoint_configuration" "main" {
  async_inference_config {
    client_config {
        max_concurrent_invocations_per_instance = 1
    }

    output_config {
      kms_key_arn = aws_kms_key.main.arn

      s3_output_path = "s3://${aws_s3_bucket.main.id}/output"

      notification_config {
          error_topic   = aws_sns_topic.error.arn
          success_topic = aws_sns_topic.success.arn
      }
    }
  }
  ... etc
}

References

@zachchurchill zachchurchill added the enhancement Requests to existing resources that expand the functionality or scope. label Aug 26, 2021
@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/sagemaker Issues and PRs that pertain to the sagemaker service. labels Aug 26, 2021
@zachchurchill
Copy link
Author

One thing to note from creating these Endpoint Configurations in the AWS UI is that an Endpoint Configuration that has an AsyncInferenceConfig can only have 1 production variant. Not sure if it should be left up to AWS to return the error to the user upon terraform apply or if this check should be baked into the Terraform schema check.
Unfortunately I can't find anywhere in the documentation where this limitation is explicitly stated so it may just be a feature of the option being new and multiple production variants not being supported yet. (Though it is worth pointing out that the InvokeEndpointAsync action doesn't include parameters for the variant name - docs)

@breathingdust breathingdust removed the needs-triage Waiting for first response or review from a maintainer. label Aug 26, 2021
@DrFaust92 DrFaust92 self-assigned this Sep 6, 2021
@DrFaust92 DrFaust92 removed their assignment Sep 6, 2021
@breathingdust breathingdust added this to the v3.59.0 milestone Sep 16, 2021
@github-actions
Copy link

This functionality has been released in v3.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jun 8, 2022

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/sagemaker Issues and PRs that pertain to the sagemaker service.
Projects
None yet
3 participants