Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aws_eks_clusters datasource #20315

Closed
wants to merge 6 commits into from
Closed

Add aws_eks_clusters datasource #20315

wants to merge 6 commits into from

Conversation

Vince-Chenal
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #13719
Relates #20251

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSEksClustersDataSource_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEksClustersDataSource_ -timeout 180m
=== RUN   TestAccAWSEksClustersDataSource_basic
=== PAUSE TestAccAWSEksClustersDataSource_basic
=== RUN   TestAccAWSEksClustersDataSource_empty
=== PAUSE TestAccAWSEksClustersDataSource_empty
=== CONT  TestAccAWSEksClustersDataSource_basic
=== CONT  TestAccAWSEksClustersDataSource_empty
--- PASS: TestAccAWSEksClustersDataSource_empty (22.89s)
--- PASS: TestAccAWSEksClustersDataSource_basic (834.26s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       834.334s

...

As I explained here, I think it's the easiest approach, what do you think ?

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. provider Pertains to the provider itself, rather than any interaction with AWS. service/eks Issues and PRs that pertain to the eks service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/L Managed by automation to categorize the size of a PR. labels Jul 26, 2021
@github-actions
Copy link

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Jul 26, 2021
@anGie44 anGie44 added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels Jul 29, 2021
@ewbankkit
Copy link
Contributor

Similar: #15204.

@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Aug 26, 2021
@ewbankkit
Copy link
Contributor

@Vince-Chenal Thanks for the contribution 🎉 👏.
In order to get this merged quicker I included your commits in #20883.

@ewbankkit ewbankkit closed this Sep 13, 2021
@Vince-Chenal Vince-Chenal deleted the add-data-eks-clusters branch September 14, 2021 12:01
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-data-source Introduces a new data source. provider Pertains to the provider itself, rather than any interaction with AWS. service/eks Issues and PRs that pertain to the eks service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants