Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support tags on additional IAM resources #17594

Closed
tylersmith34 opened this issue Feb 12, 2021 · 7 comments
Closed

Support tags on additional IAM resources #17594

tylersmith34 opened this issue Feb 12, 2021 · 7 comments
Assignees
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/iam Issues and PRs that pertain to the iam service.
Milestone

Comments

@tylersmith34
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

AWS now supports tags on additional IAM resources:

  • Customer Managed Policies
  • Instance Profiles
  • OpenID Connect Providers
  • SAML Providers
  • Server Certificates
  • Virtual MFAs

https://aws.amazon.com/about-aws/whats-new/2021/02/aws-identity-and-access-management-now-supports-tags-on-additional-resources/

New or Affected Resource(s)

  • aws_iam_instance_profile
  • aws_iam_openid_connect_provider
  • aws_iam_policy
  • aws_iam_saml_provider
  • aws_iam_server_certificate

Potential Terraform Configuration

resource "aws_iam_policy" "policy" {
  name        = "test_policy"
  path        = "/"
  description = "My test policy"
  tags = {
    key = "value"
  }

  policy = <<EOF
{
  "Version": "2012-10-17",
  "Statement": [
    {
      "Action": [
        "ec2:Describe*"
      ],
      "Effect": "Allow",
      "Resource": "*"
    }
  ]
}
EOF
}

References

@tylersmith34 tylersmith34 added the enhancement Requests to existing resources that expand the functionality or scope. label Feb 12, 2021
@ghost ghost added the service/iam Issues and PRs that pertain to the iam service. label Feb 12, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Feb 12, 2021
@anGie44 anGie44 removed the needs-triage Waiting for first response or review from a maintainer. label Feb 12, 2021
@ewbankkit
Copy link
Contributor

ewbankkit commented Feb 12, 2021

@imaginarynik
Copy link

Please provide an ETA on this.

@dmurvihill
Copy link

Any chance of adding aws_iam_group to this list?

@ewbankkit
Copy link
Contributor

@dmurvihill IAM groups do not yet support tags: https://docs.aws.amazon.com/IAM/latest/UserGuide/id_tags.html.

@bflad bflad self-assigned this Mar 26, 2021
@bflad bflad added this to the v3.35.0 milestone Mar 26, 2021
@bflad
Copy link
Contributor

bflad commented Mar 26, 2021

The following resources received tagging support in version 3.34.0 of the Terraform AWS Provider:

  • aws_iam_instance_profile
  • aws_iam_openid_connect_provider
  • aws_iam_saml_provider
  • aws_iam_server_certificate

The aws_iam_policy resource support was just merged and will release next week with version 3.35.0 of the Terraform AWS Provider. 👍 Thank you to @DrFaust92 for the implementations here.

@bflad bflad closed this as completed Mar 26, 2021
@ghost
Copy link

ghost commented Apr 1, 2021

This has been released in version 3.35.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Apr 26, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/iam Issues and PRs that pertain to the iam service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants