Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_iam_access_key: Support resource import #17321

Merged
merged 2 commits into from
Jan 29, 2021

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jan 28, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #17288

Output from acceptance testing:

--- PASS: TestAccAWSAccessKey_encrypted (12.92s)
--- PASS: TestAccAWSAccessKey_basic (12.92s)
--- PASS: TestAccAWSAccessKey_inactive (19.64s)

Reference: #17288

Output from acceptance testing:

```
--- PASS: TestAccAWSAccessKey_encrypted (12.92s)
--- PASS: TestAccAWSAccessKey_basic (12.92s)
--- PASS: TestAccAWSAccessKey_inactive (19.64s)
```
@bflad bflad requested a review from a team as a code owner January 28, 2021 00:29
@ghost ghost added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/iam Issues and PRs that pertain to the iam service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 28, 2021
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Jan 28, 2021
@YakDriver YakDriver self-assigned this Jan 28, 2021
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🥡

GovCloud:

--- PASS: TestAccAWSAccessKey_basic (18.51s)
--- PASS: TestAccAWSAccessKey_encrypted (18.68s)
--- PASS: TestAccAWSAccessKey_inactive (30.16s)

us-west-2:

--- PASS: TestAccAWSAccessKey_basic (11.36s)
--- PASS: TestAccAWSAccessKey_encrypted (11.48s)
--- PASS: TestAccAWSAccessKey_inactive (18.40s)

@bflad bflad merged commit d976d45 into main Jan 29, 2021
@bflad bflad deleted the f-aws_iam_access_key-import branch January 29, 2021 18:26
@github-actions github-actions bot added this to the v3.27.0 milestone Jan 29, 2021
github-actions bot pushed a commit that referenced this pull request Jan 29, 2021
@cedricbastin
Copy link

Thanks a lot @bflad 🙏 That was super fast!

@ghost
Copy link

ghost commented Feb 5, 2021

This has been released in version 3.27.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 1, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/iam Issues and PRs that pertain to the iam service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

resource aws_iam_access_key doesn't support import
3 participants