Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_iam_access_key: option to not store secret #17790

Closed
awoimbee opened this issue Feb 24, 2021 · 3 comments
Closed

resource/aws_iam_access_key: option to not store secret #17790

awoimbee opened this issue Feb 24, 2021 · 3 comments
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/iam Issues and PRs that pertain to the iam service. stale Old or inactive issues managed by automation, if no further action taken these will get closed.

Comments

@awoimbee
Copy link

awoimbee commented Feb 24, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Add option to not store the secret key for aws_iam_access_key resources.
It's possible for imported resources (#17321), so why not for managed ones ?
It would give us a zero trust method to manage these keys with Terraform.

New or Affected Resource(s)

  • aws_iam_access_key

Potential Terraform Configuration

resource "aws_iam_user" "jimmy" {
  name = "Jimmy Hendrix"
  path = "/"
}
resource "aws_iam_access_key" "jimmy" {
  user        = aws_iam_user.jimmy.name
  status      = "Active"
  keep_secret = false
}

-> setting keep_secret to true would recreate the aws_iam_access_key if the secret is missing from the state file

References

@awoimbee awoimbee added the enhancement Requests to existing resources that expand the functionality or scope. label Feb 24, 2021
@ghost ghost added the service/iam Issues and PRs that pertain to the iam service. label Feb 24, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Feb 24, 2021
@awoimbee
Copy link
Author

Update:
This feature/flag would be a one-way gate (setting keep_secret to false would not recreate a resource, but setting it to true would), so we can first read the secret, then remove it from the state.
Looking at the code, ForceNew in the Schema struct is a boolean, so it can't represent complex scenarios like this one.

Here are the solutions I see:

  • somehow find a workaround
  • update Schema and ForceNew to accept a closure
  • work a bit on this issue and find another way for aws_iam_access_key to output the secret without going through Terraform (give it a file path ? a url ? print to stdout ?)

@breathingdust breathingdust removed the needs-triage Waiting for first response or review from a maintainer. label Sep 4, 2021
Copy link

Marking this issue as stale due to inactivity. This helps our maintainers find and focus on the active issues. If this issue receives no comments in the next 30 days it will automatically be closed. Maintainers can also remove the stale label.

If this issue was automatically closed and you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thank you!

@github-actions github-actions bot added the stale Old or inactive issues managed by automation, if no further action taken these will get closed. label Dec 17, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 18, 2024
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/iam Issues and PRs that pertain to the iam service. stale Old or inactive issues managed by automation, if no further action taken these will get closed.
Projects
None yet
Development

No branches or pull requests

2 participants