Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a data source for aws_cloudwatch_log_groups #17151

Merged

Conversation

punkle
Copy link
Contributor

@punkle punkle commented Jan 17, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #17844

Release note for CHANGELOG:

New Data Source: data_source_aws_cloudwatch_log_groups

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSCloudwatchLogGroupsDataSource_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCloudwatchLogGroupsDataSource_basic -timeout 120m
=== RUN   TestAccAWSCloudwatchLogGroupsDataSource_basic
=== PAUSE TestAccAWSCloudwatchLogGroupsDataSource_basic
=== CONT  TestAccAWSCloudwatchLogGroupsDataSource_basic
--- PASS: TestAccAWSCloudwatchLogGroupsDataSource_basic (24.90s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       26.803s

@punkle punkle requested a review from a team as a code owner January 17, 2021 19:31
@ghost ghost added size/M Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. service/cloudwatchlogs tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 17, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Jan 17, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @punkle 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@punkle punkle force-pushed the f-data_source_aws_cloudwatch_log_groups branch from 4cc24db to 63f06a4 Compare January 17, 2021 20:08
@ghost ghost added the documentation Introduces or discusses updates to documentation. label Jan 17, 2021
@punkle punkle force-pushed the f-data_source_aws_cloudwatch_log_groups branch from 63f06a4 to c394dc9 Compare January 17, 2021 20:14
Base automatically changed from master to main January 23, 2021 01:00
@punkle
Copy link
Contributor Author

punkle commented Jul 14, 2021

Bump.

@breathingdust breathingdust added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 8, 2021
@ewbankkit ewbankkit force-pushed the f-data_source_aws_cloudwatch_log_groups branch from c394dc9 to 0278225 Compare September 21, 2021 21:38
@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Sep 21, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TESTARGS='-run=TestAccAWSCloudwatchLogGroupsDataSource_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCloudwatchLogGroupsDataSource_basic -timeout 180m
=== RUN   TestAccAWSCloudwatchLogGroupsDataSource_basic
=== PAUSE TestAccAWSCloudwatchLogGroupsDataSource_basic
=== CONT  TestAccAWSCloudwatchLogGroupsDataSource_basic
--- PASS: TestAccAWSCloudwatchLogGroupsDataSource_basic (15.11s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	19.323s
GovCloud
% make testacc TESTARGS='-run=TestAccAWSCloudwatchLogGroupsDataSource_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCloudwatchLogGroupsDataSource_basic -timeout 180m
=== RUN   TestAccAWSCloudwatchLogGroupsDataSource_basic
=== PAUSE TestAccAWSCloudwatchLogGroupsDataSource_basic
=== CONT  TestAccAWSCloudwatchLogGroupsDataSource_basic
--- PASS: TestAccAWSCloudwatchLogGroupsDataSource_basic (17.72s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	23.825s

@ewbankkit
Copy link
Contributor

ewbankkit commented Sep 21, 2021

@punkle Thanks for the contribution 🎉 👏.

Note that I changed the arns attribute to remove the :* suffix, like the resource but not (yet) the singular data source.

@ewbankkit ewbankkit merged commit bda226f into hashicorp:main Sep 21, 2021
@github-actions github-actions bot added this to the v3.60.0 milestone Sep 21, 2021
@github-actions
Copy link

This functionality has been released in v3.60.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-data-source Introduces a new data source. provider Pertains to the provider itself, rather than any interaction with AWS. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a data source for aws_cloudwatch_log_groups
3 participants