Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/resource/aws_secretsmanager_secret: CheckDestroy Eventual Consistency #13181

Closed
bflad opened this issue May 6, 2020 · 2 comments · Fixed by #13183
Closed

tests/resource/aws_secretsmanager_secret: CheckDestroy Eventual Consistency #13181

bflad opened this issue May 6, 2020 · 2 comments · Fixed by #13183
Assignees
@bflad
Labels
service/secretsmanager Issues and PRs that pertain to the secretsmanager service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Milestone
v2.63.0

Comments

@bflad
Copy link
Contributor

bflad commented May 6, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform Version

terraform-provider-aws v2.60.0

Affected Resource(s)

  • aws_secretsmanager_secret
  • Potentially: aws_secretsmanager_secret_version

Expected Behavior

--- PASS: TestAccAwsSecretsManagerSecret_KmsKeyID (15.88s)

Actual Behavior

Inconsistent and not specific to this test, but as an example:

--- FAIL: TestAccAwsSecretsManagerSecret_KmsKeyID (15.88s)
testing.go:730: Error destroying resource! WARNING: Dangling resources
may exist. The full state and error is shown below.
Error: Check failed: Secret "arn:aws:secretsmanager:us-west-2:*******:secret:tf-acc-test-1474541242563805997-gsKWAL" still exists

Its likely that resource.Retry() logic needs to be added to testAccCheckAwsSecretsManagerSecretDestroy.

Steps to Reproduce

  1. TF_ACC=1 go test ./aws -v -count 1 -timeout 120m -parallel 20 -run=TestAccAwsSecretsManagerSecret_
@bflad bflad added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/secretsmanager Issues and PRs that pertain to the secretsmanager service. labels May 6, 2020
@bflad bflad self-assigned this May 6, 2020
bflad added a commit that referenced this issue May 6, 2020
@bflad
resource/aws_secretsmanager_secret: Move hardcoded timeout to waiter …
b105840 
…package, allow retries in CheckDestroy

Reference: #13181

Output from acceptance testing:

```
--- PASS: TestAccAwsSecretsManagerSecret_policy (17.07s)
--- PASS: TestAccAwsSecretsManagerSecret_Basic (18.46s)
--- PASS: TestAccAwsSecretsManagerSecret_withNamePrefix (18.51s)
--- PASS: TestAccAwsSecretsManagerSecret_Description (29.61s)
--- PASS: TestAccAwsSecretsManagerSecret_KmsKeyID (39.60s)
--- PASS: TestAccAwsSecretsManagerSecret_RecoveryWindowInDays_Recreate (46.97s)
--- PASS: TestAccAwsSecretsManagerSecret_Tags (50.57s)
--- PASS: TestAccAwsSecretsManagerSecret_RotationRules (57.98s)
--- PASS: TestAccAwsSecretsManagerSecret_RotationLambdaARN (68.12s)
```
@bflad bflad mentioned this issue May 6, 2020
Merged
@bflad bflad added this to the v2.63.0 milestone May 19, 2020
bflad added a commit that referenced this issue May 19, 2020
@bflad
resource/aws_secretsmanager_secret: Move hardcoded timeout to waiter …
0c94fcd 
…package, allow retries in CheckDestroy (#13183)

Reference: #13181

Output from acceptance testing:

```
--- PASS: TestAccAwsSecretsManagerSecret_policy (17.07s)
--- PASS: TestAccAwsSecretsManagerSecret_Basic (18.46s)
--- PASS: TestAccAwsSecretsManagerSecret_withNamePrefix (18.51s)
--- PASS: TestAccAwsSecretsManagerSecret_Description (29.61s)
--- PASS: TestAccAwsSecretsManagerSecret_KmsKeyID (39.60s)
--- PASS: TestAccAwsSecretsManagerSecret_RecoveryWindowInDays_Recreate (46.97s)
--- PASS: TestAccAwsSecretsManagerSecret_Tags (50.57s)
--- PASS: TestAccAwsSecretsManagerSecret_RotationRules (57.98s)
--- PASS: TestAccAwsSecretsManagerSecret_RotationLambdaARN (68.12s)
```
@ghost
Copy link

ghost commented May 22, 2020

This has been released in version 2.63.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

adamdecaf pushed a commit to adamdecaf/terraform-provider-aws that referenced this issue May 28, 2020
@bflad @adamdecaf
resource/aws_secretsmanager_secret: Move hardcoded timeout to waiter …
8a4fde4 
…package, allow retries in CheckDestroy (hashicorp#13183)

Reference: hashicorp#13181

Output from acceptance testing:

```
--- PASS: TestAccAwsSecretsManagerSecret_policy (17.07s)
--- PASS: TestAccAwsSecretsManagerSecret_Basic (18.46s)
--- PASS: TestAccAwsSecretsManagerSecret_withNamePrefix (18.51s)
--- PASS: TestAccAwsSecretsManagerSecret_Description (29.61s)
--- PASS: TestAccAwsSecretsManagerSecret_KmsKeyID (39.60s)
--- PASS: TestAccAwsSecretsManagerSecret_RecoveryWindowInDays_Recreate (46.97s)
--- PASS: TestAccAwsSecretsManagerSecret_Tags (50.57s)
--- PASS: TestAccAwsSecretsManagerSecret_RotationRules (57.98s)
--- PASS: TestAccAwsSecretsManagerSecret_RotationLambdaARN (68.12s)
```
@ghost
Copy link

ghost commented Jun 19, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bflad bflad

Labels
service/secretsmanager Issues and PRs that pertain to the secretsmanager service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.63.0
1 participant
@bflad