Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws_vpc data source doesn't return the enable_dns_hostnames attribute #1310

Closed
mconigliaro opened this issue Aug 2, 2017 · 1 comment · Fixed by #1373
Closed

aws_vpc data source doesn't return the enable_dns_hostnames attribute #1310

mconigliaro opened this issue Aug 2, 2017 · 1 comment · Fixed by #1373
Labels
enhancement Requests to existing resources that expand the functionality or scope.

Comments

@mconigliaro
Copy link

Terraform Version

Terraform v0.9.11

Affected Resource(s)

  • aws_vpc

References
@radeksimko radeksimko added the enhancement Requests to existing resources that expand the functionality or scope. label Aug 3, 2017
stack72 added a commit to stack72/terraform-provider-aws that referenced this issue Aug 9, 2017
@stack72
data/aws_vpc: Expose enable_dns_* in aws_vpc data_source
bf46e48 
Fixes: hashicorp#1310

```
% make testacc TEST=./aws TESTARGS='-run=TestAccDataSourceAwsVpc_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccDataSourceAwsVpc_ -timeout 120m
=== RUN   TestAccDataSourceAwsVpc_basic
--- PASS: TestAccDataSourceAwsVpc_basic (57.65s)
=== RUN   TestAccDataSourceAwsVpc_ipv6Associated
--- PASS: TestAccDataSourceAwsVpc_ipv6Associated (56.97s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	114.644s
```

```
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSVpc_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSVpc_ -timeout 120m
=== RUN   TestAccAWSVpc_importBasic
--- PASS: TestAccAWSVpc_importBasic (55.77s)
=== RUN   TestAccAWSVpc_basic
--- PASS: TestAccAWSVpc_basic (45.39s)
=== RUN   TestAccAWSVpc_enableIpv6
--- PASS: TestAccAWSVpc_enableIpv6 (122.24s)
=== RUN   TestAccAWSVpc_dedicatedTenancy
--- PASS: TestAccAWSVpc_dedicatedTenancy (47.45s)
=== RUN   TestAccAWSVpc_tags
--- PASS: TestAccAWSVpc_tags (84.16s)
=== RUN   TestAccAWSVpc_update
--- PASS: TestAccAWSVpc_update (83.19s)
=== RUN   TestAccAWSVpc_bothDnsOptionsSet
--- PASS: TestAccAWSVpc_bothDnsOptionsSet (19.69s)
=== RUN   TestAccAWSVpc_DisabledDnsSupport
--- PASS: TestAccAWSVpc_DisabledDnsSupport (44.98s)
=== RUN   TestAccAWSVpc_classiclinkOptionSet
--- PASS: TestAccAWSVpc_classiclinkOptionSet (45.00s)
=== RUN   TestAccAWSVpc_classiclinkDnsSupportOptionSet
--- PASS: TestAccAWSVpc_classiclinkDnsSupportOptionSet (46.06s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	593.935s
```
@stack72 stack72 mentioned this issue Aug 9, 2017
Merged
nbaztec pushed a commit to nbaztec/terraform-provider-aws that referenced this issue Sep 26, 2017
@stack72
data/aws_vpc: Expose enable_dns_* in aws_vpc data_source
4c7cbef 
Fixes: hashicorp#1310

```
% make testacc TEST=./aws TESTARGS='-run=TestAccDataSourceAwsVpc_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccDataSourceAwsVpc_ -timeout 120m
=== RUN   TestAccDataSourceAwsVpc_basic
--- PASS: TestAccDataSourceAwsVpc_basic (57.65s)
=== RUN   TestAccDataSourceAwsVpc_ipv6Associated
--- PASS: TestAccDataSourceAwsVpc_ipv6Associated (56.97s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	114.644s
```

```
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSVpc_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSVpc_ -timeout 120m
=== RUN   TestAccAWSVpc_importBasic
--- PASS: TestAccAWSVpc_importBasic (55.77s)
=== RUN   TestAccAWSVpc_basic
--- PASS: TestAccAWSVpc_basic (45.39s)
=== RUN   TestAccAWSVpc_enableIpv6
--- PASS: TestAccAWSVpc_enableIpv6 (122.24s)
=== RUN   TestAccAWSVpc_dedicatedTenancy
--- PASS: TestAccAWSVpc_dedicatedTenancy (47.45s)
=== RUN   TestAccAWSVpc_tags
--- PASS: TestAccAWSVpc_tags (84.16s)
=== RUN   TestAccAWSVpc_update
--- PASS: TestAccAWSVpc_update (83.19s)
=== RUN   TestAccAWSVpc_bothDnsOptionsSet
--- PASS: TestAccAWSVpc_bothDnsOptionsSet (19.69s)
=== RUN   TestAccAWSVpc_DisabledDnsSupport
--- PASS: TestAccAWSVpc_DisabledDnsSupport (44.98s)
=== RUN   TestAccAWSVpc_classiclinkOptionSet
--- PASS: TestAccAWSVpc_classiclinkOptionSet (45.00s)
=== RUN   TestAccAWSVpc_classiclinkDnsSupportOptionSet
--- PASS: TestAccAWSVpc_classiclinkDnsSupportOptionSet (46.06s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	593.935s
```
@ghost
Copy link

ghost commented Apr 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

data/aws_vpc: Expose enable_dns_* in aws_vpc data_source stack72/terraform-provider-aws
2 participants
@mconigliaro @radeksimko